Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check for thrown exception upstream and exit 1 #40

Closed
scottcorgan opened this issue Sep 23, 2015 · 4 comments
Closed

check for thrown exception upstream and exit 1 #40

scottcorgan opened this issue Sep 23, 2015 · 4 comments

Comments

@scottcorgan
Copy link
Owner

No description provided.

@markuswustenberg
Copy link

We just got bitten by this, thinking our test suite succeeded when in fact tests had syntax errors. Cool that there's an issue tracking this already. :) @scottcorgan Any ETA? I may get time to look at it myself, although I don't know the tap-spec code base (yet).

@scottcorgan
Copy link
Owner Author

@markuswustenberg I'm not an stdout/stdin specialist so I've been unable to fix this yet. It's very annoying and shouldn't happen. Any input or suggestions are VERY much welcome!

@jamestalmage jamestalmage mentioned this issue Nov 17, 2015
Closed
jamestalmage added a commit to jamestalmage/ava that referenced this issue Nov 17, 2015
@jamestalmage
cause build to fail if tape exits with a non-zero exit code
a0408ea 
This is the only solution I have found so far.

See: scottcorgan/tap-spec#40
@jamestalmage jamestalmage mentioned this issue Nov 17, 2015
Closed
jamestalmage added a commit to jamestalmage/ava that referenced this issue Nov 17, 2015
@jamestalmage
cause build to fail if tape exits with a non-zero exit code
4218f0e 
This is the only solution I have found so far.

See: scottcorgan/tap-spec#40
This was referenced Nov 17, 2015
Merged
Closed
@scottcorgan
Copy link
Owner Author

Fixed! And released as 4.1.1. Many thanks to @jamestalmage for fix on scottcorgan/tap-out#18

@jamestalmage
Copy link

👍

This was referenced Oct 30, 2016
Open
Closed
@kgryte kgryte mentioned this issue Dec 13, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use faucet tap reporter jamestalmage/ava
3 participants
@markuswustenberg @scottcorgan @jamestalmage