Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail if tape failed #14

Open
derhuerst opened this issue Oct 30, 2016 · 5 comments
Open

fail if tape failed #14

derhuerst opened this issue Oct 30, 2016 · 5 comments

Comments

@derhuerst
Copy link

derhuerst commented Oct 30, 2016

Right now, tests run with node test.js | tap-dot will pass even if test.js throws an error immediately. The well-known tap-spec reporter changed this behaviour as of scottcorgan/tap-spec#40.

Thanks for this great module!

@derhuerst
Copy link
Author

Oops, it actually works. Sorry for the noise!

@markasoftware
Copy link

Hmm, I still get the same problem. There are certain tests I can run where tap-spec reports an error but tap-dot does not.

@derhuerst
Copy link
Author

@markasoftware Can you give a specific TAP output where that is the case?

@markasoftware
Copy link

@derhuerst http://ix.io/1gE0 is the example I'm going with. When my testing script just has a random throw 5 statement in it, it cuts off the output, but tap-dot still thinks it's a success. What it should do is wait for the # ok output before exiting with code 0.

@derhuerst
Copy link
Author

derhuerst commented Jul 9, 2018

Indeed this can be considered unwanted behaviour.

Indeed I had the same problem with tap-min, see gummesson/tap-min#5 and scottcorgan/tap-spec#40. I think it could be fixed by upgrading tap-out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants