emit test plans #18
Merged
emit test plans #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SOOO thankful you did this! Thank you! Haven't had time and this keeps popping up. Published as |
|
Awesome, thanks! //cc: @sindresorhus @vdemedes |
|
@jamestalmage What does this mean for us now? We're already using the builtin |
|
It means we could go back to tape and maybe get back Node 0.10 Windows tests. I see no need for this if we stick with tap. |
|
@jamestalmage Oh ok. Let's just stick with what we have right now. It seems to be working fine and I don't want to open the can of worms that is Node.js 0.10 on Windows yet. We can reconsider in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: scottcorgan/tap-spec#40
@scottcorgan
I've searched high and low, and can not find a way to determine the exit code of the process piping data to stdinn. I am not sure it exists (I know it does in bash shell, but it does not seem to at the OS level).
The way other tap reporters (i.e. faucet) seem to handle this, is that they look for the plan line (which, as I understand it is required), and then compare what they get.
This implements recognition of the plan line:
And emits it as an event.
This will allow you to correctly exit with your other reporters. Thanks!