-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove pyhf.simplemodels.hepdata_like from API #1670
feat: Remove pyhf.simplemodels.hepdata_like from API #1670
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1670 +/- ##
==========================================
- Coverage 98.07% 98.05% -0.03%
==========================================
Files 64 64
Lines 4216 4213 -3
Branches 585 585
==========================================
- Hits 4135 4131 -4
- Misses 48 49 +1
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Thanks @aryan26roy |
Note to future us: The coverage dip is because Lines 144 to 154 in c3d0acb
isn't being tested anymore. This is fine to leave in, but we might want to move it out into another module later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍 Thanks @aryan26roy!
Description
Resolves #1658.
This PR removes
pyhf.simplemodels.hepdata_like
in src/simplemodels along with the test in tests/test_simplemodels forv0.7.0
. It has been deprecated sincev0.6.2
.Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: