Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove pyhf.simplemodels.hepdata_like from API #1670

Merged
merged 2 commits into from
Oct 25, 2021

Conversation

aryan26roy
Copy link
Contributor

@aryan26roy aryan26roy commented Oct 25, 2021

Description

Resolves #1658.
This PR removes pyhf.simplemodels.hepdata_like in src/simplemodels along with the test in tests/test_simplemodels for v0.7.0. It has been deprecated since v0.6.2.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Remove pyhf.simplemodels.hepdata_like from the codebase and docs
   - pyhf.simplemodels.hepdata_like has been deprecated since v0.6.2

@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #1670 (12828c4) into master (c3d0acb) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1670      +/-   ##
==========================================
- Coverage   98.07%   98.05%   -0.03%     
==========================================
  Files          64       64              
  Lines        4216     4213       -3     
  Branches      585      585              
==========================================
- Hits         4135     4131       -4     
- Misses         48       49       +1     
  Partials       33       33              
Flag Coverage Δ
contrib 25.30% <ø> (-0.01%) ⬇️
doctest 61.07% <ø> (+0.01%) ⬆️
unittests 96.36% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pyhf/simplemodels.py 92.30% <ø> (-7.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3d0acb...12828c4. Read the comment docs.

@lukasheinrich
Copy link
Contributor

Thanks @aryan26roy

@matthewfeickert
Copy link
Member

Note to future us: The coverage dip is because

# Deprecated APIs
def _deprecated_api_warning(
deprecated_api, new_api, deprecated_release, remove_release
):
warn(
f"{deprecated_api} is deprecated in favor of {new_api} as of pyhf v{deprecated_release} and will be removed in release {remove_release}."
+ f" Please use {new_api}.",
DeprecationWarning,
stacklevel=3, # Raise to user level
)

isn't being tested anymore. This is fine to leave in, but we might want to move it out into another module later.

@matthewfeickert matthewfeickert added API Changes the public API feat/enhancement New feature or request labels Oct 25, 2021
Copy link
Member

@matthewfeickert matthewfeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍 Thanks @aryan26roy!

@matthewfeickert matthewfeickert changed the title feat: Remove hepdata_like along with the test feat: Remove pyhf.simplemodels.hepdata_like from API Oct 25, 2021
@matthewfeickert matthewfeickert merged commit 260315d into scikit-hep:master Oct 25, 2021
@aryan26roy aryan26roy deleted the remove-hepdata_like branch October 26, 2021 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Changes the public API feat/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove pyhf.simplemodels.hepdata_like from public API for v0.7.0
3 participants