Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pyhf.simplemodels.hepdata_like from public API for v0.7.0 #1658

Closed
1 task done
matthewfeickert opened this issue Oct 22, 2021 · 3 comments · Fixed by #1670
Closed
1 task done

Remove pyhf.simplemodels.hepdata_like from public API for v0.7.0 #1658

matthewfeickert opened this issue Oct 22, 2021 · 3 comments · Fixed by #1670
Labels
API Changes the public API feat/enhancement New feature or request good first issue Good for newcomers

Comments

@matthewfeickert
Copy link
Member

Summary

pyhf.simplemodels.hepdata_like has been scheduled for removal from the public API in release v0.7.0. As v0.7.0 will be the next release (and hopefully soon) this should get removed now.

Additional Information

pyhf.simplemodels.hepdata_like has been deprecated since v0.6.2.

Code of Conduct

  • I agree to follow the Code of Conduct
@matthewfeickert matthewfeickert added feat/enhancement New feature or request good first issue Good for newcomers API Changes the public API labels Oct 22, 2021
@aryan26roy
Copy link
Contributor

@matthewfeickert , can I take this one?

@matthewfeickert
Copy link
Member Author

can I take this one?

Go for it. 👍

This was referenced Oct 25, 2021
Closed
Closed
Closed
Merged
@matthewfeickert
Copy link
Member Author

@aryan26roy It seems that you're having some trouble opening up PRs. I think this happened last time with the GitHub web interface as well. To avoid creating lots of duplicates in the future, can you either just continue working on the first PR you open up or not use the web interface and use the command line?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Changes the public API feat/enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
2 participants
@matthewfeickert @aryan26roy