Backport PHP 8.4 compatibility from 7.x branch #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This then also prepares the package to be released for PHP8.4 runtimes (cherry picked from commit 0a5575e)
As Psalm is only used in one single job it can be removed in general and then reinstalled when it is actually required before it is executed. This process allows to keep Psalm in the dev-dependencies so that constributors still have it available but in CI-runs it needs not to be installed when it is not executed. (cherry picked from commit 42c8476)
|
Thanks! Released as v6.13.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR unlocks PHP 8.4 for the 6.x branch by backporting the changes from #253.
No other changes should be needed, everything works as expected on PHP 8.4 in my tests.
EDIT: The failed checks are unrelated to this change.