Allow tests to run on PHP8.4 #253
Conversation
This then also prepares the package to be released for PHP8.4 runtimes
|
I'd rather take this into a separate branch until 8.4 is actually released until all the builds can go green. Otherwise I'll have a failing build on the main branch. Then everyone who wants to use it is free to reference that branch for time being. At least that's how I did it previously to prepare for upcoming PHP releases. |
|
The challenge for users of the libs is that they then have to wait with testing their code until the libs are ready for PHP8.4. Which means that they won't be able to find issues with PHP8.4 while it's still in RC. Which in turn means that PHP doesn't actually know whether there are enough cases tested.... But I do have an idea that might make the build green again... I'll address that later and perhaps we can find a way to allow testing with 8.4 |
heiglandreas
force-pushed
the
upgrade_to_php84
branch
2 times, most recently
from
82ecbc1
to
65c8a16
Compare
As Psalm is only used in one single job it can be removed in general and then reinstalled when it is actually required before it is executed. This process allows to keep Psalm in the dev-dependencies so that constributors still have it available but in CI-runs it needs not to be installed when it is not executed.
heiglandreas
force-pushed
the
upgrade_to_php84
branch
from
65c8a16
to
99a9ccd
Compare
|
The "problem" was that Psalm isn't yet ready for PHP8.4 but everything else is. As Psalm is in CI only used in the coding-standards run (which runs under PHP8.2) I removed that package completely before the default That way it is possible to test against recent versions of PHP without having to wait for a tool that is only used with an older PHP-version to get up to speed. The psalm-dependency is still in the composer.json so that people that want to contribute have all the tools available. |
|
Yea, I understand that problem and I'm also guilty on that, since I'm typically declaring compatibility with a new version, once the stable version is released. It's the classic chicken egg problem. PHP 8.4 doesn't seem to be a big deal and I'm fine with your implementation, so let's merge it. |
This then also prepares the package to be released for PHP8.4 runtimes