Skip to content

Commit

Permalink
Remove psalm from most installations
Browse files Browse the repository at this point in the history
As Psalm is only used in one single job it can be removed in general
and then reinstalled when it is actually required before it is
executed.

This process allows to keep Psalm in the dev-dependencies so that
constributors still have it available but in CI-runs it needs not
to be installed when it is not executed.

(cherry picked from commit 42c8476)
  • Loading branch information
heiglandreas authored and scheb committed Nov 29, 2024
1 parent 4e2e954 commit 9acaa33
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
4 changes: 4 additions & 0 deletions .github/actions/setup-build/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,10 @@ runs:
shell: bash
run: composer require ${{ inputs.composer-require }} --dev --no-update --working-dir=${{ inputs.composer-working-dir }}

- name: "Remove Psalm from dependencies"
shell: bash
run: composer remove --dev vimeo/psalm

- name: "Validate composer.json"
shell: bash
run: composer validate --no-check-publish --no-check-lock --working-dir=${{ inputs.composer-working-dir }}
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@ jobs:

- name: "Psalm"
if: always()
run: vendor/bin/psalm
run: |
composer require -W --dev vimeo/psalm:^5.0
vendor/bin/psalm
unit-tests:
name: "Unit Tests - PHP ${{ matrix.php-version }}, Sf ${{ matrix.symfony-version }}${{ matrix.dependency-versions && format(', Deps: {0}', matrix.dependency-versions) }}"
Expand Down

0 comments on commit 9acaa33

Please sign in to comment.