Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publicly shared annotations #6784

Merged
merged 3 commits into from
Jan 26, 2023
Merged

Conversation

hotzenklotz
Copy link
Member

@hotzenklotz hotzenklotz commented Jan 26, 2023

PR fixes errors with publicly shared annotations.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Share an annotation publicly (i.e. with token)
  • Open annotation without being logged in
  • Everything should work again

Issues:


(Please delete unneeded items, merge only when none are left open)

@philippotto philippotto changed the title fgix publicly shared annotations Fix publicly shared annotations Jan 26, 2023
@bulldozer-boy bulldozer-boy bot merged commit c27cfff into master Jan 26, 2023
@bulldozer-boy bulldozer-boy bot deleted the fix_shared_annotations branch January 26, 2023 10:40
hotzenklotz added a commit that referenced this pull request Jan 26, 2023
…e-v11.0.0

* 'master' of github.com:scalableminds/webknossos:
  Fix publicly shared annotations (#6784)
hotzenklotz added a commit that referenced this pull request Jan 27, 2023
…e-plans

* 'master' of github.com:scalableminds/webknossos:
  Update linter to Rome v11.0.0 (#6785)
  Fix publicly shared annotations (#6784)
bulldozer-boy bot pushed a commit that referenced this pull request Feb 1, 2023
* add new blur component around certain paid features
* updated changelog
* Update frontend/javascripts/components/pricing_enforcers.tsx

Co-authored-by: Philipp Otto <[email protected]>
* Merge branch 'master' into more-plans
* Merge branch 'master' of github.com:scalableminds/webknossos into more-plans
* 'master' of github.com:scalableminds/webknossos:
  correct font in vx dag
  Catch zero-sized buckets in backend, fix http nio timeout handling (#6782)
  Remove debug logging in editable mapping logic (#6783)
  Loki for voxelytics logs (#6770)
* re-styled pricing alert
* Merge branch 'master' of github.com:scalableminds/webknossos into more-plans
* 'master' of github.com:scalableminds/webknossos:
  Update linter to Rome v11.0.0 (#6785)
  Fix publicly shared annotations (#6784)
* add isFeatureAllowedByPricingPlan helper function
* enforce pricing for creating precomputed meshes
* use isFeatureAllowedByPricingPlan for SecuredRoute
* disable proof reading tool
* prevent proof reading tool from being unsed through keyboard shortcut
* Merge branch 'master' into more-plans
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants