Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch zero-sized buckets in backend, fix http nio timeout handling #6782

Merged
merged 7 commits into from
Jan 25, 2023
Merged

Catch zero-sized buckets in backend, fix http nio timeout handling #6782

merged 7 commits into from
Jan 25, 2023

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Jan 25, 2023 •
edited
Loading

Turns out the our https filesystem provider did not correctly handle read timeouts. This produced seemingly successful bucket loading, but the arrays had zero length. This PR

  • fixes the timeout handling of those http requests
  • adds a guard against this kind of error in BinaryDataService – all zero-length arrays are considered Failures. This matches the frontend expectations.

Steps to test:

  • In HttpsSeekableByteChannel.scala, change the timeouts to be extremely short, like 1ms
  • Requesting remote zarr data should not result in rendering errors, but rather correctly behave like that the buckets could not be loaded

Issues:

@fm3 fm3 self-assigned this Jan 25, 2023
@fm3 fm3 changed the title WIP: catch zero-length buckets in backend Catch zero-sized buckets in backend, fix http nio timeout handling Jan 25, 2023
@fm3 fm3 marked this pull request as ready for review January 25, 2023 13:20
@fm3 fm3 requested a review from jstriebel January 25, 2023 13:22
jstriebel
jstriebel approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@jstriebel jstriebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fm3 fm3 enabled auto-merge (squash) January 25, 2023 13:50
@fm3 fm3 merged commit 63f31e3 into master Jan 25, 2023
@fm3 fm3 deleted the catch-empty-buckets branch January 25, 2023 14:06
hotzenklotz added a commit that referenced this pull request Jan 25, 2023
@hotzenklotz
Merge branch 'master' of github.com:scalableminds/webknossos into mor…
ed7565b 
…e-plans

* 'master' of github.com:scalableminds/webknossos:
  correct font in vx dag
  Catch zero-sized buckets in backend, fix http nio timeout handling (#6782)
  Remove debug logging in editable mapping logic (#6783)
  Loki for voxelytics logs (#6770)
bulldozer-boy bot pushed a commit that referenced this pull request Feb 1, 2023
@hotzenklotz
Enforce Pricing for Team Sharing (#6776)
b4eaeed 
* add new blur component around certain paid features
* updated changelog
* Update frontend/javascripts/components/pricing_enforcers.tsx

Co-authored-by: Philipp Otto <[email protected]>
* Merge branch 'master' into more-plans
* Merge branch 'master' of github.com:scalableminds/webknossos into more-plans
* 'master' of github.com:scalableminds/webknossos:
  correct font in vx dag
  Catch zero-sized buckets in backend, fix http nio timeout handling (#6782)
  Remove debug logging in editable mapping logic (#6783)
  Loki for voxelytics logs (#6770)
* re-styled pricing alert
* Merge branch 'master' of github.com:scalableminds/webknossos into more-plans
* 'master' of github.com:scalableminds/webknossos:
  Update linter to Rome v11.0.0 (#6785)
  Fix publicly shared annotations (#6784)
* add isFeatureAllowedByPricingPlan helper function
* enforce pricing for creating precomputed meshes
* use isFeatureAllowedByPricingPlan for SecuredRoute
* disable proof reading tool
* prevent proof reading tool from being unsed through keyboard shortcut
* Merge branch 'master' into more-plans
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstriebel jstriebel jstriebel approved these changes

Assignees

@fm3 fm3

Labels
backend bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sometimes zarr data requests return too few buckets
2 participants
@fm3 @jstriebel