Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove debug logging in editable mapping logic #6783

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Jan 25, 2023

This logic has been in production long enough that we don’t need the debug logging anymore to validate its logic.
Also, with larger production mappings, the logging got quite extensive (lots of ids printed) so it spammed server logs.

Should we ever need to debug this stuff again, we can copy the logging statemenets back in from here.


  • Needs datastore update after deployment
  • Ready for review

@fm3 fm3 self-assigned this Jan 25, 2023
@fm3 fm3 requested a review from jstriebel January 25, 2023 09:11
@fm3 fm3 merged commit 4b01d14 into master Jan 25, 2023
@fm3 fm3 deleted the editable-mapping-no-logging branch January 25, 2023 13:43
hotzenklotz added a commit that referenced this pull request Jan 25, 2023
…e-plans

* 'master' of github.com:scalableminds/webknossos:
  correct font in vx dag
  Catch zero-sized buckets in backend, fix http nio timeout handling (#6782)
  Remove debug logging in editable mapping logic (#6783)
  Loki for voxelytics logs (#6770)
bulldozer-boy bot pushed a commit that referenced this pull request Feb 1, 2023
* add new blur component around certain paid features
* updated changelog
* Update frontend/javascripts/components/pricing_enforcers.tsx

Co-authored-by: Philipp Otto <[email protected]>
* Merge branch 'master' into more-plans
* Merge branch 'master' of github.com:scalableminds/webknossos into more-plans
* 'master' of github.com:scalableminds/webknossos:
  correct font in vx dag
  Catch zero-sized buckets in backend, fix http nio timeout handling (#6782)
  Remove debug logging in editable mapping logic (#6783)
  Loki for voxelytics logs (#6770)
* re-styled pricing alert
* Merge branch 'master' of github.com:scalableminds/webknossos into more-plans
* 'master' of github.com:scalableminds/webknossos:
  Update linter to Rome v11.0.0 (#6785)
  Fix publicly shared annotations (#6784)
* add isFeatureAllowedByPricingPlan helper function
* enforce pricing for creating precomputed meshes
* use isFeatureAllowedByPricingPlan for SecuredRoute
* disable proof reading tool
* prevent proof reading tool from being unsed through keyboard shortcut
* Merge branch 'master' into more-plans
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants