Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix antd deprecation warning for <Modal open/visible> #6765

Merged
merged 3 commits into from
Jan 19, 2023

Conversation

hotzenklotz
Copy link
Member

@hotzenklotz hotzenklotz commented Jan 19, 2023

I received a lot of antd deprecation warning/erros in my developer console about a <Modal> components' visible props. The prop has been renamed to open.
This PR refactors a bunch of wk modals to use the new open prop name. Wherever possible is also renamed of props/state accordingly.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Run type checker/linter
  • Open as many modals as you can think of

Issues:

  • None

(Please delete unneeded items, merge only when none are left open)

@hotzenklotz hotzenklotz self-assigned this Jan 19, 2023
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

@bulldozer-boy bulldozer-boy bot merged commit e9d9d3d into master Jan 19, 2023
@bulldozer-boy bulldozer-boy bot deleted the rename_mpdal_open branch January 19, 2023 14:15
hotzenklotz added a commit that referenced this pull request Jan 19, 2023
…orce_plan

* 'master' of github.com:scalableminds/webknossos:
  Fix antd deprecation warning for <Modal open/visible> (#6765)
  Fix exploring remote datasets with no credentials (#6764)
bulldozer-boy bot pushed a commit that referenced this pull request Jan 23, 2023
* enforce pricing plan for features (WIP)
* enforce pricing for navbar links
* Merge branch 'master' of github.com:scalableminds/webknossos into enforce_plan

* 'master' of github.com:scalableminds/webknossos:
  Update VoxelyticsDAO.scala
  Show voxel size in details sidebar in new datasets tab (#6755)
  Fix font import (#6754)
  Fix breadcrumbs (II) (#6753)
* add organization to store
* fix type errors for activeOrganization
* Merge branch 'master' of github.com:scalableminds/webknossos into enforce_plan

* 'master' of github.com:scalableminds/webknossos:
  Make voxelytics sql queries compatible with postgres 10 (#6763)
  Adapt viewport and crosshair colors to new color scheme (#6760)
  minor logo fix (#6762)
  Fix superuser organization switching (#6756)
* naming stuff is hard
* Merge branch 'master' of github.com:scalableminds/webknossos into enforce_plan
* 'master' of github.com:scalableminds/webknossos:
  Fix antd deprecation warning for <Modal open/visible> (#6765)
  Fix exploring remote datasets with no credentials (#6764)
* added new page for when features are not available due to pricing limits
* prevent folder creation on dashboard
* Merge branch 'master' into enforce_plan
* applied PR feedback
* applied even more PR feedback
* Update frontend/javascripts/components/pricing_enforcers.tsx

Co-authored-by: Philipp Otto <[email protected]>
* Update frontend/javascripts/components/pricing_enforcers.tsx

Co-authored-by: Philipp Otto <[email protected]>
* Merge branch 'master' into enforce_plan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants