Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make voxelytics sql queries compatible with postgres 10 #6763

Merged
merged 2 commits into from
Jan 19, 2023
Merged

Make voxelytics sql queries compatible with postgres 10 #6763

merged 2 commits into from
Jan 19, 2023

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Jan 19, 2023

The queries contained some aliasing with reserved names (name,version,timestamp). I removed those aliases completely as they were unused (context was positional anyway)

Steps to test:

  • Set up wk locally with postgres 10 (not newer)
  • features.voxelyticsEnabled = true
  • set up voxelytics to report to that local webknossos
  • voxelytics workflow should run through normally
  • vieweing the voxelytics workflow in wk should not cause sql errors
  • listing voxelytics workflows in wk should also not cause sql errors

Issues:

  • Ready for review

@fm3 fm3 requested a review from normanrz January 19, 2023 09:19
@fm3 fm3 self-assigned this Jan 19, 2023
@fm3 fm3 enabled auto-merge (squash) January 19, 2023 09:23
@fm3 fm3 merged commit 20fd509 into master Jan 19, 2023
@fm3 fm3 deleted the vx-pg10 branch January 19, 2023 09:38
hotzenklotz added a commit that referenced this pull request Jan 19, 2023
@hotzenklotz
Merge branch 'master' of github.com:scalableminds/webknossos into enf…
b627c5b 
…orce_plan

* 'master' of github.com:scalableminds/webknossos:
  Make voxelytics sql queries compatible with postgres 10 (#6763)
  Adapt viewport and crosshair colors to new color scheme (#6760)
  minor logo fix (#6762)
  Fix superuser organization switching (#6756)
bulldozer-boy bot pushed a commit that referenced this pull request Jan 23, 2023
@hotzenklotz
Enforce Pricing for Task/Project Management Features (#6767)
d195800 
* enforce pricing plan for features (WIP)
* enforce pricing for navbar links
* Merge branch 'master' of github.com:scalableminds/webknossos into enforce_plan

* 'master' of github.com:scalableminds/webknossos:
  Update VoxelyticsDAO.scala
  Show voxel size in details sidebar in new datasets tab (#6755)
  Fix font import (#6754)
  Fix breadcrumbs (II) (#6753)
* add organization to store
* fix type errors for activeOrganization
* Merge branch 'master' of github.com:scalableminds/webknossos into enforce_plan

* 'master' of github.com:scalableminds/webknossos:
  Make voxelytics sql queries compatible with postgres 10 (#6763)
  Adapt viewport and crosshair colors to new color scheme (#6760)
  minor logo fix (#6762)
  Fix superuser organization switching (#6756)
* naming stuff is hard
* Merge branch 'master' of github.com:scalableminds/webknossos into enforce_plan
* 'master' of github.com:scalableminds/webknossos:
  Fix antd deprecation warning for <Modal open/visible> (#6765)
  Fix exploring remote datasets with no credentials (#6764)
* added new page for when features are not available due to pricing limits
* prevent folder creation on dashboard
* Merge branch 'master' into enforce_plan
* applied PR feedback
* applied even more PR feedback
* Update frontend/javascripts/components/pricing_enforcers.tsx

Co-authored-by: Philipp Otto <[email protected]>
* Update frontend/javascripts/components/pricing_enforcers.tsx

Co-authored-by: Philipp Otto <[email protected]>
* Merge branch 'master' into enforce_plan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@normanrz normanrz normanrz approved these changes

Assignees

@fm3 fm3

Labels
backend bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

postgres errors with postgres 10 in voxelytics dao
2 participants
@fm3 @normanrz