Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix font import #6754

Merged
merged 2 commits into from
Jan 17, 2023
Merged

Fix font import #6754

merged 2 commits into from
Jan 17, 2023

Conversation

normanrz
Copy link
Member

  • Ready for review

@normanrz normanrz requested a review from philippotto January 17, 2023 14:55
@normanrz normanrz self-assigned this Jan 17, 2023
philippotto
philippotto approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the tech(variations) stuff, but you probably tested it. For the record: where was the font import broken? For me, it already worked..

@normanrz
Copy link
Member Author

tech(variations) doesn't seem to be necessary, but broke the font import on Safari.

@bulldozer-boy bulldozer-boy bot merged commit a6b2e1d into master Jan 17, 2023
@bulldozer-boy bulldozer-boy bot deleted the font-fix branch January 17, 2023 16:40
hotzenklotz added a commit that referenced this pull request Jan 19, 2023
@hotzenklotz
Merge branch 'master' of github.com:scalableminds/webknossos into enf…
b480e3f 
…orce_plan

* 'master' of github.com:scalableminds/webknossos:
  Update VoxelyticsDAO.scala
  Show voxel size in details sidebar in new datasets tab (#6755)
  Fix font import (#6754)
  Fix breadcrumbs (II) (#6753)
bulldozer-boy bot pushed a commit that referenced this pull request Jan 23, 2023
@hotzenklotz
Enforce Pricing for Task/Project Management Features (#6767)
d195800 
* enforce pricing plan for features (WIP)
* enforce pricing for navbar links
* Merge branch 'master' of github.com:scalableminds/webknossos into enforce_plan

* 'master' of github.com:scalableminds/webknossos:
  Update VoxelyticsDAO.scala
  Show voxel size in details sidebar in new datasets tab (#6755)
  Fix font import (#6754)
  Fix breadcrumbs (II) (#6753)
* add organization to store
* fix type errors for activeOrganization
* Merge branch 'master' of github.com:scalableminds/webknossos into enforce_plan

* 'master' of github.com:scalableminds/webknossos:
  Make voxelytics sql queries compatible with postgres 10 (#6763)
  Adapt viewport and crosshair colors to new color scheme (#6760)
  minor logo fix (#6762)
  Fix superuser organization switching (#6756)
* naming stuff is hard
* Merge branch 'master' of github.com:scalableminds/webknossos into enforce_plan
* 'master' of github.com:scalableminds/webknossos:
  Fix antd deprecation warning for <Modal open/visible> (#6765)
  Fix exploring remote datasets with no credentials (#6764)
* added new page for when features are not available due to pricing limits
* prevent folder creation on dashboard
* Merge branch 'master' into enforce_plan
* applied PR feedback
* applied even more PR feedback
* Update frontend/javascripts/components/pricing_enforcers.tsx

Co-authored-by: Philipp Otto <[email protected]>
* Update frontend/javascripts/components/pricing_enforcers.tsx

Co-authored-by: Philipp Otto <[email protected]>
* Merge branch 'master' into enforce_plan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto approved these changes

Assignees

@normanrz normanrz

Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@normanrz @philippotto