Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix analytics event for dataset-upload-page #5526

Merged
merged 2 commits into from
May 31, 2021
Merged

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented May 31, 2021

…and never show error for failed analytics requests

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • open dataset upload page
  • analytics request should succeed and no error toast should be shown
  • break analytics route (or use ublock origin)
  • request should fail but it should not raise an error toast

Issues:


@philippotto philippotto requested a review from fm3 May 31, 2021 08:24
@philippotto philippotto self-assigned this May 31, 2021
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

I assume {} is flow’s type annotation for objects? Are there any other places where we should replace Object by {}? (possibly in follow-up issue)?

@philippotto
Copy link
Member Author

I assume {} is flow’s type annotation for objects? Are there any other places where we should replace Object by {}? (possibly in follow-up issue)?

Yes, good point! I created #5527 as a follow-up.

@philippotto philippotto merged commit b3316c8 into master May 31, 2021
@philippotto philippotto deleted the fix-analytics-event branch May 31, 2021 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants