Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove any Object annotations #5527

Closed
philippotto opened this issue May 31, 2021 · 1 comment
Closed

Remove any Object annotations #5527

philippotto opened this issue May 31, 2021 · 1 comment

Comments

@philippotto
Copy link
Member

Object is an alias for any and therefore quite bad for typing coverage. We should replace it by more precise types ({} comes closest to representing an actual Object with arbitrary keys).

I think, it's independent of #5338 since it strenghtens the typings in both type flavors.

@hotzenklotz
Copy link
Member

hotzenklotz commented Oct 14, 2022

As far as I can tell there is only one Object type remaining: https://github.com/scalableminds/webknossos/blob/master/frontend/javascripts/admin/admin_rest_api.ts#L2215

I guess we have significantly improved our typing game in the meantime :-) Consider fixing or closing the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants