Improve error message & more frontend analytics #5490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippotto
requested changes
May 17, 2021
| @@ -237,6 +242,9 @@ class DatasetActionView extends React.PureComponent<Props, State> { | |||
| to={`/datasets/${dataset.owningOrganization}/${dataset.name}/edit`} | |||
| title="Open Dataset Settings" | |||
| disabled={isReloading} | |||
| onClick={() => | |||
| sendAnalyticsEvent("open_dataset_settings", { datasetName: dataset.name }) | |||
There was a problem hiding this comment.
I think, it would be better to trigger this event within componentDidMount of the settings view. That way, we also catch this event, when another settings link is used (e.g., within the dataset-info-tab of the tracing view).
| let needsConversion = true; | ||
| for (const file of files) { | ||
| const filenameParts = file.name.split("."); | ||
| const fileExtension = filenameParts[filenameParts.length - 1].toLowerCase(); | ||
| sendAnalyticsEvent("add_files_to_upload", { fileExtension }); |
There was a problem hiding this comment.
If I drop 100 files, this event will be triggered 100 times. Can we group this by fileExtension? Then, the file count could also be transmitted. E.g.
for (const fileExtension of uniqueFileExtensions) {
const fileCount = amount of files with that extension
sendAnalyticsEvent("add_files_to_upload", { fileExtension, fileCount });
}There was a problem hiding this comment.
Good catch 👍
I just applied your feedback :)
philippotto
changed the title
7 tasks
6 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an additional error Toast for #5296 to better explain the error to the user and adds the requested analytics tracking of #5445 except for "Store custom layout" as it does not make sense in my opinion as this is tightly coupled to "Customize layout (i.e. move panels, resize panels)" when the auto-saving layout is turned on (which is the default).
If you think tracking this event still makes sense just notify me 😄
URL of deployed dev instance (used for testing):
Steps to test:
http://<>/projects/create)I added the second error, to tell the user why this step failed and how to fix this error.
Issues:
[ ] Updated (unreleased) changelog[ ] Updated (unreleased) migration guide if applicable[ ] Updated documentation if applicable[ ] Adapted wk-connect if datastore API changes[ ] Needs datastore update after deployment