Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix needsConversion detection in dataset upload #5528

Merged
merged 1 commit into from
May 31, 2021
Merged

Fix needsConversion detection in dataset upload #5528

merged 1 commit into from
May 31, 2021

Conversation

fm3
Copy link
Member

@fm3 fm3 commented May 31, 2021

Fixes a regression introduced in #5490

Steps to test:

  • set up jobsEnabled
  • drop zip with tiffs in dataset upload view
  • upload
  • job should bestarted
  • Ready for review

@fm3 fm3 requested a review from philippotto May 31, 2021 11:04
@fm3 fm3 self-assigned this May 31, 2021
@fm3 fm3 added the frontend label May 31, 2021
philippotto
philippotto approved these changes May 31, 2021
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for investigating this!

@fm3 fm3 enabled auto-merge (squash) May 31, 2021 11:24
@fm3 fm3 merged commit d320653 into master May 31, 2021
@philippotto philippotto deleted the fix-needs-conversion branch May 31, 2021 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto approved these changes

Assignees

@fm3 fm3

Labels
bug frontend urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fm3 @philippotto