Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed CONSTANT_UPPERCASE doesn't handle number in middle name #1604

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

Cheshiriks
Copy link
Member

What's done:

  • fixed regular expression

Closes #1572

### What's done:
* fixed regular expression

Closes #1572
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #1604 (25ecebd) into master (1cf345b) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #1604   +/-   ##
=========================================
  Coverage     82.43%   82.43%           
  Complexity     2328     2328           
=========================================
  Files           112      112           
  Lines          7851     7851           
  Branches       2037     2037           
=========================================
  Hits           6472     6472           
  Misses          453      453           
  Partials        926      926           
Flag Coverage Δ
unittests 82.43% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/org/cqfn/diktat/ruleset/utils/StringCaseUtils.kt 86.41% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

2 008 tests  +1   1 993 ✔️ +1   18m 1s ⏱️ -18s
   165 suites ±0        15 💤 ±0 
   165 files   ±0          0 ±0 

Results for commit 25ecebd. ± Comparison against base commit 1cf345b.

@github-actions
Copy link
Contributor

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   39m 2s ⏱️ + 5m 9s
1 989 tests +1  1 970 ✔️ +1  15 💤 ±0  4 ±0 
1 993 runs  +1  1 974 ✔️ +1  15 💤 ±0  4 ±0 

For more details on these failures, see this check.

Results for commit 25ecebd. ± Comparison against base commit 1cf345b.

@Cheshiriks Cheshiriks merged commit 3413302 into master Jan 30, 2023
@Cheshiriks Cheshiriks deleted the bugfix/number_in_name branch January 30, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CONSTANT_UPPERCASE doesn't handle number in middle name
2 participants