Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONSTANT_UPPERCASE doesn't handle number in middle name #1572

Closed
nulls opened this issue Nov 17, 2022 · 0 comments · Fixed by #1604
Closed

CONSTANT_UPPERCASE doesn't handle number in middle name #1572

nulls opened this issue Nov 17, 2022 · 0 comments · Fixed by #1604
Labels
bug Something isn't working
Milestone
1.2.5

Comments

@nulls
Copy link
Member

nulls commented Nov 17, 2022

Describe the bug

Warn (1:11) [CONSTANT_UPPERCASE] <val> properties from companion object or on file level mostly in all cases are constants - please use upper snake case for them: NEO4J_STARTUP_DELAY_MILLIS in

const val NEO4J_STARTUP_DELAY_MILLIS = 200L

Expected behavior

No warning in provided example

Observed behavior

Steps to Reproduce

Number in middle constant name

Environment information

  • diktat version: 1.2.3, 1.2.4.2
  • build tool (maven/gradle): gradle
  • how is diktat run (CLI, plugin, etc.): plugin
  • kotlin version: 1.7.21
  • operating system: windows
  • link to a project (if your project is public):
@nulls nulls added the bug Something isn't working label Nov 17, 2022
Cheshiriks added a commit that referenced this issue Jan 30, 2023
@Cheshiriks
Fixed CONSTANT_UPPERCASE doesn't handle number in middle name
25ecebd 
### What's done:
* fixed regular expression

Closes #1572
@Cheshiriks Cheshiriks mentioned this issue Jan 30, 2023
Merged
Cheshiriks added a commit that referenced this issue Jan 30, 2023
@Cheshiriks
Fixed CONSTANT_UPPERCASE doesn't handle number in middle name (#1604)
3413302 
### What's done:
* fixed regular expression

Closes #1572
@0x6675636b796f75676974687562 0x6675636b796f75676974687562 added this to the 1.2.5 milestone Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.2.5
Development

Successfully merging a pull request may close this issue.

Fixed CONSTANT_UPPERCASE doesn't handle number in middle name saveourtool/diktat
2 participants
@nulls @0x6675636b796f75676974687562