Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed CONSTANT_UPPERCASE doesn't handle number in middle name #1604

Merged
merged 1 commit into from
Jan 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ fun String.isLowerCamelCase(): Boolean = this.matches("[a-z]([a-z0-9])*([A-Z][a-
*
* @return boolean result
*/
fun String.isUpperSnakeCase(): Boolean = this.matches("(([A-Z]+)_*)+[A-Z0-9]*".toRegex())
fun String.isUpperSnakeCase(): Boolean = this.matches("(([A-Z0-9]+)_*)+[A-Z0-9]*".toRegex())

/**
* checking that string looks like: lower_case_for_script_names
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,16 @@ class IdentifierNamingWarnTest : LintTestBase(::IdentifierNaming) {
)
}

@Test
@Tag(WarningNames.CONSTANT_UPPERCASE)
fun `number in middle name`() {
lintMethod(
"""
const val NE04J_STARTUP_DELAY_MILLIS = 200L
""".trimIndent()
)
}

@Test
@Tags(
Tag(WarningNames.CLASS_NAME_INCORRECT),
Expand Down