-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop into master #4393
Merged
Develop into master #4393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eating-sequencing-batches
…eating-sequencing-batches
…plicate records back into the table.
…he main and forked child processes
…eating-sequencing-batches
…eating-sequencing-batches
…r-when-creating-sequencing-batches Y24-120 Part-2 Bug taken link error when creating sequencing batches
SHIV5T3R
approved these changes
Oct 3, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4393 +/- ##
=======================================
Coverage 87.72% 87.72%
=======================================
Files 1397 1397
Lines 30078 30099 +21
=======================================
+ Hits 26386 26405 +19
- Misses 3692 3694 +2 ☔ View full report in Codecov by Sentry. |
4310-y24-289-bug-exception
Y24-304 - Added fixed placement of controls when cherrypicking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Changes proposed in this pull request
14.43.2
[We have released it again with 14.43.3]Troubleshooting:
If deployment fails because of a constraint violation during the migration step of the deployment, execute the commands below and try again. This may happen if any new duplicate record was created since the part-1 was deployed, which prevents unique index creation.
The csv file will be used for inspection.
Rollback
The existing, already deployed, version is 14.43.0 . I have incremented the master version to 14.43.1 as well (otherwise it is the same as the deployed version) to identify the event later easily.
If the new version 14.43.3 fails, rollback to 14.43.1
Misc
Give a notice to DBAs. If the time of the deployment is to be changed, inform DBAs again.
Otherwise, it is usual deployment with email notification to stakeholders.
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main
]- Check story numbers included
- Check for debug code
- Check version