Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop into master #4393

Merged
merged 94 commits into from
Oct 7, 2024
Merged

Develop into master #4393

merged 94 commits into from
Oct 7, 2024

Conversation

yoldas
Copy link
Member

@yoldas yoldas commented Oct 3, 2024

Closes #

Changes proposed in this pull request

Troubleshooting:

If deployment fails because of a constraint violation during the migration step of the deployment, execute the commands below and try again. This may happen if any new duplicate record was created since the part-1 was deployed, which prevents unique index creation.

ssh sss0-prod.psd.sanger.ac.uk
cd /var/www/sequencescape/current
bundle exec rake 'support:remove_duplicate_asset_links[prod_part_2_deleted_asset_links.csv]'

The csv file will be used for inspection.

Rollback

The existing, already deployed, version is 14.43.0 . I have incremented the master version to 14.43.1 as well (otherwise it is the same as the deployed version) to identify the event later easily.

If the new version 14.43.3 fails, rollback to 14.43.1

Misc

Give a notice to DBAs. If the time of the deployment is to be changed, inform DBAs again.
Otherwise, it is usual deployment with email notification to stakeholders.

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

yoldas and others added 30 commits September 12, 2024 09:59
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 80.95238% with 4 lines in your changes missing coverage. Please review.

Project coverage is 87.72%. Comparing base (94b3790) to head (ed77842).

Files with missing lines Patch % Lines
app/models/asset_link.rb 78.94% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4393   +/-   ##
=======================================
  Coverage   87.72%   87.72%           
=======================================
  Files        1397     1397           
  Lines       30078    30099   +21     
=======================================
+ Hits        26386    26405   +19     
- Misses       3692     3694    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yoldas yoldas merged commit 6343546 into master Oct 7, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants