Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-304 - Added fixed placement of controls when cherrypicking #4385

Merged
merged 48 commits into from
Oct 7, 2024

Conversation

SHIV5T3R
Copy link
Member

Closes #4333

Changes proposed in this pull request

  • A new type of placement where the original positions on the source plate are used on the destination plate when cherrypicking.
  • Made changes to the UI to indicate the type of placement type a control plate will use.
  • Control plates can have either a fixed or random placement type, the behaviour of random (the original) placement remains the same.

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 92.15686% with 4 lines in your changes missing coverage. Please review.

Project coverage is 87.65%. Comparing base (4fe46f9) to head (c326657).
Report is 114 commits behind head on develop.

Files with missing lines Patch % Lines
app/models/cherrypick_task.rb 70.00% 3 Missing ⚠️
app/models/cherrypick_task/control_locator.rb 97.56% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4385      +/-   ##
===========================================
- Coverage    87.67%   87.65%   -0.02%     
===========================================
  Files         1397     1397              
  Lines        30078    30113      +35     
===========================================
+ Hits         26372    26397      +25     
- Misses        3706     3716      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SHIV5T3R SHIV5T3R marked this pull request as ready for review October 2, 2024 08:47
app/models/cherrypick_task.rb Outdated Show resolved Hide resolved
app/models/cherrypick_task/control_locator.rb Outdated Show resolved Hide resolved
@SHIV5T3R SHIV5T3R merged commit 6b4ecdb into develop Oct 7, 2024
22 of 23 checks passed
@SHIV5T3R SHIV5T3R deleted the y24-304-cherrypick-fixed-placement branch October 7, 2024 11:25
@SHIV5T3R SHIV5T3R restored the y24-304-cherrypick-fixed-placement branch October 7, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Y24-304 - Allow fixed placement of controls when cherrypicking
2 participants