Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-120 Part-2 Bug taken link error when creating sequencing batches #4340

Conversation

yoldas
Copy link
Member

@yoldas yoldas commented Sep 12, 2024

Closes #

Changes proposed in this pull request

  • Database migration to add a unique-together on asset_links ancestor_id and descendant id
  • Override AssetLink's create_edge method to handle race conditions

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

@yoldas yoldas linked an issue Sep 12, 2024 that may be closed by this pull request
@yoldas yoldas changed the title Y24-120 Bug taken link error when creating sequencing batches Y24-120 Part-2 Bug taken link error when creating sequencing batches Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 65.57377% with 21 lines in your changes missing coverage. Please review.

Project coverage is 87.63%. Comparing base (1bd6131) to head (a9ff092).
Report is 85 commits behind head on develop.

Files with missing lines Patch % Lines
...ib/tasks/support/remove_duplicate_asset_links.rake 16.66% 15 Missing ⚠️
app/models/asset_link.rb 78.94% 4 Missing ⚠️
lib/tasks/insdc/import_countries.rake 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4340      +/-   ##
===========================================
- Coverage    87.69%   87.63%   -0.06%     
===========================================
  Files         1395     1397       +2     
  Lines        30038    30097      +59     
===========================================
+ Hits         26343    26377      +34     
- Misses        3695     3720      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yoldas yoldas marked this pull request as ready for review September 25, 2024 02:14
Copy link
Contributor

@stevieing stevieing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor issue. Pretty good. I don't entirely understand it but it is well structured and commented.

@yoldas yoldas force-pushed the 4133-y24-120-bug-taken-link-error-when-creating-sequencing-batches branch from 550ce8a to ca3a8eb Compare October 2, 2024 21:47
@yoldas yoldas merged commit 4428fee into develop Oct 3, 2024
21 of 23 checks passed
@yoldas yoldas deleted the 4133-y24-120-bug-taken-link-error-when-creating-sequencing-batches branch October 3, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Y24-120 BUG: Taken Link error when creating sequencing batches
2 participants