Several improvements required to test salt against artifact packages #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed the ``system_install`` configuration flag, markers and behaviours when set to ``system_service`` to better reflect what it's actually used for. Fixes saltstack#96 Signed-off-by: Pedro Algarvio <[email protected]>
Added CLI support(``--system-service``) to change salt-factories to use Salt previously installed from the platform's package manager. Fixes saltstack#131 Signed-off-by: Pedro Algarvio <[email protected]>
This allows tweaking which python get's used to prefix CLI commands, when needed. Fixes saltstack#129 Signed-off-by: Pedro Algarvio <[email protected]>
…for scripts The several scripts to the Salt daemons and CLI's **must** exist. Also, passing this option will additionally make salt-factories **NOT** generate said scripts and set ``python_executable`` to ``None``. Fixes saltstack#130 Signed-off-by: Pedro Algarvio <[email protected]>
s0undt3ch
force-pushed
the
master
branch
2 times, most recently
from
5d56a7d
to
52ac4ed
Compare
…`` configs" This reverts commit 52050f6. Additionally, only inject ``engines_dirs`` and ``log_handlers_dirs`` when ``system_service=True`` or ``scripts_path`` is not ``None``. These flags suggest that the salt being imported and used by salt-factories might not be the same as the one being tested. So, in this case, make sure events and logging from started daemons still get forwarded to salt-factories. Fixes saltstack#133
Signed-off-by: Pedro Algarvio <[email protected]>
…ight script path Signed-off-by: Pedro Algarvio <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
==========================================
+ Coverage 85.87% 86.07% +0.20%
==========================================
Files 95 96 +1
Lines 5504 5568 +64
Branches 621 624 +3
==========================================
+ Hits 4726 4792 +66
- Misses 591 597 +6
+ Partials 187 179 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Pedro Algarvio <[email protected]>
Signed-off-by: Pedro Algarvio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
system_installtosystem_service.--system-serviceCLI flag support.--python-executable--scripts-dirto tell salt-factories where to look for scripts*_dirsconfigs"system_servicetestsCloses #96
Closes #129
Closes #130
Closes #131
Closes #133