Migrate system_install to system_service #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ch3LL
commented
Mar 17, 2023
| @@ -1462,7 +1462,7 @@ def __attrs_post_init__(self): | |||
| DaemonPkgMixin.__attrs_post_init__(self) | |||
|
|
|||
| def _get_impl_class(self): | |||
| if self.system_install and self.salt_pkg_install.system_service: | |||
| if self.system_service and self.salt_pkg_install.system_service: | |||
There was a problem hiding this comment.
Suggested change
| if self.system_service and self.salt_pkg_install.system_service: | |
| if self.system_service: |
I think we can change all these lines to this, correct @s0undt3ch
Ch3LL
commented
Mar 17, 2023
| @@ -1746,13 +1746,7 @@ def test_pkgs_onedir(session): | |||
| else: | |||
| file_name = "pkgtests.txt" | |||
|
|
|||
| requirements_file = os.path.join( | |||
There was a problem hiding this comment.
We don't need pkg test requirement files anymore, so I should be able to delete the files in requirements/static/pkg correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to this PR: saltstack/pytest-salt-factories#134