Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inject into the engines_dirs and log_handlers_dirs in the config when not running against a locally cloned salt #133

Closed
s0undt3ch opened this issue Jul 13, 2022 · 0 comments · Fixed by #134
Closed

Inject into the engines_dirs and log_handlers_dirs in the config when not running against a locally cloned salt #133

s0undt3ch opened this issue Jul 13, 2022 · 0 comments · Fixed by #134
Milestone
1.0.0

Comments

@s0undt3ch
Copy link
Contributor

Basically, revert 52050f6 and add some logic of when it should be injected.
s0undt3ch added a commit to s0undt3ch/pytest-salt-factories that referenced this issue Jul 13, 2022
@s0undt3ch
Revert "Use salt's entry-points instead of relying on loader ``*_dirs…
954225a 
…`` configs"

This reverts commit 52050f6.

Additionally, only inject ``engines_dirs`` and ``log_handlers_dirs`` when ``system_service=True`` or ``scripts_path`` is not ``None``.

These flags suggest that the salt being imported and used by salt-factories might not be the same as the one being tested.
So, in this case, make sure events and logging from started daemons still get forwarded to salt-factories.

Fixes saltstack#133
@s0undt3ch s0undt3ch added this to the 1.0.0 milestone Jul 13, 2022
s0undt3ch added a commit to s0undt3ch/pytest-salt-factories that referenced this issue Jul 13, 2022
@s0undt3ch
Revert "Use salt's entry-points instead of relying on loader ``*_dirs…
14c0ba2 
…`` configs"

This reverts commit 52050f6.

Additionally, only inject ``engines_dirs`` and ``log_handlers_dirs`` when ``system_service=True`` or ``scripts_path`` is not ``None``.

These flags suggest that the salt being imported and used by salt-factories might not be the same as the one being tested.
So, in this case, make sure events and logging from started daemons still get forwarded to salt-factories.

Fixes saltstack#133
@s0undt3ch s0undt3ch mentioned this issue Jul 13, 2022
Merged
s0undt3ch added a commit to s0undt3ch/pytest-salt-factories that referenced this issue Jul 13, 2022
@s0undt3ch
Revert "Use salt's entry-points instead of relying on loader ``*_dirs…
16a9d97 
…`` configs"

This reverts commit 52050f6.

Additionally, only inject ``engines_dirs`` and ``log_handlers_dirs`` when ``system_service=True`` or ``scripts_path`` is not ``None``.

These flags suggest that the salt being imported and used by salt-factories might not be the same as the one being tested.
So, in this case, make sure events and logging from started daemons still get forwarded to salt-factories.

Fixes saltstack#133
s0undt3ch added a commit to s0undt3ch/pytest-salt-factories that referenced this issue Jul 13, 2022
@s0undt3ch
Revert "Use salt's entry-points instead of relying on loader ``*_dirs…
e41f305 
…`` configs"

This reverts commit 52050f6.

Additionally, only inject ``engines_dirs`` and ``log_handlers_dirs`` when ``system_service=True`` or ``scripts_path`` is not ``None``.

These flags suggest that the salt being imported and used by salt-factories might not be the same as the one being tested.
So, in this case, make sure events and logging from started daemons still get forwarded to salt-factories.

Fixes saltstack#133
s0undt3ch added a commit that referenced this issue Jul 14, 2022
@s0undt3ch
Revert "Use salt's entry-points instead of relying on loader ``*_dirs…
44d28c2 
…`` configs"

This reverts commit 52050f6.

Additionally, only inject ``engines_dirs`` and ``log_handlers_dirs`` when ``system_service=True`` or ``scripts_path`` is not ``None``.

These flags suggest that the salt being imported and used by salt-factories might not be the same as the one being tested.
So, in this case, make sure events and logging from started daemons still get forwarded to salt-factories.

Fixes #133
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Several improvements required to test salt against artifact packages s0undt3ch/pytest-salt-factories
1 participant
@s0undt3ch