-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve methods in sage.misc.rest_index_of_methods
to fix the documentation of graphs.
#36179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchapoton
reviewed
Sep 3, 2023
fchapoton
reviewed
Sep 3, 2023
Documentation preview for this PR (built with commit a48893b; changes) is ready! 🎉 |
fchapoton
approved these changes
Sep 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, looks good and does not break the doc
Thank you. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 4, 2023
…` to fix the documentation of graphs. Fixes sagemath#36178. We ensure that method `sage.misc.rest_index_of_methods.gen_thematic_rest_table_index` adds the correct links to methods in the thematic tables of the documentation. For instance, some links were missing in the thematic tables of https:// doc.sagemath.org/html/en/reference/graphs/sage/graphs/graph.html. We also fix some links in the documentation. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36179 Reported by: David Coudert Reviewer(s): David Coudert, Frédéric Chapoton
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 5, 2023
…` to fix the documentation of graphs. Fixes sagemath#36178. We ensure that method `sage.misc.rest_index_of_methods.gen_thematic_rest_table_index` adds the correct links to methods in the thematic tables of the documentation. For instance, some links were missing in the thematic tables of https:// doc.sagemath.org/html/en/reference/graphs/sage/graphs/graph.html. We also fix some links in the documentation. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36179 Reported by: David Coudert Reviewer(s): David Coudert, Frédéric Chapoton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36178.
We ensure that method
sage.misc.rest_index_of_methods.gen_thematic_rest_table_index
adds the correct links to methods in the thematic tables of the documentation. For instance, some links were missing in the thematic tables of https://doc.sagemath.org/html/en/reference/graphs/sage/graphs/graph.html.We also fix some links in the documentation.
📝 Checklist
⌛ Dependencies