Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve methods in sage.misc.rest_index_of_methods to fix the documentation of graphs. #36179

Merged
merged 6 commits into from
Sep 10, 2023
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/sage/graphs/digraph.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@
:meth:`~DiGraph.strongly_connected_components_subgraphs` | Return the strongly connected components as a list of subgraphs.
:meth:`~DiGraph.strongly_connected_component_containing_vertex` | Return the strongly connected component containing a given vertex
:meth:`~DiGraph.strongly_connected_components` | Return the list of strongly connected components.
:meth:`~DiGraph.immediate_dominators` | Return the immediate dominators of all vertices reachable from `root`.
:meth:`~DiGraph.strong_articulation_points` | Return the strong articulation points of this digraph.


Expand Down
10 changes: 5 additions & 5 deletions src/sage/graphs/generators/chessboard.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@

The methods defined here appear in :mod:`sage.graphs.graph_generators`.

- :meth:`BishopGraph <GraphGenerators.BishopGraph>`
- :meth:`KingGraph <GraphGenerators.KingGraph>`
- :meth:`KnightGraph <GraphGenerators.KnightGraph>`
- :meth:`QueenGraph <GraphGenerators.QueenGraph>`
- :meth:`RookGraph <GraphGenerators.RookGraph>`
- :meth:`BishopGraph <sage.graphs.graph_generators.GraphGenerators.BishopGraph>`
- :meth:`KingGraph <sage.graphs.graph_generators.GraphGenerators.KingGraph>`
- :meth:`KnightGraph <sage.graphs.graph_generators.GraphGenerators.KnightGraph>`
- :meth:`QueenGraph <sage.graphs.graph_generators.GraphGenerators.QueenGraph>`
- :meth:`RookGraph <sage.graphs.graph_generators.GraphGenerators.RookGraph>`

AUTHORS:

Expand Down
18 changes: 9 additions & 9 deletions src/sage/graphs/isgci.py
Original file line number Diff line number Diff line change
Expand Up @@ -135,28 +135,28 @@

* - Apex

- :meth:`~Graph.is_apex()`,
:meth:`~Graph.apex_vertices()`
- :meth:`~sage.graphs.graph.Graph.is_apex()`,
:meth:`~sage.graphs.graph.Graph.apex_vertices()`
dcoudert marked this conversation as resolved.
Show resolved Hide resolved

* - AT_free

- :meth:`~Graph.is_asteroidal_triple_free`
- :meth:`~sage.graphs.graph.Graph.is_asteroidal_triple_free`

* - Biconnected

- :meth:`~Graph.is_biconnected`,
:meth:`~GenericGraph.blocks_and_cut_vertices`,
:meth:`~GenericGraph.blocks_and_cuts_tree`
- :meth:`~sage.graphs.graph.Graph.is_biconnected`,
:meth:`~sage.graphs.generic_graph.GenericGraph.blocks_and_cut_vertices`,
:meth:`~sage.graphs.generic_graph.GenericGraph.blocks_and_cuts_tree`

* - BinaryTrees

- :meth:`~sage.graphs.graph_generators.GraphGenerators.BalancedTree`,
:meth:`~Graph.is_tree`
:meth:`~sage.graphs.graph.Graph.is_tree`

* - Bipartite

- :meth:`~sage.graphs.graph_generators.GraphGenerators.BalancedTree`,
:meth:`~sage.graphs.graph.Graph.is_bipartite`
:meth:`~sage.graphs.generic_graph.GenericGraph.is_bipartite`

* - Block

Expand Down Expand Up @@ -212,7 +212,7 @@

* - Polyhedral

- :meth:`~sage.graphs.generic_graph.Graph.is_polyhedral`
- :meth:`~sage.graphs.graph.Graph.is_polyhedral`

* - Split

Expand Down
76 changes: 50 additions & 26 deletions src/sage/misc/rest_index_of_methods.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
from sage.misc.sageinspect import is_function_or_cython_function as _isfunction


def gen_rest_table_index(obj, names=None, sort=True, only_local_functions=True):
def gen_rest_table_index(obj, names=None, sort=True, only_local_functions=True, root=None):
r"""
Return a ReST table describing a list of functions.

Expand All @@ -35,13 +35,19 @@ def gen_rest_table_index(obj, names=None, sort=True, only_local_functions=True):
precedence over the automatically computed name for the functions. Only
used when ``list_of_entries`` is a list.

- ``sort`` (boolean; ``True``) -- whether to sort the list of methods
lexicographically.
- ``sort`` -- boolean (default: ``True``); whether to sort the list of
methods lexicographically.

- ``only_local_functions`` (boolean; ``True``) -- if ``list_of_entries`` is
a module, ``only_local_functions = True`` means that imported functions
will be filtered out. This can be useful to disable for making indexes of
e.g. catalog modules such as :mod:`sage.coding.codes_catalog`.
- ``only_local_functions`` -- boolean (default: ``True``); if
``list_of_entries`` is a module, ``only_local_functions = True`` means
that imported functions will be filtered out. This can be useful to
disable for making indexes of e.g. catalog modules such as
:mod:`sage.coding.codes_catalog`.

- ``root`` -- module or class (default: ``None``); the module, or class,
whose elements are to be listed. This is needed to recover the class when
this method is called from :meth:`gen_thematic_rest_table_index` (see
:trac:`36178`).

.. WARNING::

Expand Down Expand Up @@ -71,7 +77,7 @@ def gen_rest_table_index(obj, names=None, sort=True, only_local_functions=True):
:func:`~sage.misc.rest_index_of_methods.doc_index` @ Attribute an index name to a function.
:func:`~sage.misc.rest_index_of_methods.gen_rest_table_index` @ Return a ReST table describing a list of functions.
:func:`~sage.misc.rest_index_of_methods.gen_thematic_rest_table_index` @ Return a ReST string of thematically sorted function (or methods) of a module (or class).
:func:`~sage.misc.rest_index_of_methods.list_of_subfunctions` @ Returns the functions (resp. methods) of a given module (resp. class) with their names.
:func:`~sage.misc.rest_index_of_methods.list_of_subfunctions` @ Return the functions (resp. methods) of a given module (resp. class) with their names.
<BLANKLINE>
<BLANKLINE>

Expand Down Expand Up @@ -124,7 +130,7 @@ def gen_rest_table_index(obj, names=None, sort=True, only_local_functions=True):
:func:`~sage.misc.rest_index_of_methods.doc_index` @ Attribute an index name to a function.
:func:`~sage.misc.rest_index_of_methods.gen_rest_table_index` @ Return a ReST table describing a list of functions.
:func:`~sage.misc.rest_index_of_methods.gen_thematic_rest_table_index` @ Return a ReST string of thematically sorted function (or methods) of a module (or class).
:func:`~sage.misc.rest_index_of_methods.list_of_subfunctions` @ Returns the functions (resp. methods) of a given module (resp. class) with their names.
:func:`~sage.misc.rest_index_of_methods.list_of_subfunctions` @ Return the functions (resp. methods) of a given module (resp. class) with their names.
<BLANKLINE>
<BLANKLINE>
sage: print(gen_rest_table_index(sage.misc.rest_index_of_methods, only_local_functions=False))
Expand All @@ -135,7 +141,7 @@ def gen_rest_table_index(obj, names=None, sort=True, only_local_functions=True):
<BLANKLINE>
:func:`~sage.misc.rest_index_of_methods.doc_index` @ Attribute an index name to a function.
:func:`~sage.misc.rest_index_of_methods.gen_thematic_rest_table_index` @ Return a ReST string of thematically sorted function (or methods) of a module (or class).
:func:`~sage.misc.rest_index_of_methods.list_of_subfunctions` @ Returns the functions (resp. methods) of a given module (resp. class) with their names.
:func:`~sage.misc.rest_index_of_methods.list_of_subfunctions` @ Return the functions (resp. methods) of a given module (resp. class) with their names.
<BLANKLINE>
<BLANKLINE>

Expand All @@ -146,6 +152,13 @@ def gen_rest_table_index(obj, names=None, sort=True, only_local_functions=True):
True
sage: 'all_max_cliques`' in gen_rest_table_index(Graph) # needs sage.graphs
False

Check that :trac:`36178` is fixed::
dcoudert marked this conversation as resolved.
Show resolved Hide resolved

sage: print(gen_rest_table_index(Graph)) # needs sage.graphs
...
:meth:`~sage.graphs.graph.Graph.independent_set` @ Return a maximum independent set.
...
"""
if names is None:
names = {}
Expand All @@ -169,14 +182,24 @@ def gen_rest_table_index(obj, names=None, sort=True, only_local_functions=True):
if sort:
list_of_entries.sort(key=fname)

obj_or_root_is_class = False
if inspect.isclass(root):
obj_or_root_is_class = True
class_name = root.__name__
module_name = root.__module__
elif inspect.isclass(obj):
obj_or_root_is_class = True
class_name = obj.__name__
module_name = obj.__module__

for e in list_of_entries:
if inspect.ismethod(e):
link = ":meth:`~{module}.{cls}.{func}`".format(
module=e.im_class.__module__, cls=e.im_class.__name__,
func=fname(e))
elif _isfunction(e) and inspect.isclass(obj):
elif _isfunction(e) and obj_or_root_is_class:
link = ":meth:`~{module}.{cls}.{func}`".format(
module=obj.__module__, cls=obj.__name__, func=fname(e))
module=module_name, cls=class_name, func=fname(e))
elif _isfunction(e):
link = ":func:`~{module}.{func}`".format(
module=e.__module__, func=fname(e))
Expand Down Expand Up @@ -204,15 +227,15 @@ def gen_rest_table_index(obj, names=None, sort=True, only_local_functions=True):

def list_of_subfunctions(root, only_local_functions=True):
r"""
Returns the functions (resp. methods) of a given module (resp. class) with their names.
Return the functions (resp. methods) of a given module (resp. class) with their names.

INPUT:

- ``root`` -- the module, or class, whose elements are to be listed.

- ``only_local_functions`` (boolean; ``True``) -- if ``root`` is a module,
``only_local_functions = True`` means that imported functions will be
filtered out. This can be useful to disable for making indexes of
- ``only_local_functions`` -- boolean (default: ``True``); if ``root`` is a
module, ``only_local_functions = True`` means that imported functions will
be filtered out. This can be useful to disable for making indexes of
e.g. catalog modules such as :mod:`sage.coding.codes_catalog`.

OUTPUT:
Expand Down Expand Up @@ -276,21 +299,22 @@ def can_import(f):
return list(functions.keys()), functions


def gen_thematic_rest_table_index(root,additional_categories=None,only_local_functions=True):
def gen_thematic_rest_table_index(root, additional_categories=None, only_local_functions=True):
r"""
Return a ReST string of thematically sorted function (or methods) of a module (or class).
Return a ReST string of thematically sorted function (or methods) of a
module (or class).

INPUT:

- ``root`` -- the module, or class, whose elements are to be listed.

- ``additional_categories`` -- a dictionary associating a category (given as
a string) to a function's name. Can be used when the decorator
:func:`doc_index` does not work on a function.
- ``additional_categories`` -- dictionary (default: ``None``); a dictionary
associating a category (given as a string) to a function's name. Can be
used when the decorator :func:`doc_index` does not work on a function.

- ``only_local_functions`` (boolean; ``True``) -- if ``root`` is a module,
``only_local_functions = True`` means that imported functions will be
filtered out. This can be useful to disable for making indexes of
- ``only_local_functions`` -- boolean (default: ``True``); if ``root`` is a
module, ``only_local_functions = True`` means that imported functions will
be filtered out. This can be useful to disable for making indexes of
e.g. catalog modules such as :mod:`sage.coding.codes_catalog`.

EXAMPLES::
Expand All @@ -317,7 +341,7 @@ def gen_thematic_rest_table_index(root,additional_categories=None,only_local_fun
except AttributeError:
doc_ind = "Unsorted"
theme_to_function[doc_ind].append(f)
s = ["**"+theme+"**\n\n"+gen_rest_table_index(list_of_functions,names=names)
s = ["**" + theme + "**\n\n" + gen_rest_table_index(list_of_functions, names=names, root=root)
for theme, list_of_functions in sorted(theme_to_function.items())]
return "\n\n".join(s)

Expand Down Expand Up @@ -345,7 +369,7 @@ def doc_index(name):
'Wouhouuuuu'
"""
def hey(f):
setattr(f,"doc_index",name)
setattr(f, "doc_index", name)
return f
return hey

Expand Down