Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload coverage fails/takes very long since beta.6 #36620

Closed
2 tasks done
tobiasdiez opened this issue Nov 1, 2023 · 1 comment · Fixed by #36621
Closed
2 tasks done

Upload coverage fails/takes very long since beta.6 #36620

tobiasdiez opened this issue Nov 1, 2023 · 1 comment · Fixed by #36621
Assignees
@mkoeppe
Labels
p: critical / 2 t: bug
Milestone
sage-10.2

Comments

@tobiasdiez
Copy link
Contributor

Steps To Reproduce

https://github.com/sagemath/sage/actions/runs/6712342128/job/18241914417

Expected Behavior

Be quick (10sec)

Actual Behavior

Takes about 1.5h

Additional Information

Seems to be the case since beta 6. In particular, the PR #36367 seems to be the earliest case where the upload takes so long (which I don't quite understand, maybe an issue with a symlink?!). Alternatively, it may have been #36348 (the only other PR that touched the build & test workflow in that release cycle).

Environment

CI

Checklist

  • I have searched the existing issues for a bug report that matches the one I want to file, without success.
  • I have read the documentation and troubleshoot guide
@mkoeppe
Copy link
Contributor

mkoeppe commented Nov 1, 2023

Yes, this is quite annoying. Looking at the timestamps in the log:

[2023-11-01T01:06:08.891Z] ['info'] Searching for coverage files...
[2023-11-01T02:44:16.875Z] ['info'] => Found 1 possible coverage files:

... it spent over 90minutes in this step. I'd guess something is misconfigured in this Action.

vbraun pushed a commit to vbraun/sage that referenced this issue Nov 5, 2023
sagemathgh-36621: Build CI: Fix configuration of coverage upload action
411b000 
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
Fixes sagemath#36620
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36621
Reported by: Matthias Köppe
Reviewer(s): Frédéric Chapoton
@mkoeppe mkoeppe added this to the sage-10.2 milestone Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkoeppe mkoeppe

Labels
p: critical / 2 t: bug
Projects
None yet
Milestone
sage-10.2
Development

Successfully merging a pull request may close this issue.

Build CI: Fix configuration of coverage upload action mkoeppe/sage
2 participants
@tobiasdiez @mkoeppe