Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update flint to 2.9 #34102

Closed
mkoeppe opened this issue Jun 30, 2022 · 17 comments · Fixed by #36383
Closed

Update flint to 2.9 #34102

mkoeppe opened this issue Jun 30, 2022 · 17 comments · Fixed by #36383
Labels
c: packages: standard p: major / 3 t: enhancement
Milestone
sage-10.2

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 30, 2022

Depends on #34017

Upstream: Reported upstream. No feedback yet.

CC: @dimpase @fredrik-johansson @orlitzky

Component: packages: standard

Author: Matthias Koeppe

Branch/Commit: u/mkoeppe/update_flint_to_2_9__arb_to_2_23 @ 965c31c

Reviewer: https://github.com/mkoeppe/sage/actions/runs/2593290132

Issue created by migration from https://trac.sagemath.org/ticket/34102
@mkoeppe mkoeppe added this to the sage-9.7 milestone Jun 30, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 30, 2022

Branch: u/mkoeppe/update_flint_to_2_9__arb_to_2_23

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 30, 2022

Commit: af64c7c

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 30, 2022

Reviewer: https://github.com/mkoeppe/sage/actions/runs/2593290132

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 30, 2022

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 30, 2022

comment:2

Installs ok on macOS (Intel)

New commits:

a2df747build/pkgs/flint: Update to 2.9.0
c16b5a9build/pkgs/arb: Update to 2.23.0
af64c7cbuild/pkgs/flint/patches/0001-flint.h-On-GCC-4.9-do-not-use-_Thread_local.patch: Remove (upstreamed)

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 1, 2022

comment:3

On fedora-35-standard (https://github.com/mkoeppe/sage/runs/7141170218?check_suite_focus=true - with system flint 2.8.4)

gcc -fPIC -g -O2 -I/sage/local/var/tmp/sage/build/arb-2.23.0/src -I/sage/local/include -I/sage/local/include -I/sage/local/include -c sin_cos_arf_bb.c -o ../build/arb/sin_cos_arf_bb.lo -MMD -MP -MF "../build/arb/sin_cos_arf_bb.d" -MT "../build/arb/sin_cos_arf_bb.d" -MT "../build/arb/sin_cos_arf_bb.lo"
sin_cos_arf_bb.c: In function 'bsplit2':
sin_cos_arf_bb.c:176:5: warning: implicit declaration of function 'flint_parallel_binary_splitting' [-Wimplicit-function-declaration]
  176 |     flint_parallel_binary_splitting(s,
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
sin_cos_arf_bb.c:177:10: error: 'bsplit_basecase_func_t' undeclared (first use in this function)
  177 |         (bsplit_basecase_func_t) cos_bsplit_basecase,
      |          ^~~~~~~~~~~~~~~~~~~~~~

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 1, 2022

comment:4

@fredrik-johansson - is it intended that arb requires flint 2.9?
https://arblib.org/setup.html#dependencies says that flint 2.5 is enough

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 1, 2022

comment:6

Now I see flintlib/arb#431 (comment), so apparently we need flint 2.9 for the arb upgrade. I'll split it out to a separate ticket, #34106

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 1, 2022

Changed commit from af64c7c to a74273a

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 1, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

a74273abuild/pkgs/flint/patches/0001-flint.h-On-GCC-4.9-do-not-use-_Thread_local.patch: Remove (upstreamed)

@mkoeppe mkoeppe changed the title Update flint to 2.9, arb to 2.23 Update flint to 2.9 Jul 1, 2022
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 1, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

58d62f4build/bin/write-dockerfile.sh: ADD src/VERSION.txt
965c31cMerge #34017

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 1, 2022

Changed commit from a74273a to 965c31c

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 1, 2022

Dependencies: #34017

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 3, 2022

comment:13

Several issues - flintlib/flint#1166

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 9, 2022

Upstream: Reported upstream. No feedback yet.

@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 29, 2022
@mkoeppe mkoeppe removed this from the sage-9.8 milestone Dec 31, 2022
@mkoeppe mkoeppe added this to the sage-9.9 milestone Dec 31, 2022
@mkoeppe mkoeppe removed this from the sage-10.0 milestone Mar 16, 2023
vbraun pushed a commit that referenced this issue Oct 8, 2023
gh-36383: Update flint to 2.9.0, arb to 2.23.0
970fd9f 
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes #1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes #12345". -->
Resolves #34102
Resolves #34106
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- #12345: short description why this is a dependency
- #34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: #36383
Reported by: Matthias Köppe
Reviewer(s): Dima Pasechnik
@mkoeppe mkoeppe added this to the sage-10.2 milestone Oct 8, 2023
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 8, 2023

@vbraun The flint tarball appears to be missing on the Sage mirrors - https://github.com/sagemath/sage/actions/runs/6448031564/job/17504893080#step:4:1305

@vbraun
Copy link
Member

vbraun commented Oct 8, 2023

uploaded!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: standard p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-10.2
Development

Successfully merging a pull request may close this issue.

Update flint to 2.9.0, arb to 2.23.0 mkoeppe/sage
2 participants
@vbraun @mkoeppe