-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tox-docker builds after #29941 #34017
Comments
New commits:
|
Commit: |
comment:3
Let's get this in please |
comment:4
how does one test this? (I guess a box |
comment:5
The branch fixes what runs on GH Actions |
comment:6
Running (with some other tickets) for example in https://github.com/mkoeppe/sage/runs/7056478381 |
comment:8
If it fixes the failures mentioned in the ticket in CI, I think that should count as automatically reviewed. The proof is in that pudding. |
Reviewer: François Bissey |
comment:9
I'm interpreting this as a positive review, thanks |
comment:10
Yes, I thought I had ticked that box :) |
Changed branch from u/mkoeppe/fix_tox_docker_builds_after__29941 to |
src/VERSION.txt
is needed in the Docker container after #29941.This fixes the failures seen in https://github.com/sagemath/sage/actions/runs/2483481917
and also reported in pypa/setuptools#3389
CC: @dimpase @kliem @kiwifb
Component: porting
Author: Matthias Koeppe
Branch/Commit:
58d62f4
Reviewer: François Bissey
Issue created by migration from https://trac.sagemath.org/ticket/34017
The text was updated successfully, but these errors were encountered: