Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tox-docker builds after #29941 #34017

Closed
mkoeppe opened this issue Jun 19, 2022 · 12 comments
Closed

Fix tox-docker builds after #29941 #34017

mkoeppe opened this issue Jun 19, 2022 · 12 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 19, 2022

src/VERSION.txt is needed in the Docker container after #29941.

This fixes the failures seen in https://github.com/sagemath/sage/actions/runs/2483481917
and also reported in pypa/setuptools#3389

CC: @dimpase @kliem @kiwifb

Component: porting

Author: Matthias Koeppe

Branch/Commit: 58d62f4

Reviewer: François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/34017

@mkoeppe mkoeppe added this to the sage-9.7 milestone Jun 19, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 19, 2022

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 19, 2022

New commits:

58d62f4build/bin/write-dockerfile.sh: ADD src/VERSION.txt

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 19, 2022

Commit: 58d62f4

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 25, 2022

comment:3

Let's get this in please

@dimpase
Copy link
Member

dimpase commented Jun 25, 2022

comment:4

how does one test this? (I guess a box
with docker is needed)

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 25, 2022

comment:5

The branch fixes what runs on GH Actions

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 25, 2022

comment:6

Running (with some other tickets) for example in https://github.com/mkoeppe/sage/runs/7056478381

@kiwifb
Copy link
Member

kiwifb commented Jun 27, 2022

comment:8

If it fixes the failures mentioned in the ticket in CI, I think that should count as automatically reviewed. The proof is in that pudding.

@kiwifb
Copy link
Member

kiwifb commented Jun 27, 2022

Reviewer: François Bissey

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 27, 2022

comment:9

I'm interpreting this as a positive review, thanks

@kiwifb
Copy link
Member

kiwifb commented Jun 27, 2022

comment:10

Yes, I thought I had ticked that box :)

@vbraun
Copy link
Member

vbraun commented Jul 3, 2022

Changed branch from u/mkoeppe/fix_tox_docker_builds_after__29941 to 58d62f4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants