Fix E2E Tests For ERC-4337 v0.7 Bundler #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlordell
requested review from
akshay-ap,
mmv08 and
remedcu
and removed request for
a team
mmv08
approved these changes
Mar 5, 2024
|
CI is broken though, it looks like the TS files failed to compile. |
Yup - this is a known issue (#270). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #227
This PR updates the E2E tests to work with the latest bundler for the EntryPoint contract v0.7. Note that there was a notable change in that the
PackedUserOperationstruct is only used on-chain, and the bundler RPC uses a differentUserOperationtype that is completely unpacked. This required some additional helper methods as well as some adjustments to tests to distinguish between the packed and unpacked versions of user operations.Also, unfortunately the reference bundler repository is not tagged yet - so we are using a commit hash that corresponds to the latest version. I asked the 4337 team to create a new tag, at which point, I will update the docker file. Additionally, the latest bundler version uses submodules, so some dockerfile tweaking was required.
Note that the broken CI is expected until #270 is fixed.