Update Examples and Gas Metering to be 0.7 Compatible #270
Comments
nlordell
changed the title
nlordell
added a commit
that referenced
this issue
Mar 5, 2024
Fixes #227 This PR updates the E2E tests to work with the latest bundler for the EntryPoint contract v0.7. Note that there was a notable change in that the `PackedUserOperation` struct is only used on-chain, and the bundler RPC uses a different `UserOperation` type that is completely unpacked. This required some additional helper methods as well as some adjustments to tests to distinguish between the packed and unpacked versions of user operations. Also, unfortunately the reference bundler repository is not tagged yet - so we are using a commit hash that corresponds to the latest version. I asked the 4337 team to create a new tag, at which point, I will update the docker file. Additionally, the latest bundler version uses submodules, so some dockerfile tweaking was required. Note that the broken CI is expected until #270 is fixed.
nlordell
added a commit
that referenced
this issue
Mar 5, 2024
Fixes #227 This PR updates the E2E tests to work with the latest bundler for the EntryPoint contract v0.7. Note that there was a notable change in that the `PackedUserOperation` struct is only used on-chain, and the bundler RPC uses a different `UserOperation` type that is completely unpacked. This required some additional helper methods as well as some adjustments to tests to distinguish between the packed and unpacked versions of user operations. Also, unfortunately the reference bundler repository is not tagged yet - so we are using a commit hash that corresponds to the latest version. I asked the 4337 team to create a new tag, at which point, I will update the docker file. Additionally, the latest bundler version uses submodules, so some dockerfile tweaking was required. Note that the broken CI is expected until #270 is fixed.
remedcu
added a commit
that referenced
this issue
Mar 5, 2024
This PR removed the formatting issue in the `4337-gas-metering` CI. CI failure for `safe-modules-examples` remains, and will be solved later with #270
nlordell
added a commit
that referenced
this issue
Mar 5, 2024
Partially addresses #270 This PR modifies the passkey example to compile once again for the 0.7 EntryPoint changes. Note that the contract addresses are also updated, as well as the network the example is for. This is because Polygon Mumbai is not well supported seeing as it is anchored to Goerli which is deprecated. Test transaction using the example application: https://sepolia.etherscan.io/tx/0x267fa1cd04ba44701807c10ea6f7885c45c22c3ff6646fb9ef697884d91fedc8
nlordell
added a commit
that referenced
this issue
Mar 5, 2024
Fixes #227 This PR updates the E2E tests to work with the latest bundler for the EntryPoint contract v0.7. Note that there was a notable change in that the `PackedUserOperation` struct is only used on-chain, and the bundler RPC uses a different `UserOperation` type that is completely unpacked. This required some additional helper methods as well as some adjustments to tests to distinguish between the packed and unpacked versions of user operations. Also, unfortunately the reference bundler repository is not tagged yet - so we are using a commit hash that corresponds to the latest version. I asked the 4337 team to create a new tag, at which point, I will update the docker file. Additionally, the latest bundler version uses submodules, so some dockerfile tweaking was required. Note that the broken CI is expected until #270 is fixed.
nlordell
pushed a commit
that referenced
this issue
Mar 5, 2024
This PR removed the formatting issue in the `4337-gas-metering` CI. CI failure for `safe-modules-examples` remains, and will be solved later with #270
nlordell
added a commit
that referenced
this issue
Mar 5, 2024
Partially addresses #270 This PR modifies the passkey example to compile once again for the 0.7 EntryPoint changes. Note that the contract addresses are also updated, as well as the network the example is for. This is because Polygon Mumbai is not well supported seeing as it is anchored to Goerli which is deprecated. Test transaction using the example application: https://sepolia.etherscan.io/tx/0x267fa1cd04ba44701807c10ea6f7885c45c22c3ff6646fb9ef697884d91fedc8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Examples and 4337 gas metering use EntryPoint v0.6 compatible module, we should update the code to work with the latest EntryPoint.
The text was updated successfully, but these errors were encountered: