Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update end-to-end tests with 0.7.0 entrypoint & corresponding bundler #227

Closed
mmv08 opened this issue Jan 25, 2024 · 3 comments
Closed

Update end-to-end tests with 0.7.0 entrypoint & corresponding bundler #227

mmv08 opened this issue Jan 25, 2024 · 3 comments
Assignees

Comments

@mmv08
Copy link
Member

mmv08 commented Jan 25, 2024

For the upcoming release of 0.7.0 entrypoint compatibility, we want our end-to-end tests to use the 0.7.0 entrypoint and a bundler version supporting it.

Deliverables:

  • Refactoring end-to-end tests to use the entrypoint and bundler 0.7.0

Potential blockers:

  • Bundler image/entrypoint may be unavailable due to undergoing security audit
@mmv08
Copy link
Member Author

mmv08 commented Jan 30, 2024

An update on the ticket: it isn't possible to implement at the moment because the bundler is still under development (confirmed by the 4337 team). Only updating contracts was possible by forking the aa contracts' repo, pushing build artefacts, and installing from the repo. Here is the contracts' PR #215

@nlordell
Copy link
Collaborator

nlordell commented Feb 2, 2024

I removed it from the current iteration.

@mmv08
Copy link
Member Author

mmv08 commented Feb 15, 2024

This is blocked by the release of the production bundler & entrypoint version, isn't it? We added an e2e job that uses the upstream version of the bundler and the entrypoint and we should keep an eye on it. I am not sure if it makes sense to include it in the current iteration

@nlordell nlordell self-assigned this Mar 1, 2024
nlordell added a commit that referenced this issue Mar 5, 2024
Fixes #227 

This PR updates the E2E tests to work with the latest bundler for the
EntryPoint contract v0.7. Note that there was a notable change in that
the `PackedUserOperation` struct is only used on-chain, and the bundler
RPC uses a different `UserOperation` type that is completely unpacked.
This required some additional helper methods as well as some adjustments
to tests to distinguish between the packed and unpacked versions of user
operations.

Also, unfortunately the reference bundler repository is not tagged yet -
so we are using a commit hash that corresponds to the latest version. I
asked the 4337 team to create a new tag, at which point, I will update
the docker file. Additionally, the latest bundler version uses
submodules, so some dockerfile tweaking was required.

Note that the broken CI is expected until #270 is fixed.
nlordell added a commit that referenced this issue Mar 5, 2024
Fixes #227 

This PR updates the E2E tests to work with the latest bundler for the
EntryPoint contract v0.7. Note that there was a notable change in that
the `PackedUserOperation` struct is only used on-chain, and the bundler
RPC uses a different `UserOperation` type that is completely unpacked.
This required some additional helper methods as well as some adjustments
to tests to distinguish between the packed and unpacked versions of user
operations.

Also, unfortunately the reference bundler repository is not tagged yet -
so we are using a commit hash that corresponds to the latest version. I
asked the 4337 team to create a new tag, at which point, I will update
the docker file. Additionally, the latest bundler version uses
submodules, so some dockerfile tweaking was required.

Note that the broken CI is expected until #270 is fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants