-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add paragraph to ControlFlow docs to menion it works with the ? operator (#88715) #89446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Oct 1, 2021
wooster0
reviewed
Oct 2, 2021
Co-authored-by: r00ster <[email protected]>
steveklabnik
approved these changes
Oct 13, 2021
Thank you! @bos: r+ rollup |
apiraino
added
the
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
label
Oct 14, 2021
@bors r+ |
📌 Commit 825cd81 has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Oct 30, 2021
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 31, 2021
…riplett Add paragraph to ControlFlow docs to menion it works with the ? operator (rust-lang#88715) fixes rust-lang#88715 r? `@steveklabnik`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 31, 2021
…riplett Add paragraph to ControlFlow docs to menion it works with the ? operator (rust-lang#88715) fixes rust-lang#88715 r? ``@steveklabnik``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 31, 2021
…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#89446 (Add paragraph to ControlFlow docs to menion it works with the ? operator (rust-lang#88715)) - rust-lang#89677 (Stabilize `is_symlink()` for `Metadata` and `Path`) - rust-lang#89833 (Add #[must_use] to Rc::downgrade) - rust-lang#89835 (Add #[must_use] to expensive computations) - rust-lang#89839 (Add #[must_use] to mem/ptr functions) - rust-lang#89897 (Add #[must_use] to remaining core functions) - rust-lang#89951 (Stabilize `option_result_unwrap_unchecked`) - rust-lang#90427 (Add #[must_use] to alloc functions that would leak memory) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #88715
r? @steveklabnik