Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ControlFlow docs should explicitly mention that it works with ? #88715

Closed
matklad opened this issue Sep 7, 2021 · 1 comment · Fixed by #89446
Closed

ControlFlow docs should explicitly mention that it works with ? #88715

matklad opened this issue Sep 7, 2021 · 1 comment · Fixed by #89446
Assignees
@chrismit3s
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools

Comments

@matklad
Copy link
Member

matklad commented Sep 7, 2021 •
edited by rustbot
Loading

We stabilized ControlFlow: https://doc.rust-lang.org/stable/std/ops/enum.ControlFlow.html

That’s somewhat of a big deal, as it is now the third type (in addition to Option and Result), which works with ? operator on stable. This isn’t immediately obvious from the docs though!
@matklad matklad added the A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools label Sep 7, 2021
@chrismit3s
Copy link
Contributor

Will do!

@rustbot claim

chrismit3s added a commit to chrismit3s/rust that referenced this issue Oct 1, 2021
@chrismit3s
Add paragraph to ControlFlow docs to menion it works with the ? opera…
081fe30 
…tor (rust-lang#88715)
@chrismit3s chrismit3s mentioned this issue Oct 1, 2021
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Oct 31, 2021
@matthiaskrgr
Rollup merge of rust-lang#89446 - chrismit3s:issue-88715-fix, r=josht…
2ce7c36 
…riplett

Add paragraph to ControlFlow docs to menion it works with the ? operator (rust-lang#88715)

fixes rust-lang#88715

r? `@steveklabnik`
@matthiaskrgr matthiaskrgr mentioned this issue Oct 31, 2021
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Oct 31, 2021
@matthiaskrgr
Rollup merge of rust-lang#89446 - chrismit3s:issue-88715-fix, r=josht…
de0ec90 
…riplett

Add paragraph to ControlFlow docs to menion it works with the ? operator (rust-lang#88715)

fixes rust-lang#88715

r? ``@steveklabnik``
@matthiaskrgr matthiaskrgr mentioned this issue Oct 31, 2021
Closed
@matthiaskrgr matthiaskrgr mentioned this issue Oct 31, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Oct 31, 2021
@bors
Auto merge of rust-lang#90434 - matthiaskrgr:rollup-xbn393a, r=matthi…
58899c4 
…askrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#89446 (Add paragraph to ControlFlow docs to menion it works with the ? operator (rust-lang#88715))
 - rust-lang#89677 (Stabilize `is_symlink()` for `Metadata` and `Path`)
 - rust-lang#89833 (Add #[must_use] to Rc::downgrade)
 - rust-lang#89835 (Add #[must_use] to expensive computations)
 - rust-lang#89839 (Add #[must_use] to mem/ptr functions)
 - rust-lang#89897 (Add #[must_use] to remaining core functions)
 - rust-lang#89951 (Stabilize `option_result_unwrap_unchecked`)
 - rust-lang#90427 (Add #[must_use] to alloc functions that would leak memory)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors closed this as completed in e7be8a2 Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrismit3s chrismit3s

Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add paragraph to ControlFlow docs to menion it works with the ? operator (#88715) chrismit3s/rust
2 participants
@matklad @chrismit3s