Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #87116

Closed
wants to merge 15 commits into from
Closed

Commits on Jul 12, 2021

  1. Configuration menu
    Copy the full SHA
    10b65c8 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2021

  1. Configuration menu
    Copy the full SHA
    28a50b3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b09084c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f0169e9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    168b4d4 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b8264a8 View commit details
    Browse the repository at this point in the history
  6. Upgrade cc crate to 1.0.69

    JohnTitor committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    e457c27 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    da56618 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    cac0d71 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#87082 - michaelwoerister:const-in-debuginfo…

    …-type-names-fix, r=oli-obk,wesleywiser
    
    Handle non-integer const generic parameters in debuginfo type names.
    
    This PR fixes an ICE introduced by rust-lang#85269 which started emitting const generic arguments for debuginfo names but did not cover the case where such an argument could not be evaluated to a flat string of bits.
    
    The fix implemented in this PR is very basic: If `try_eval_bits()` fails for the constant in question, we fall back to generating a stable hash of the constant and emit that instead. This way we get a (virtually) unique name and side step the problem of generating a string representation of a potentially complex value.
    
    The downside is that the generated name will be rather opaque. E.g. the regression test adds a function `const_generic_fn_non_int<()>` which is then rendered as `const_generic_fn_non_int<{CONST#fe3cfa0214ac55c7}>`. I think it's an open question how to deal with this more gracefully.
    
    I'd be interested in ideas on how to do this better.
    
    r? ```@wesleywiser```
    
    cc ```@dpaoliello``` (do you see any problems with this approach?)
    cc ```@Mark-Simulacrum``` & ```@nagisa``` (who I've seen comment on debuginfo issues recently -- anyone else?)
    
    Fixes rust-lang#86893
    JohnTitor authored Jul 13, 2021
    Configuration menu
    Copy the full SHA
    a727bc5 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#87085 - GuillaumeGomez:search-result-colors…

    …, r=notriddle
    
    Search result colors
    
    Part of  rust-lang#87072 (fixes the first and fourth regressions and add tests to prevent it from happening again).
    
    cc ```@Nemo157```
    
    r? ```@camelid```
    JohnTitor authored Jul 13, 2021
    Configuration menu
    Copy the full SHA
    baf23b8 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#87090 - ssomers:btree_comments, r=the8472

    Make BTreeSet::split_off name elements like other set methods do
    
    r? ```@Mark-Simulacrum```
    JohnTitor authored Jul 13, 2021
    Configuration menu
    Copy the full SHA
    ef70865 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#87098 - JohnTitor:unignore-some-tests, r=pe…

    …trochenkov
    
    Unignore some pretty printing tests
    
    Closes rust-lang#37201
    r? ```@petrochenkov```
    JohnTitor authored Jul 13, 2021
    Configuration menu
    Copy the full SHA
    7875fa8 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#87099 - JohnTitor:upgrade-cc-crate, r=alexc…

    …richton
    
    Upgrade `cc` crate to 1.0.69
    
    This pulls another fix for rust-lang#83043, i.e., rust-lang/cc-rs#605.
    r? `@alexcrichton`
    JohnTitor authored Jul 13, 2021
    Configuration menu
    Copy the full SHA
    1cc2088 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#87102 - GuillaumeGomez:go-to-first-feature,…

    … r=Manisheart,notriddle
    
    Add GUI test for "go to first" feature
    
    It adds a test for rust-lang#85876 to ensure the feature is working as expected and prevent potential regression.
    
    cc ``@jeanlucthumm``
    
    r? ``@Manishearth``
    JohnTitor authored Jul 13, 2021
    Configuration menu
    Copy the full SHA
    a446505 View commit details
    Browse the repository at this point in the history