-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GUI test for "go to first" feature #87102
Conversation
7fd88e3
to
5f143d9
Compare
|
||
// First, we check that the first page doesn't have the string we're looking for to ensure | ||
// that the feature is changing page as expected. | ||
goto: file://|DOC_PATH|/test_docs/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we also go to a search page without go_to_first?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is search-result-description.goml
which does that already. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pop in a comment saying that and r=me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually the test will be more complete if we add that as an intermediate check.
c514be3
to
87e648a
Compare
@bors r+ rollup=maybe |
📌 Commit 87e648a927c1d5aa224bad075cedc195e984328c has been approved by |
87e648a
to
cac0d71
Compare
@bors: r=Manisheart,notriddle |
📌 Commit cac0d71 has been approved by |
… r=Manisheart,notriddle Add GUI test for "go to first" feature It adds a test for rust-lang#85876 to ensure the feature is working as expected and prevent potential regression. cc `@jeanlucthumm` r? `@Manishearth`
… r=Manisheart,notriddle Add GUI test for "go to first" feature It adds a test for rust-lang#85876 to ensure the feature is working as expected and prevent potential regression. cc ``@jeanlucthumm`` r? ``@Manishearth``
Rollup of 6 pull requests Successful merges: - rust-lang#87085 (Search result colors) - rust-lang#87090 (Make BTreeSet::split_off name elements like other set methods do) - rust-lang#87098 (Unignore some pretty printing tests) - rust-lang#87099 (Upgrade `cc` crate to 1.0.69) - rust-lang#87101 (Suggest a path separator if a stray colon is found in a match arm) - rust-lang#87102 (Add GUI test for "go to first" feature) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
It adds a test for #85876 to ensure the feature is working as expected and prevent potential regression.
cc @jeanlucthumm
r? @Manishearth