Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GUI test for "go to first" feature #87102

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

GuillaumeGomez
Copy link
Member

It adds a test for #85876 to ensure the feature is working as expected and prevent potential regression.

cc @jeanlucthumm

r? @Manishearth

@GuillaumeGomez GuillaumeGomez added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jul 13, 2021
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 13, 2021
@GuillaumeGomez GuillaumeGomez changed the title Add test for "go to first" feature Add GUI test for "go to first" feature Jul 13, 2021

// First, we check that the first page doesn't have the string we're looking for to ensure
// that the feature is changing page as expected.
goto: file://|DOC_PATH|/test_docs/index.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also go to a search page without go_to_first?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is search-result-description.goml which does that already. :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pop in a comment saying that and r=me

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the test will be more complete if we add that as an intermediate check.

@GuillaumeGomez GuillaumeGomez force-pushed the go-to-first-feature branch 2 times, most recently from c514be3 to 87e648a Compare July 13, 2021 16:02
@Manishearth
Copy link
Member

@bors r+ rollup=maybe

@bors
Copy link
Contributor

bors commented Jul 13, 2021

📌 Commit 87e648a927c1d5aa224bad075cedc195e984328c has been approved by Manishearth

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 13, 2021
@GuillaumeGomez
Copy link
Member Author

@bors: r=Manisheart,notriddle

@bors
Copy link
Contributor

bors commented Jul 13, 2021

📌 Commit cac0d71 has been approved by Manisheart,notriddle

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 13, 2021
… r=Manisheart,notriddle

Add GUI test for "go to first" feature

It adds a test for rust-lang#85876 to ensure the feature is working as expected and prevent potential regression.

cc `@jeanlucthumm`

r? `@Manishearth`
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jul 13, 2021
… r=Manisheart,notriddle

Add GUI test for "go to first" feature

It adds a test for rust-lang#85876 to ensure the feature is working as expected and prevent potential regression.

cc ``@jeanlucthumm``

r? ``@Manishearth``
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 14, 2021
Rollup of 6 pull requests

Successful merges:

 - rust-lang#87085 (Search result colors)
 - rust-lang#87090 (Make BTreeSet::split_off name elements like other set methods do)
 - rust-lang#87098 (Unignore some pretty printing tests)
 - rust-lang#87099 (Upgrade `cc` crate to 1.0.69)
 - rust-lang#87101 (Suggest a path separator if a stray colon is found in a match arm)
 - rust-lang#87102 (Add GUI test for "go to first" feature)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit afaca5b into rust-lang:master Jul 14, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jul 14, 2021
@GuillaumeGomez GuillaumeGomez deleted the go-to-first-feature branch July 14, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants