Probe for ARM64 MSBuild #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set MSBuild Platform property to ARM64 for aarch64 targets
Alovchin91
commented
May 31, 2021
|
This all seems reasonable to me, thanks! |
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jul 13, 2021
…richton Upgrade `cc` crate to 1.0.69 This pulls another fix for rust-lang#83043, i.e., rust-lang/cc-rs#605. r? `@alexcrichton`
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jul 14, 2021
…richton Upgrade `cc` crate to 1.0.69 This pulls another fix for rust-lang#83043, i.e., rust-lang/cc-rs#605. r? ``@alexcrichton``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found an interesting corner case. I've been installing a x86/x64 MSVC toolchain alongside an ARM64 toolchain, and I never had any problem detecting Visual Studio version. But when I uninstalled the x86/x64 MSVC toolchain, suddenly my test app stopped detecting Visual Studio.
I realized that cc-rs probes for MSBuild using different triples. This list of triples does include both i686 and x86_64, but it doesn't include aarch64. So I've added it to the list.
Additionally, I also now set MSBuild Platform property to ARM64 for aarch64 targets. I'm not 100% sure what does it affect, but looking at x86_64 I thought it might be a good idea.