Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid a hir access inside get_static #81664

Merged
merged 2 commits into from
Feb 6, 2021
Merged

Avoid a hir access inside get_static #81664

merged 2 commits into from
Feb 6, 2021

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Feb 2, 2021

Together with #81056 this ensures that the codegen unit DepNode doesn't have a direct dependency on any part of the hir.

@bjorn3 bjorn3 added C-cleanup Category: PRs that clean code up or issues documenting cleanup. A-codegen Area: Code generation T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 2, 2021
@rust-highfive
Copy link
Collaborator

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 2, 2021
lcnr
lcnr approved these changes Feb 3, 2021
View reviewed changes
Copy link
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small style recommendations

feel free to implement the ones to you agree with, afterwards r=me

compiler/rustc_codegen_llvm/src/consts.rs Outdated Show resolved Hide resolved
compiler/rustc_codegen_llvm/src/consts.rs Outdated Show resolved Hide resolved
@lcnr
Copy link
Contributor

lcnr commented Feb 3, 2021

@bors delegate+

@bors
Copy link
Contributor

bors commented Feb 3, 2021

✌️ @bjorn3 can now approve this pull request

@lcnr
Copy link
Contributor

lcnr commented Feb 4, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Feb 4, 2021

📌 Commit da53655 has been approved by lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 4, 2021
@m-ou-se m-ou-se mentioned this pull request Feb 5, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 6, 2021
@bors
Auto merge of rust-lang#81810 - m-ou-se:rollup-q3nborp, r=m-ou-se
cfba499 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#80011 (Stabilize `peekable_next_if`)
 - rust-lang#81580 (Document how `MaybeUninit<Struct>` can be initialized.)
 - rust-lang#81610 (BTreeMap: make Ord bound explicit, compile-test its absence)
 - rust-lang#81664 (Avoid a hir access inside get_static)
 - rust-lang#81675 (Make rustdoc respect `--error-format short` in doctests)
 - rust-lang#81753 (Never MIR inline functions with a different instruction set)
 - rust-lang#81795 (Small refactor with Iterator::reduce)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit add80c9 into rust-lang:master Feb 6, 2021
@rustbot rustbot added this to the 1.51.0 milestone Feb 6, 2021
@bjorn3 bjorn3 deleted the no_codegen_hir branch February 6, 2021 08:39
@bjorn3 bjorn3 mentioned this pull request Dec 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcnr lcnr lcnr approved these changes

Assignees

@lcnr lcnr

Labels
A-codegen Area: Code generation C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.51.0
Development

Successfully merging this pull request may close these issues.
5 participants
@bjorn3 @rust-highfive @lcnr @bors @rustbot