Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query-ify needs_gdb_debug_scripts_section #81056

Closed
wants to merge 1 commit into from

Conversation

Aaron1011
Copy link
Member

This ensures that a codegen unit DepNode does not have a direct
dependency on the crate's attributes

@rust-highfive
Copy link
Collaborator

r? @ecstatic-morse

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 15, 2021
@Aaron1011
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@bors
Copy link
Contributor

bors commented Jan 15, 2021

⌛ Trying commit ecde548133cec4a4a8ca0b1c9ff382abc44cfcd5 with merge a3c8e320ca13e4cc1253c85b7cfbaf98a455560f...

@bors
Copy link
Contributor

bors commented Jan 15, 2021

☀️ Try build successful - checks-actions
Build commit: a3c8e320ca13e4cc1253c85b7cfbaf98a455560f (a3c8e320ca13e4cc1253c85b7cfbaf98a455560f)

@rust-timer
Copy link
Collaborator

Queued a3c8e320ca13e4cc1253c85b7cfbaf98a455560f with parent bc39d4d, future comparison URL.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 15, 2021
@jyn514 jyn514 added A-codegen Area: Code generation A-incr-comp Area: Incremental compilation I-compiletime Issue: Problems and improvements with respect to compile times. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-waiting-on-perf Status: Waiting on a perf run to be completed. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jan 15, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (a3c8e320ca13e4cc1253c85b7cfbaf98a455560f): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 16, 2021
@Aaron1011
Copy link
Member Author

r? @estebank

@bors
Copy link
Contributor

bors commented Feb 2, 2021

☔ The latest upstream changes (presumably #81660) made this pull request unmergeable. Please resolve the merge conflicts.

This ensures that a codegen unit DepNode does not have a direct
dependency on the crate's attributes
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Feb 5, 2021
Avoid a hir access inside get_static

Together with rust-lang#81056 this ensures that the codegen unit DepNode doesn't have a direct dependency on any part of the hir.
@jonas-schievink jonas-schievink added the relnotes-perf Performance improvements that should be mentioned in the release notes. label Feb 9, 2021
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 28, 2021
@Aaron1011
Copy link
Member Author

@estebank Are there any changes that you'd like me to make?

@Aaron1011
Copy link
Member Author

PR #79519 may have reduced the need for this:

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 16, 2021
@bors
Copy link
Contributor

bors commented Mar 16, 2021

⌛ Trying commit 3667b1d with merge c071c3594f1d95ba283af8252d803e1b74690fe0...

@bors
Copy link
Contributor

bors commented Mar 16, 2021

☀️ Try build successful - checks-actions
Build commit: c071c3594f1d95ba283af8252d803e1b74690fe0 (c071c3594f1d95ba283af8252d803e1b74690fe0)

@rust-timer
Copy link
Collaborator

Queued c071c3594f1d95ba283af8252d803e1b74690fe0 with parent f24ce9b, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (c071c3594f1d95ba283af8252d803e1b74690fe0): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 16, 2021
@estebank
Copy link
Contributor

The performance improvements seem to have gone away.

r=me, if you still want to land it

@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 4, 2021
@Dylan-DPC-zz
Copy link

@Aaron1011 any updates?

@Aaron1011
Copy link
Member Author

Without any net performance improvement, landing this would probably just be unnecessary churn.

@Aaron1011 Aaron1011 closed this Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-codegen Area: Code generation A-incr-comp Area: Incremental compilation I-compiletime Issue: Problems and improvements with respect to compile times. relnotes-perf Performance improvements that should be mentioned in the release notes. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.