BTreeMap: make Ord bound explicit, compile-test its absence #81610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
ssomers
changed the title
ssomers
changed the title
ssomers
changed the title
ssomers
force-pushed
the
btree_emphasize_ord_bound
branch
from
8d00be9
to
1ade705
Compare
|
I realized there is no reason to touch entry.rs because all its members are equal (have the |
ssomers
force-pushed
the
btree_emphasize_ord_bound
branch
from
1ade705
to
1020784
Compare
|
@bors r+ rollup |
|
📌 Commit 1020784 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 6, 2021
Rollup of 7 pull requests Successful merges: - rust-lang#80011 (Stabilize `peekable_next_if`) - rust-lang#81580 (Document how `MaybeUninit<Struct>` can be initialized.) - rust-lang#81610 (BTreeMap: make Ord bound explicit, compile-test its absence) - rust-lang#81664 (Avoid a hir access inside get_static) - rust-lang#81675 (Make rustdoc respect `--error-format short` in doctests) - rust-lang#81753 (Never MIR inline functions with a different instruction set) - rust-lang#81795 (Small refactor with Iterator::reduce) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most
BTreeMapandBTreeSetmembers are subject to anOrdbound but a fair number of methods are not. To better convey and perhaps later tune theOrdbound, make it stand out in individualwhereclauses, instead of once far away at the beginning of animplblock. This PR does not introduce or remove any bounds.Also adds compilation test cases checking that the bound doesn't creep in unintended on the historically unbounded methods.