resolve/hygiene: macro_rules are not "legacy"
#69989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This seems like a good idea, much clearer! |
eddyb
approved these changes
Mar 14, 2020
|
@bors r=eddyb,matthewjasper |
|
📌 Commit 7a1ecace75e29b8145ce8642b7b70e87728b74f3 has been approved by |
bors
added
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #70024) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
`modern_and_legacy` -> `normalize_to_macro_rules`
|
@bors r=eddyb,matthewjasper |
|
📌 Commit db638bd has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Mar 16, 2020
Rollup of 7 pull requests Successful merges: - #67335 (Refactor the `Qualif` trait) - #69122 (Backtrace Debug tweaks) - #69520 (Make error message clearer about creating new module) - #69738 (More Method -> AssocFn renaming) - #69867 (Add long error explanation for E0628 ) - #69989 (resolve/hygiene: `macro_rules` are not "legacy") - #70036 (Make article_and_description primarily use def_kind) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "modern" vs "legacy" naming was introduced by jseyfried during initial implementation of macros 2.0.
At this point it's clear that
macro_rulesare not going anywhere and won't be deprecated in the near future.So this PR changes the naming "legacy" (when it implies "macro_rules") to "macro_rules".
This should also help people reading this code because it's wasn't obvious that "legacy" actually meant "macro_rules" in these contexts.
The most contentious renaming here is probably
Other alternatives that I could think of are
normalize_to_opaque/normalize_to_semitransparent, orstrip_non_opaque/strip_transparent, but they seemed less intuitive.The documentation to these functions can be found in
symbol.rs.r? @matthewjasper