Backtrace Debug tweaks #69122

dtolnay · 2020-02-13T08:24:30Z

Change Debug representation of disabled and unsupported backtraces to use <placeholder> style, same as what we do for debug printing locked mutexes and mutably borrowed refcells;
```
- Error { msg: "...", backtrace: disabled backtrace }
+ Error { msg: "...", backtrace: <disabled> }
```

Remove quotes around unresolved symbol names;

- Backtrace [{ fn: "<unknown>" }]
+ Backtrace [{ fn: <unknown> }]

Add quotes around file paths;

- Backtrace [{ fn: "krate::main", file: /path/to/main.rs, line: 10 }]
+ Backtrace [{ fn: "krate::main", file: "/path/to/main.rs", line: 10 }]

Add test.

rust-highfive · 2020-02-13T08:24:39Z

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

cramertj · 2020-02-13T23:03:16Z

This looks like a good improvement to me, thanks!

@bors r+

bors · 2020-02-13T23:03:17Z

📌 Commit 3e4992bd0bdce396b31dbc74adb6bb189e60dc72 has been approved by cramertj

bors · 2020-02-14T04:50:14Z

⌛ Testing commit 3e4992bd0bdce396b31dbc74adb6bb189e60dc72 with merge 805bc0a427640f64b9690d2c1c697338e907c6f2...

rust-highfive · 2020-02-14T07:42:32Z

The job armhf-gnu of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-02-14T07:41:31.2466964Z failures:
2020-02-14T07:41:31.2467188Z 
2020-02-14T07:41:31.2468151Z ---- backtrace::test_debug stdout ----
2020-02-14T07:41:31.2468852Z thread '<unnamed>' panicked at 'assertion failed: `(left == right)`
2020-02-14T07:41:31.2469315Z   left: `"Backtrace [\n    { fn: \"__rust_maybe_catch_panic\" },\n    { fn: \"std::rt::lang_start_internal\", file: \"./rust/rt.rs\", line: 300 },\n    { fn: \"std::rt::lang_start\", file: \"./rust/rt.rs\", line: 400 },\n]"`,
2020-02-14T07:41:31.2470232Z  right: `"Backtrace [\n    { fn: \"__rust_maybe_catch_panic\" },\n    { fn: \"std::rt::lang_start_internal\", file: \"/rust/rt.rs\", line: 300 },\n    { fn: \"std::rt::lang_start\", file: \"/rust/rt.rs\", line: 400 },\n]"`', src/libstd/backtrace.rs:486:5
2020-02-14T07:41:31.2470946Z 
2020-02-14T07:41:31.2471179Z 
2020-02-14T07:41:31.2471807Z failures:
2020-02-14T07:41:31.2472061Z     backtrace::test_debug
---
2020-02-14T07:41:31.2596857Z 
2020-02-14T07:41:31.2596898Z 
2020-02-14T07:41:31.2597554Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --target arm-unknown-linux-gnueabihf
2020-02-14T07:41:31.2597823Z Build completed unsuccessfully in 2:45:22
2020-02-14T07:41:31.2598461Z error: test failed, to rerun pass '-p std --lib'
2020-02-14T07:41:31.2659241Z   local time: Fri Feb 14 07:41:31 UTC 2020
2020-02-14T07:41:31.5540902Z   network time: Fri, 14 Feb 2020 07:41:31 GMT
2020-02-14T07:41:31.5545990Z == end clock drift check ==
2020-02-14T07:41:32.0895147Z 
2020-02-14T07:41:32.0895147Z 
2020-02-14T07:41:32.0990657Z ##[error]Bash exited with code '1'.
2020-02-14T07:41:32.1038944Z ##[section]Starting: Checkout rust-lang/rust@auto to s
2020-02-14T07:41:32.1041106Z ==============================================================================
2020-02-14T07:41:32.1041222Z Task         : Get sources
2020-02-14T07:41:32.1041306Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2020-02-14T07:42:46Z

💔 Test failed - checks-azure

joelpalmer · 2020-03-09T10:57:58Z

Triaged

… style

For some reason the absolute paths were formatted differently on the armhf-gnu target. thread '<unnamed>' panicked at 'assertion failed: `(left == right)` left: `"Backtrace [\n { fn: \"__rust_maybe_catch_panic\" },\n { fn: \"std::rt::lang_start_internal\", file: \"./rust/rt.rs\", line: 300 },\n { fn: \"std::rt::lang_start\", file: \"./rust/rt.rs\", line: 400 },\n]"`, right: `"Backtrace [\n { fn: \"__rust_maybe_catch_panic\" },\n { fn: \"std::rt::lang_start_internal\", file: \"/rust/rt.rs\", line: 300 },\n { fn: \"std::rt::lang_start\", file: \"/rust/rt.rs\", line: 400 },\n]"`', src/libstd/backtrace.rs:486:5

dtolnay · 2020-03-09T19:25:12Z

Rebase
Fix armhf-gnu build

@bors r=cramertj

bors · 2020-03-09T19:25:14Z

📌 Commit a2364dc has been approved by cramertj

bors · 2020-03-09T19:25:15Z

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

Backtrace Debug tweaks - Change Debug representation of disabled and unsupported backtraces to use \<placeholder\> style, same as what we do for debug printing locked mutexes and mutably borrowed refcells; ```diff - Error { msg: "...", backtrace: disabled backtrace } + Error { msg: "...", backtrace: <disabled> } ``` - Remove quotes around unresolved symbol names; ```diff - Backtrace [{ fn: "<unknown>" }] + Backtrace [{ fn: <unknown> }] ``` - Add quotes around file paths; ```diff - Backtrace [{ fn: "krate::main", file: /path/to/main.rs, line: 10 }] + Backtrace [{ fn: "krate::main", file: "/path/to/main.rs", line: 10 }] ``` - Add test.

@ghost

Rollup of 6 pull requests Successful merges: - #69122 (Backtrace Debug tweaks) - #69591 (Use TypeRelating for instantiating query responses) - #69760 (Improve expression & attribute parsing) - #69837 (Use smaller discriminants for generators) - #69838 (Expansion-driven outline module parsing) - #69859 (fix #62456) Failed merges: r? @ghost

Backtrace Debug tweaks - Change Debug representation of disabled and unsupported backtraces to use \<placeholder\> style, same as what we do for debug printing locked mutexes and mutably borrowed refcells; ```diff - Error { msg: "...", backtrace: disabled backtrace } + Error { msg: "...", backtrace: <disabled> } ``` - Remove quotes around unresolved symbol names; ```diff - Backtrace [{ fn: "<unknown>" }] + Backtrace [{ fn: <unknown> }] ``` - Add quotes around file paths; ```diff - Backtrace [{ fn: "krate::main", file: /path/to/main.rs, line: 10 }] + Backtrace [{ fn: "krate::main", file: "/path/to/main.rs", line: 10 }] ``` - Add test.

@ghost

Rollup of 7 pull requests Successful merges: - #67335 (Refactor the `Qualif` trait) - #69122 (Backtrace Debug tweaks) - #69520 (Make error message clearer about creating new module) - #69738 (More Method -> AssocFn renaming) - #69867 (Add long error explanation for E0628 ) - #69989 (resolve/hygiene: `macro_rules` are not "legacy") - #70036 (Make article_and_description primarily use def_kind) Failed merges: r? @ghost

rust-highfive assigned cramertj Feb 13, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 13, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 13, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 14, 2020

JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 16, 2020

dtolnay added 6 commits March 9, 2020 12:01

Remove quotes around unknown fn placeholder in backtrace

3ba89e8

Add quotes around filename in Backtrace debug

db75b6a

Change disabled and unsupported backtraces to print using placeholder…

1f1ca87

… style

Make it possible to instantiate hardcoded Backtrace from test

a9cc010

Add test of Debug representation of Backtrace

33600e4

dtolnay force-pushed the backtrace branch from 3e4992b to a2364dc Compare March 9, 2020 19:24

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 9, 2020

Centril mentioned this pull request Mar 10, 2020

Rollup of 6 pull requests #69884

Closed

Dylan-DPC-zz mentioned this pull request Mar 14, 2020

Rollup of 7 pull requests #69990

Closed

JohnTitor mentioned this pull request Mar 14, 2020

Rollup of 8 pull requests #69996

Closed

Dylan-DPC-zz mentioned this pull request Mar 16, 2020

Rollup of 7 pull requests #70040

Merged

bors merged commit 2443eb4 into rust-lang:master Mar 16, 2020

dtolnay deleted the backtrace branch May 23, 2020 21:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backtrace Debug tweaks #69122

Backtrace Debug tweaks #69122

dtolnay commented Feb 13, 2020 •

edited

Loading

rust-highfive commented Feb 13, 2020

cramertj commented Feb 13, 2020

bors commented Feb 13, 2020

bors commented Feb 14, 2020

rust-highfive commented Feb 14, 2020

bors commented Feb 14, 2020

joelpalmer commented Mar 9, 2020

dtolnay commented Mar 9, 2020

bors commented Mar 9, 2020

bors commented Mar 9, 2020

Backtrace Debug tweaks #69122

Backtrace Debug tweaks #69122

Conversation

dtolnay commented Feb 13, 2020 • edited Loading

rust-highfive commented Feb 13, 2020

cramertj commented Feb 13, 2020

bors commented Feb 13, 2020

bors commented Feb 14, 2020

rust-highfive commented Feb 14, 2020

bors commented Feb 14, 2020

joelpalmer commented Mar 9, 2020

dtolnay commented Mar 9, 2020

bors commented Mar 9, 2020

bors commented Mar 9, 2020

dtolnay commented Feb 13, 2020 •

edited

Loading