Refactor the `Qualif` trait #67335

ecstatic-morse · 2019-12-15T20:19:50Z

This PR attempts to preserve the existing semantics of the Qualif trait while reducing its API to two significant methods with descriptive names, in_any_value_of_ty and in_adt_inherently. The other in_* methods have been made into free functions, since they should never be overloaded. Finally, I changed the bounds on the in_local argument to be less restrictive (FnMut instead of Fn), which addresses a FIXME in the const-checker.

r? @eddyb
cc @pnkfelix @oli-obk

ecstatic-morse · 2019-12-15T20:45:55Z

For background, in_any_value_of_ty and in_adt_inherently basically encode the following enum.

enum Qualified {
    Never,
    Structurally,
    Always,
}

`in_any_value_of_ty`	`in_adt_inherently`	`Qualified`
❌	❌	`Qualified::Never`
✔️	❌	`Qualified::Structurally`
✔️	✔️	`Qualified::Always`
❌	✔️	`bug!()`

Since they are "atomic" (i.e., not made up of component parts), primitive types are either Qualified::Never or Qualified::Always based on in_any_value_of_ty. I didn't opt to use this encoding explicitly because in_adt_inherently wants to operate on a DefId instead of a Ty. I didn't feel comfortable changing the upstream definitions of has_dtor and didn't know if I could use pointer equality to see if a Ty was UnsafeCell. If there's interest in the enum version, I could implement it with a bit of guidance.

rust-highfive · 2019-12-15T22:02:56Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-12-15T20:20:31.0022179Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-15T20:20:32.0007937Z ##[command]git config gc.auto 0
2019-12-15T20:20:32.0013431Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-15T20:20:32.0018482Z ##[command]git config --get-all http.proxy
2019-12-15T20:20:32.0023956Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67335/merge:refs/remotes/pull/67335/merge
---
2019-12-15T21:15:18.5487852Z .................................................................................................... 1600/9380
2019-12-15T21:15:22.4174765Z .................................................................................................... 1700/9380
2019-12-15T21:15:33.2263569Z ...................................................................i................................ 1800/9380
2019-12-15T21:15:39.6419699Z .................................................................................................... 1900/9380
2019-12-15T21:15:53.0282296Z ....................................................iiiii........................................... 2000/9380
2019-12-15T21:16:02.2267969Z .................................................................................................... 2200/9380
2019-12-15T21:16:04.4272270Z .................................................................................................... 2300/9380
2019-12-15T21:16:07.5177437Z .................................................................................................... 2400/9380
2019-12-15T21:16:27.9083223Z .................................................................................................... 2500/9380
---
2019-12-15T21:18:52.9921820Z .............................................................i...............i...................... 4800/9380
2019-12-15T21:18:59.8873554Z .................................................................................................... 4900/9380
2019-12-15T21:19:07.3262094Z .................................................................................................... 5000/9380
2019-12-15T21:19:11.8723706Z .....i.............................................................................................. 5100/9380
2019-12-15T21:19:21.0909077Z .......................................................................ii.ii...........i............ 5200/9380
2019-12-15T21:19:28.9141635Z .......i............................................................................................ 5400/9380
2019-12-15T21:19:37.8864957Z .................................................................................................... 5500/9380
2019-12-15T21:19:43.6873200Z .....................................................i.............................................. 5600/9380
2019-12-15T21:19:49.8559176Z .................................................................................................... 5700/9380
2019-12-15T21:19:49.8559176Z .................................................................................................... 5700/9380
2019-12-15T21:19:58.7887550Z .................................................................................................... 5800/9380
2019-12-15T21:20:05.1930297Z .........................................ii...i...ii..........i..................................... 5900/9380
2019-12-15T21:20:24.8251660Z .................................................................................................... 6100/9380
2019-12-15T21:20:32.0309378Z .................................................................................................... 6200/9380
2019-12-15T21:20:32.0309378Z .................................................................................................... 6200/9380
2019-12-15T21:20:41.3711195Z ..................................................................i..ii............................. 6300/9380
2019-12-15T21:21:06.8889876Z .................................................................................................... 6500/9380
2019-12-15T21:21:08.7772526Z ......................................i............................................................. 6600/9380
2019-12-15T21:21:10.7868414Z .................................................................................................... 6700/9380
2019-12-15T21:21:12.9044881Z ..............................i..................................................................... 6800/9380
---
2019-12-15T21:22:38.7080428Z .................................................................................................... 7400/9380
2019-12-15T21:22:42.9596910Z .................................................................................................... 7500/9380
2019-12-15T21:22:48.0864650Z .................................................................................................... 7600/9380
2019-12-15T21:22:56.4299029Z .................................................................................................... 7700/9380
2019-12-15T21:23:04.5001790Z ...................................................iiii............................................. 7800/9380
2019-12-15T21:23:17.4332081Z .................................................................................................... 8000/9380
2019-12-15T21:23:23.0361044Z .................................................................................................... 8100/9380
2019-12-15T21:23:36.7972039Z .................................................................................................... 8200/9380
2019-12-15T21:23:43.7273997Z .................................................................................................... 8300/9380
---
2019-12-15T21:25:53.1760991Z  finished in 5.689
2019-12-15T21:25:53.1933095Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-12-15T21:25:53.3904344Z 
2019-12-15T21:25:53.3905311Z running 166 tests
2019-12-15T21:25:56.1709212Z iiii......i........ii..iiii...i.............................i..i..................i....i............ 100/166
2019-12-15T21:25:58.1191769Z i.i.i...iii..iiiiiii.......................iii............ii......
2019-12-15T21:25:58.1196067Z 
2019-12-15T21:25:58.1200257Z  finished in 4.926
2019-12-15T21:25:58.1372822Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-12-15T21:25:58.2870597Z 
---
2019-12-15T21:26:00.0644001Z  finished in 1.927
2019-12-15T21:26:00.0836571Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-12-15T21:26:00.2323684Z 
2019-12-15T21:26:00.2323815Z running 9 tests
2019-12-15T21:26:00.2324614Z iiiiiiiii
2019-12-15T21:26:00.2325051Z 
2019-12-15T21:26:00.2325100Z  finished in 0.148
2019-12-15T21:26:00.2482972Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-12-15T21:26:00.4020874Z 
---
2019-12-15T21:26:17.5548360Z  finished in 17.306
2019-12-15T21:26:17.5781900Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-12-15T21:26:17.7402320Z 
2019-12-15T21:26:17.7403370Z running 124 tests
2019-12-15T21:26:40.7027681Z .iiiii..ii.....i..i...i..i.i.i..i..i..iii....ii.ii....ii..........iiii..........i.....i..ii.......ii 100/124
2019-12-15T21:26:44.6164521Z .i.iii.....iiiiii.....ii
2019-12-15T21:26:44.6166070Z 
2019-12-15T21:26:44.6169652Z  finished in 27.038
2019-12-15T21:26:44.6176341Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-12-15T21:26:44.6178019Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-12-15T21:38:40.4495432Z 
2019-12-15T21:38:40.4499098Z    Doc-tests core
2019-12-15T21:38:44.4443732Z 
2019-12-15T21:38:44.4444556Z running 2437 tests
2019-12-15T21:38:52.5055570Z ......iiiii......................................................................................... 100/2437
2019-12-15T21:39:00.3849424Z ..................................................................................ii................ 200/2437
2019-12-15T21:39:19.0031670Z ................i................................................................................... 400/2437
2019-12-15T21:39:19.0031670Z ................i................................................................................... 400/2437
2019-12-15T21:39:27.2873265Z ................................................................i..i..................iiii.......... 500/2437
2019-12-15T21:39:41.7887027Z .................................................................................................... 700/2437
2019-12-15T21:39:49.3029604Z .................................................................................................... 800/2437
2019-12-15T21:39:57.2657245Z .................................................................................................... 900/2437
2019-12-15T21:40:05.3455855Z .................................................................................................... 1000/2437
---
2019-12-15T21:43:18.4289553Z .................................................................................................... 500/756
2019-12-15T21:43:18.4583406Z .............thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1189:5
2019-12-15T21:43:18.4602910Z ....thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', src/libcore/result.rs:1189:5
2019-12-15T21:43:18.4610246Z thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1189:5
2019-12-15T21:43:18.4637436Z .......thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1189:5
2019-12-15T21:43:18.7574649Z ..........................................thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:.1189:5
2019-12-15T21:43:18.7588859Z ....thread 'thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', src/libcore/result.rs:1189:5
2019-12-15T21:43:18.7597182Z <unnamed>.' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1189:5
2019-12-15T21:43:18.7621208Z ......thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1189:5
2019-12-15T21:43:20.8094997Z ...............thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:627:13
2019-12-15T21:43:20.8097791Z thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:582:13
2019-12-15T21:43:20.8104661Z ......thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:559:13
2019-12-15T21:43:20.8106999Z thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:687:13
2019-12-15T21:43:20.8106999Z thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:687:13
2019-12-15T21:43:20.8124209Z ...thread '<unnamed>' panicked at 'assertion failed: `(left == right)`
2019-12-15T21:43:20.8124601Z   left: `1`,
2019-12-15T21:43:20.8126325Z  right: `2`', src/libstd/sync/mutex.rs:651:13
2019-12-15T21:43:20.8185702Z ..........thread '<unnamed>' panicked at 'test panic in inner thread to poison RwLock', src/libstd/sync/rwlock.rs:791:13
2019-12-15T21:43:20.8198867Z ...thread '<unnamed>' panicked at 'test panic in inner thread to poison RwLock', src/libstd/sync/rwlock.rs:768:13
2019-12-15T21:43:20.8212656Z ..thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/rwlock.rs:705:13
2019-12-15T21:43:20.8223324Z .thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/rwlock.rs:635:13
2019-12-15T21:43:20.8234442Z thread '.<unnamed>' panicked at 'explicit panic', src/libstd/sync/rwlock.rs:646:13
2019-12-15T21:43:20.8242789Z thread '<unnamed>' panicked at 'explicit panic', .src/libstd/sync/rwlock.rs:611:13
2019-12-15T21:43:20.8251247Z ....thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/rwlock.rs:623:13
2019-12-15T21:43:22.8670334Z .......................thread '<unnamed>' panicked at 'What the answer to my lifetimes dilemma is?', src/libstd/sys_common/remutex.rs:233:13
2019-12-15T21:43:22.8822511Z .............................thread '<unnamed>' panicked at 'explicit panic', src/libstd/thread/mod.rs:1544:13
2019-12-15T21:43:23.4929337Z ...........thread '<unnamed>' panicked at 'Box<Any>', src/libstd/thread/mod.rs:1676:13
2019-12-15T21:43:23.4937704Z .thread '<unnamed>' panicked at 'owned string', src/libstd/thread/mod.rs:1662:13
2019-12-15T21:43:23.4946656Z .thread '<unnamed>' panicked at 'static string', src/libstd/thread/mod.rs:1648:13
---
2019-12-15T21:43:30.0193572Z 
2019-12-15T21:43:30.0194933Z running 1003 tests
2019-12-15T21:43:45.7130298Z i................................................................................................... 100/1003
2019-12-15T21:43:55.0613791Z .................................................................................................... 200/1003
2019-12-15T21:44:01.6008666Z ..................iii......i......i...i......i...................................................... 300/1003
2019-12-15T21:44:06.0000878Z .................................................................................................... 400/1003
2019-12-15T21:44:12.2881748Z ..........................................i..i.....................................ii............... 500/1003
2019-12-15T21:44:24.3129375Z .................................................................................................... 700/1003
2019-12-15T21:44:24.3129375Z .................................................................................................... 700/1003
2019-12-15T21:44:30.4364220Z .............................iiii................................................................... 800/1003
2019-12-15T21:44:43.1504209Z .................................................................................................... 900/1003
2019-12-15T21:44:49.2916615Z ...................................................iiii............................................. 1000/1003
2019-12-15T21:44:49.3910426Z test result: ok. 983 passed; 0 failed; 20 ignored; 0 measured; 0 filtered out
2019-12-15T21:44:49.3910693Z 
2019-12-15T21:44:49.4029278Z  finished in 163.872
2019-12-15T21:44:49.4042879Z Testing term stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2019-12-15T22:01:42.8977171Z  finished in 34.496
2019-12-15T22:01:42.9300904Z Check compiletest suite=run-make-fulldeps mode=run-make (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-12-15T22:01:43.1145688Z 
2019-12-15T22:01:43.1145945Z running 206 tests
2019-12-15T22:02:11.2435721Z ....................i...ii....................................................................i..... 100/206
2019-12-15T22:02:40.8974084Z ...............F..................iiiiii......i............iiii.iii................................. 200/206
2019-12-15T22:02:41.6970713Z failures:
2019-12-15T22:02:41.6970852Z 
2019-12-15T22:02:41.6971107Z ---- [run-make] run-make-fulldeps/min-global-align stdout ----
2019-12-15T22:02:41.6971136Z 
2019-12-15T22:02:41.6971136Z 
2019-12-15T22:02:41.6971175Z error: make failed
2019-12-15T22:02:41.6971235Z status: exit code: 2
2019-12-15T22:02:41.6971272Z command: "make"
2019-12-15T22:02:41.6971307Z stdout:
2019-12-15T22:02:41.6971527Z ------------------------------------------
2019-12-15T22:02:41.6972487Z LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/min-global-align/min-global-align:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib" '/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc' --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/min-global-align/min-global-align -L /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/min-global-align/min-global-align  --target=i686-unknown-linux-gnu --emit=llvm-ir min_global_align.rs
2019-12-15T22:02:41.6972830Z Makefile:15: recipe for target 'all' failed
2019-12-15T22:02:41.6973055Z ------------------------------------------
2019-12-15T22:02:41.6973115Z stderr:
2019-12-15T22:02:41.6973298Z ------------------------------------------
2019-12-15T22:02:41.6973346Z error[E0492]: cannot borrow a constant which may contain interior mutability, create a static instead
2019-12-15T22:02:41.6973346Z error[E0492]: cannot borrow a constant which may contain interior mutability, create a static instead
2019-12-15T22:02:41.6973696Z   --> min_global_align.rs:10:44
2019-12-15T22:02:41.6973738Z    |
2019-12-15T22:02:41.6973957Z 10 | pub static CONST_BOOL_REF: &'static bool = &CONST_BOOL;
2019-12-15T22:02:41.6974051Z 
2019-12-15T22:02:41.6974087Z error: aborting due to previous error
2019-12-15T22:02:41.6974111Z 
2019-12-15T22:02:41.6974344Z For more information about this error, try `rustc --explain E0492`.
2019-12-15T22:02:41.6974344Z For more information about this error, try `rustc --explain E0492`.
2019-12-15T22:02:41.6974387Z make: *** [all] Error 1
2019-12-15T22:02:41.6974593Z ------------------------------------------
2019-12-15T22:02:41.6974640Z 
2019-12-15T22:02:41.6974662Z 
2019-12-15T22:02:41.6974683Z 
---
2019-12-15T22:02:41.6981380Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:537:22
2019-12-15T22:02:41.6981458Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-12-15T22:02:41.6987465Z 
2019-12-15T22:02:41.6987566Z 
2019-12-15T22:02:41.6997634Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--rustdoc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "--src-base" "/checkout/src/test/run-make-fulldeps" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "run-make" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "cc" "--cxx" "c++" "--cflags" "-ffunction-sections -fdata-sections -fPIC -m64" "--llvm-components" "aarch64 aarch64asmparser aarch64asmprinter aarch64codegen aarch64desc aarch64disassembler aarch64info aarch64utils aggressiveinstcombine all all-targets amdgpu amdgpuasmparser amdgpuasmprinter amdgpucodegen amdgpudesc amdgpudisassembler amdgpuinfo amdgpuutils analysis arm armasmparser armasmprinter armcodegen armdesc armdisassembler arminfo armutils asmparser asmprinter avr avrasmparser avrasmprinter avrcodegen avrdesc avrdisassembler avrinfo binaryformat bitreader bitwriter bpf bpfasmparser bpfasmprinter bpfcodegen bpfdesc bpfdisassembler bpfinfo codegen core coroutines coverage debuginfocodeview debuginfodwarf debuginfomsf debuginfopdb demangle dlltooldriver engine executionengine fuzzmutate globalisel hexagon hexagonasmparser hexagoncodegen hexagondesc hexagondisassembler hexagoninfo instcombine instrumentation interpreter ipo irreader lanai lanaiasmparser lanaiasmprinter lanaicodegen lanaidesc lanaidisassembler lanaiinfo libdriver lineeditor linker lto mc mcdisassembler mcjit mcparser mips mipsasmparser mipsasmprinter mipscodegen mipsdesc mipsdisassembler mipsinfo mirparser msp430 msp430asmprinter msp430codegen msp430desc msp430info native nativecodegen nvptx nvptxasmprinter nvptxcodegen nvptxdesc nvptxinfo objcarcopts object objectyaml option orcjit passes perfjitevents powerpc powerpcasmparser powerpcasmprinter powerpccodegen powerpcdesc powerpcdisassembler powerpcinfo profiledata runtimedyld scalaropts selectiondag sparc sparcasmparser sparcasmprinter sparccodegen sparcdesc sparcdisassembler sparcinfo support symbolize systemz systemzasmparser systemzasmprinter systemzcodegen systemzdesc systemzdisassembler systemzinfo tablegen target transformutils vectorize webassembly webassemblyasmparser webassemblyasmprinter webassemblycodegen webassemblydesc webassemblydisassembler webassemblyinfo windowsmanifest x86 x86asmparser x86asmprinter x86codegen x86desc x86disassembler x86info x86utils xcore xcoreasmprinter xcorecodegen xcoredesc xcoredisassembler xcoreinfo" "--llvm-cxxflags" "-I/usr/lib/llvm-7/include -std=c++0x -fuse-ld=gold -Wl,--no-keep-files-mapped -Wl,--no-map-whole-files -fPIC -fvisibility-inlines-hidden -Werror=date-time -std=c++11 -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wno-maybe-uninitialized -Wdelete-non-virtual-dtor -Wno-comment -ffunction-sections -fdata-sections -O2 -DNDEBUG  -fno-exceptions -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS" "--ar" "ar" "--llvm-bin-dir" "/usr/lib/llvm-7/bin" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-12-15T22:02:41.6998521Z 
2019-12-15T22:02:41.6998550Z 
2019-12-15T22:02:41.7001603Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-12-15T22:02:41.7001664Z Build completed unsuccessfully in 1:36:22
2019-12-15T22:02:41.7001664Z Build completed unsuccessfully in 1:36:22
2019-12-15T22:02:41.7051564Z == clock drift check ==
2019-12-15T22:02:41.7993679Z   local time: Sun Dec 15 22:02:41 UTC 2019
2019-12-15T22:02:43.0278312Z   network time: Sun, 15 Dec 2019 22:02:43 GMT
2019-12-15T22:02:43.0288037Z == end clock drift check ==
2019-12-15T22:02:51.4357130Z 
2019-12-15T22:02:51.4471903Z ##[error]Bash exited with code '1'.
2019-12-15T22:02:51.4541638Z ##[section]Starting: Checkout
2019-12-15T22:02:51.4544070Z ==============================================================================
2019-12-15T22:02:51.4544164Z Task         : Get sources
2019-12-15T22:02:51.4544218Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Centril · 2019-12-16T05:06:45Z

For background, in_any_value_of_ty and in_adt_inherently basically encode the following enum.

I would include the enum-as-explanation + the table in the rustdocs. :)

bors · 2019-12-20T19:46:02Z

☔ The latest upstream changes (presumably #67455) made this pull request unmergeable. Please resolve the merge conflicts.

Dylan-DPC-zz · 2020-01-15T13:51:22Z

@ecstatic-morse can you rebase this? thanks

hdhoang · 2020-02-06T06:17:25Z

ping from triage @ecstatic-morse, could you rebase? thank you

bors · 2020-02-19T01:45:30Z

☔ The latest upstream changes (presumably #69271) made this pull request unmergeable. Please resolve the merge conflicts.

JohnCSimon · 2020-03-09T06:51:59Z

Ping from triage:
@ecstatic-morse - can you please rebase?
@eddyb Is this ready for review?
thanks

ecstatic-morse · 2020-03-09T22:49:24Z

@eddyb should I just close this?

eddyb · 2020-03-12T15:36:03Z

@ecstatic-morse I don't know, I like this design but I don't remember what was up with this PR - I think I just never got around to review it, and perhaps when I got notified it needed a rebase or something?

eddyb

r=me after a rebase

rust-highfive · 2020-03-15T00:12:21Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-03-14T22:20:54.7395104Z ========================== Starting Command Output ===========================
2020-03-14T22:20:54.7400958Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/29976989-c722-48be-8fe6-b9d9e5dceb70.sh
2020-03-14T22:20:54.7401271Z 
2020-03-14T22:20:54.7407425Z ##[section]Finishing: Disable git automatic line ending conversion
2020-03-14T22:20:54.7430103Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/67335/merge to s
2020-03-14T22:20:54.7434232Z Task         : Get sources
2020-03-14T22:20:54.7434564Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-14T22:20:54.7434912Z Version      : 1.0.0
2020-03-14T22:20:54.7435137Z Author       : Microsoft
---
2020-03-14T22:20:55.7256193Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-03-14T22:20:55.7262479Z ##[command]git config gc.auto 0
2020-03-14T22:20:55.7267361Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-03-14T22:20:55.7271319Z ##[command]git config --get-all http.proxy
2020-03-14T22:20:55.7278730Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67335/merge:refs/remotes/pull/67335/merge
---
2020-03-14T23:21:07.3187518Z .................................................................................................... 1700/9771
2020-03-14T23:21:11.5758163Z .................................................................................................... 1800/9771
2020-03-14T23:21:23.0941939Z ...................................................................i................................ 1900/9771
2020-03-14T23:21:29.7781002Z .................................................................................................... 2000/9771
2020-03-14T23:21:43.6848277Z .........................................................iiiii...................................... 2100/9771
2020-03-14T23:21:54.1641287Z .................................................................................................... 2300/9771
2020-03-14T23:21:56.2910818Z .................................................................................................... 2400/9771
2020-03-14T23:21:59.2948631Z .................................................................................................... 2500/9771
2020-03-14T23:22:20.9513919Z .................................................................................................... 2600/9771
---
2020-03-14T23:25:00.1342210Z .............................i...............i...................................................... 5000/9771
2020-03-14T23:25:09.4337727Z .................................................................................................... 5100/9771
2020-03-14T23:25:15.4727928Z ........................................................................i........................... 5200/9771
2020-03-14T23:25:20.9949017Z .................................................................................................... 5300/9771
2020-03-14T23:25:30.4691758Z .....................................................ii.ii........i...i............................. 5400/9771
2020-03-14T23:25:38.2286339Z .................................................................................................... 5600/9771
2020-03-14T23:25:47.6769776Z .................................................................................................... 5700/9771
2020-03-14T23:25:53.7431994Z .............................................i...................................................... 5800/9771
2020-03-14T23:26:00.0170309Z .................................................................................................... 5900/9771
2020-03-14T23:26:00.0170309Z .................................................................................................... 5900/9771
2020-03-14T23:26:10.0444453Z .................................................................................................... 6000/9771
2020-03-14T23:26:15.7797661Z .......................................ii...i..ii...........i....................................... 6100/9771
2020-03-14T23:26:35.9387543Z .................................................................................................... 6300/9771
2020-03-14T23:26:42.6612137Z .................................................................................................... 6400/9771
2020-03-14T23:26:42.6612137Z .................................................................................................... 6400/9771
2020-03-14T23:26:52.1834410Z .....................................................................i..ii.......................... 6500/9771
2020-03-14T23:27:15.0019321Z .................................................................................................... 6700/9771
2020-03-14T23:27:23.9703643Z ...................................................................i................................ 6800/9771
2020-03-14T23:27:26.0036398Z .................................................................................................... 6900/9771
2020-03-14T23:27:28.1821772Z .................................................................................................... 7000/9771
---
2020-03-14T23:29:12.6444431Z .................................................................................................... 7800/9771
2020-03-14T23:29:18.3746756Z .................................................................................................... 7900/9771
2020-03-14T23:29:24.1717333Z ...................................................i................................................ 8000/9771
2020-03-14T23:29:34.3936556Z .................................................................................................... 8100/9771
2020-03-14T23:29:39.6760547Z iiiiiiiiii.i........................................................................................ 8200/9771
2020-03-14T23:29:53.1185037Z .................................................................................................... 8400/9771
2020-03-14T23:30:03.7374692Z .................................................................................................... 8500/9771
2020-03-14T23:30:16.1949866Z .................................................................................................... 8600/9771
2020-03-14T23:30:21.7779439Z .................................................................................................... 8700/9771
---
2020-03-14T23:32:40.8931163Z  finished in 7.642
2020-03-14T23:32:40.9121517Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-14T23:32:41.0842849Z 
2020-03-14T23:32:41.0844006Z running 181 tests
2020-03-14T23:32:44.0105067Z iiii......i............ii..iiii....i....i...........i............i..i..................i....i....... 100/181
2020-03-14T23:32:46.5368509Z .....i.i.i...iii..iiiiiiiiiiiiiiii.......................iii.............ii......
2020-03-14T23:32:46.5374191Z 
2020-03-14T23:32:46.5374377Z  finished in 5.625
2020-03-14T23:32:46.5567873Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-14T23:32:46.7354602Z 
---
2020-03-14T23:32:48.7134308Z  finished in 2.156
2020-03-14T23:32:48.7333076Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-14T23:32:48.8782369Z 
2020-03-14T23:32:48.8796665Z running 9 tests
2020-03-14T23:32:48.8798310Z iiiiiiiii
2020-03-14T23:32:48.8799460Z 
2020-03-14T23:32:48.8799656Z  finished in 0.144
2020-03-14T23:32:48.8955376Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-14T23:32:49.0435176Z 
---
2020-03-14T23:33:09.1409718Z  finished in 20.245
2020-03-14T23:33:09.1612636Z Check compiletest suite=debuginfo mode=debuginfo (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-14T23:33:09.3421634Z 
2020-03-14T23:33:09.3422111Z running 115 tests
2020-03-14T23:33:22.4999572Z iiiii..i.....i..i...i..i.i.i..i..i..ii....i.i....ii..........iiii.........i.....i..i.......ii.i.ii.. 100/115
2020-03-14T23:33:24.1323512Z ...iiii.....ii.
2020-03-14T23:33:24.1326007Z 
2020-03-14T23:33:24.1326220Z  finished in 14.971
2020-03-14T23:33:24.1333736Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-14T23:33:24.1334503Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2020-03-14T23:46:22.7245272Z 
2020-03-14T23:46:22.7246452Z    Doc-tests core
2020-03-14T23:46:27.5095393Z 
2020-03-14T23:46:27.5096345Z running 2480 tests
2020-03-14T23:46:36.8526077Z ......iiiii......................................................................................... 100/2480
2020-03-14T23:46:46.3069420Z ....................................................................................ii.............. 200/2480
2020-03-14T23:47:08.4952914Z ...................i................................................................................ 400/2480
2020-03-14T23:47:08.4952914Z ...................i................................................................................ 400/2480
2020-03-14T23:47:18.6729265Z ........................................................................i..i..................iiii.. 500/2480
2020-03-14T23:47:35.9953149Z .................................................................................................... 700/2480
2020-03-14T23:47:44.6333035Z .................................................................................................... 800/2480
2020-03-14T23:47:53.2352273Z .................................................................................................... 900/2480
2020-03-14T23:48:01.8436310Z .................................................................................................... 1000/2480
---
2020-03-14T23:51:34.4963060Z 
2020-03-14T23:51:34.4964063Z running 1010 tests
2020-03-14T23:51:51.9937887Z i................................................................................................... 100/1010
2020-03-14T23:52:01.9224233Z .................................................................................................... 200/1010
2020-03-14T23:52:08.8453676Z ..................iii......i......i...i......i...................................................... 300/1010
2020-03-14T23:52:13.8984638Z .................................................................................................... 400/1010
2020-03-14T23:52:20.4764168Z ............................................i..i......................................ii............ 500/1010
2020-03-14T23:52:32.6873371Z .................................................................................................... 700/1010
2020-03-14T23:52:32.6873371Z .................................................................................................... 700/1010
2020-03-14T23:52:39.2756071Z ....................................iiii............................................................ 800/1010
2020-03-14T23:52:53.1551241Z .................................................................................................... 900/1010
2020-03-14T23:52:59.7463223Z ..........................................................iiii...................................... 1000/1010
2020-03-14T23:53:00.1658943Z test result: ok. 990 passed; 0 failed; 20 ignored; 0 measured; 0 filtered out
2020-03-14T23:53:00.1659210Z 
2020-03-14T23:53:00.1747641Z  finished in 163.742
2020-03-14T23:53:00.1762539Z Testing term stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2020-03-15T00:11:03.3875786Z  finished in 39.637
2020-03-15T00:11:03.4130834Z Check compiletest suite=run-make-fulldeps mode=run-make (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-15T00:11:03.5701689Z 
2020-03-15T00:11:03.5702117Z running 210 tests
2020-03-15T00:11:35.1103380Z ......................i...ii.......................................................................i 100/210
2020-03-15T00:12:13.5140219Z ....................F...................iiiiii......i..............iii.............................. 200/210
2020-03-15T00:12:14.4236508Z failures:
2020-03-15T00:12:14.4241112Z 
2020-03-15T00:12:14.4241686Z ---- [run-make] run-make-fulldeps/min-global-align stdout ----
2020-03-15T00:12:14.4241878Z 
2020-03-15T00:12:14.4241878Z 
2020-03-15T00:12:14.4242037Z error: make failed
2020-03-15T00:12:14.4242212Z status: exit code: 2
2020-03-15T00:12:14.4242379Z command: "make"
2020-03-15T00:12:14.4242518Z stdout:
2020-03-15T00:12:14.4243034Z ------------------------------------------
2020-03-15T00:12:14.4246016Z LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/min-global-align/min-global-align:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib" '/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc' --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/min-global-align/min-global-align -L /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/min-global-align/min-global-align  --target=i686-unknown-linux-gnu --emit=llvm-ir min_global_align.rs
2020-03-15T00:12:14.4248658Z Makefile:15: recipe for target 'all' failed
2020-03-15T00:12:14.4249709Z ------------------------------------------
2020-03-15T00:12:14.4250063Z stderr:
2020-03-15T00:12:14.4251038Z ------------------------------------------
2020-03-15T00:12:14.4251398Z error[E0119]: conflicting implementations of trait `Freeze` for type `bool`:
2020-03-15T00:12:14.4251398Z error[E0119]: conflicting implementations of trait `Freeze` for type `bool`:
2020-03-15T00:12:14.4252245Z   --> min_global_align.rs:23:1
2020-03-15T00:12:14.4252847Z    |
2020-03-15T00:12:14.4253022Z 20 | impl Freeze for bool {}
2020-03-15T00:12:14.4253677Z    | -------------------- first implementation here
2020-03-15T00:12:14.4253875Z ...
2020-03-15T00:12:14.4254457Z 23 | impl<T: ?Sized> Freeze for T {}
2020-03-15T00:12:14.4255076Z 
2020-03-15T00:12:14.4255241Z error: aborting due to previous error
2020-03-15T00:12:14.4255408Z 
2020-03-15T00:12:14.4256316Z For more information about this error, try `rustc --explain E0119`.
2020-03-15T00:12:14.4256316Z For more information about this error, try `rustc --explain E0119`.
2020-03-15T00:12:14.4256565Z make: *** [all] Error 1
2020-03-15T00:12:14.4257238Z ------------------------------------------
2020-03-15T00:12:14.4257395Z 
2020-03-15T00:12:14.4257481Z 
2020-03-15T00:12:14.4257576Z 
---
2020-03-15T00:12:14.4261118Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:348:22
2020-03-15T00:12:14.4261500Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-03-15T00:12:14.4261708Z 
2020-03-15T00:12:14.4261819Z 
2020-03-15T00:12:14.4271638Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--rustdoc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "--src-base" "/checkout/src/test/run-make-fulldeps" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "run-make" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "cc" "--cxx" "c++" "--cflags" "-ffunction-sections -fdata-sections -fPIC -m64" "--llvm-components" "aarch64 aarch64asmparser aarch64asmprinter aarch64codegen aarch64desc aarch64disassembler aarch64info aarch64utils aggressiveinstcombine all all-targets amdgpu amdgpuasmparser amdgpuasmprinter amdgpucodegen amdgpudesc amdgpudisassembler amdgpuinfo amdgpuutils analysis arm armasmparser armasmprinter armcodegen armdesc armdisassembler arminfo armutils asmparser asmprinter avr avrasmparser avrasmprinter avrcodegen avrdesc avrdisassembler avrinfo binaryformat bitreader bitwriter bpf bpfasmparser bpfasmprinter bpfcodegen bpfdesc bpfdisassembler bpfinfo codegen core coroutines coverage debuginfocodeview debuginfodwarf debuginfomsf debuginfopdb demangle dlltooldriver engine executionengine fuzzmutate globalisel hexagon hexagonasmparser hexagoncodegen hexagondesc hexagondisassembler hexagoninfo instcombine instrumentation interpreter ipo irreader lanai lanaiasmparser lanaiasmprinter lanaicodegen lanaidesc lanaidisassembler lanaiinfo libdriver lineeditor linker lto mc mcdisassembler mcjit mcparser mips mipsasmparser mipsasmprinter mipscodegen mipsdesc mipsdisassembler mipsinfo mirparser msp430 msp430asmprinter msp430codegen msp430desc msp430info native nativecodegen nvptx nvptxasmprinter nvptxcodegen nvptxdesc nvptxinfo objcarcopts object objectyaml option orcjit passes perfjitevents powerpc powerpcasmparser powerpcasmprinter powerpccodegen powerpcdesc powerpcdisassembler powerpcinfo profiledata runtimedyld scalaropts selectiondag sparc sparcasmparser sparcasmprinter sparccodegen sparcdesc sparcdisassembler sparcinfo support symbolize systemz systemzasmparser systemzasmprinter systemzcodegen systemzdesc systemzdisassembler systemzinfo tablegen target transformutils vectorize webassembly webassemblyasmparser webassemblyasmprinter webassemblycodegen webassemblydesc webassemblydisassembler webassemblyinfo windowsmanifest x86 x86asmparser x86asmprinter x86codegen x86desc x86disassembler x86info x86utils xcore xcoreasmprinter xcorecodegen xcoredesc xcoredisassembler xcoreinfo" "--ar" "ar" "--llvm-bin-dir" "/usr/lib/llvm-7/bin" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-03-15T00:12:14.4278238Z 
2020-03-15T00:12:14.4278341Z 
2020-03-15T00:12:14.4278563Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2020-03-15T00:12:14.4278939Z Build completed unsuccessfully in 1:45:31
2020-03-15T00:12:14.4278939Z Build completed unsuccessfully in 1:45:31
2020-03-15T00:12:14.4373173Z == clock drift check ==
2020-03-15T00:12:14.4398499Z   local time: Sun Mar 15 00:12:14 UTC 2020
2020-03-15T00:12:14.6120443Z   network time: Sun, 15 Mar 2020 00:12:14 GMT
2020-03-15T00:12:14.6122421Z == end clock drift check ==
2020-03-15T00:12:16.7886171Z 
2020-03-15T00:12:16.7972262Z ##[error]Bash exited with code '1'.
2020-03-15T00:12:16.7988108Z ##[section]Finishing: Run build
2020-03-15T00:12:16.8039524Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/67335/merge to s
2020-03-15T00:12:16.8044918Z Task         : Get sources
2020-03-15T00:12:16.8045229Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-15T00:12:16.8045510Z Version      : 1.0.0
2020-03-15T00:12:16.8045749Z Author       : Microsoft
2020-03-15T00:12:16.8045749Z Author       : Microsoft
2020-03-15T00:12:16.8046064Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-03-15T00:12:16.8046421Z ==============================================================================
2020-03-15T00:12:17.1559005Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-03-15T00:12:17.1609870Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/67335/merge to s
2020-03-15T00:12:17.1707979Z Cleaning up task key
2020-03-15T00:12:17.1715832Z Start cleaning up orphan processes.
2020-03-15T00:12:17.1939342Z Terminate orphan process: pid (4028) (python)
2020-03-15T00:12:17.2202251Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

oli-obk · 2020-03-15T14:52:12Z

@bors r=eddyb

bors · 2020-03-15T14:52:13Z

📌 Commit 6f75d3f has been approved by eddyb

@eddyb

…ddyb Refactor the `Qualif` trait This PR attempts to preserve the existing semantics of the `Qualif` trait while reducing its API to two significant methods with descriptive names, `in_any_value_of_ty` and `in_adt_inherently`. The other `in_*` methods have been made into free functions, since they should never be overloaded. Finally, I changed the bounds on the `in_local` argument to be less restrictive (`FnMut` instead of `Fn`), which addresses a FIXME in the const-checker. r? @eddyb cc @pnkfelix @oli-obk

@ghost

Rollup of 7 pull requests Successful merges: - #67335 (Refactor the `Qualif` trait) - #69122 (Backtrace Debug tweaks) - #69520 (Make error message clearer about creating new module) - #69738 (More Method -> AssocFn renaming) - #69867 (Add long error explanation for E0628 ) - #69989 (resolve/hygiene: `macro_rules` are not "legacy") - #70036 (Make article_and_description primarily use def_kind) Failed merges: r? @ghost

rust-highfive assigned eddyb Dec 15, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 15, 2019

ecstatic-morse changed the title ~~Refactor the Qualif trait.~~ Refactor the Qualif trait Dec 15, 2019

ecstatic-morse mentioned this pull request Dec 16, 2019

Const qualification for StructuralEq #67343

Merged

Dylan-DPC-zz added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 19, 2020

ecstatic-morse force-pushed the qualif-refactor branch from 49fedba to 6280a8f Compare February 7, 2020 19:35

Dylan-DPC-zz added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 11, 2020

JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 2, 2020

eddyb approved these changes Mar 12, 2020

View reviewed changes

Simplify Qualif interface

6f75d3f

ecstatic-morse force-pushed the qualif-refactor branch from 6280a8f to 8275ae2 Compare March 14, 2020 22:20

ecstatic-morse force-pushed the qualif-refactor branch from 8275ae2 to 6f75d3f Compare March 15, 2020 00:29

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 15, 2020

Dylan-DPC-zz mentioned this pull request Mar 15, 2020

Rollup of 9 pull requests #70033

Closed

Dylan-DPC-zz mentioned this pull request Mar 16, 2020

Rollup of 7 pull requests #70040

Merged

bors merged commit 59b0058 into rust-lang:master Mar 16, 2020

ecstatic-morse deleted the qualif-refactor branch October 6, 2020 01:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor the `Qualif` trait #67335

Refactor the `Qualif` trait #67335

ecstatic-morse commented Dec 15, 2019 •

edited

Loading

ecstatic-morse commented Dec 15, 2019 •

edited

Loading

rust-highfive commented Dec 15, 2019

Centril commented Dec 16, 2019 •

edited

Loading

bors commented Dec 20, 2019

Dylan-DPC-zz commented Jan 15, 2020

hdhoang commented Feb 6, 2020

bors commented Feb 19, 2020

JohnCSimon commented Mar 9, 2020

ecstatic-morse commented Mar 9, 2020

eddyb commented Mar 12, 2020

eddyb left a comment

rust-highfive commented Mar 15, 2020

oli-obk commented Mar 15, 2020

bors commented Mar 15, 2020

Refactor the Qualif trait #67335

Refactor the Qualif trait #67335

Conversation

ecstatic-morse commented Dec 15, 2019 • edited Loading

ecstatic-morse commented Dec 15, 2019 • edited Loading

rust-highfive commented Dec 15, 2019

Centril commented Dec 16, 2019 • edited Loading

bors commented Dec 20, 2019

Dylan-DPC-zz commented Jan 15, 2020

hdhoang commented Feb 6, 2020

bors commented Feb 19, 2020

JohnCSimon commented Mar 9, 2020

ecstatic-morse commented Mar 9, 2020

eddyb commented Mar 12, 2020

eddyb left a comment

Choose a reason for hiding this comment

rust-highfive commented Mar 15, 2020

oli-obk commented Mar 15, 2020

bors commented Mar 15, 2020

Refactor the `Qualif` trait #67335

Refactor the `Qualif` trait #67335

ecstatic-morse commented Dec 15, 2019 •

edited

Loading

ecstatic-morse commented Dec 15, 2019 •

edited

Loading

Centril commented Dec 16, 2019 •

edited

Loading