Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bound::cloned() #61376

Merged
merged 9 commits into from
Jun 6, 2019
Merged

Add Bound::cloned() #61376

merged 9 commits into from
Jun 6, 2019

Conversation

czipperz
Copy link
Contributor

Suggested by #61356

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 30, 2019
@czipperz
Copy link
Contributor Author

czipperz commented May 30, 2019

Open question: should Bound::copied be also added?

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:0e983cb8:start=1559252928788958470,finish=1559252929616764885,duration=827806415
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
[00:05:04]    Compiling backtrace v0.3.25
[00:05:07] error[E0539]: incorrect meta item
[00:05:07]    --> src/libcore/ops/range.rs:711:42
[00:05:07]     |
[00:05:07] 711 |     #[unstable(feature = "bound_cloned", issue = 61356)]
[00:05:07] 
[00:05:08]    Compiling compiler_builtins v0.1.15
[00:05:08]    Compiling backtrace-sys v0.1.27
[00:05:08]    Compiling cmake v0.1.38
---
[00:05:13]    Compiling rustc_lsan v0.0.0 (/checkout/src/librustc_lsan)
[00:05:14] error[E0308]: mismatched types
[00:05:14]    --> src/libcore/ops/range.rs:715:51
[00:05:14]     |
[00:05:14] 715 |             Bound::Included(x) => Bound::Included(x.clone()),
[00:05:14]     |                                                   ^^^^^^^^^ expected type parameter, found &T
[00:05:14]     = note: expected type `T`
[00:05:14]                found type `&T`
[00:05:14] 
[00:05:14] error[E0308]: mismatched types
[00:05:14] error[E0308]: mismatched types
[00:05:14]    --> src/libcore/ops/range.rs:716:51
[00:05:14]     |
[00:05:14] 716 |             Bound::Excluded(x) => Bound::Excluded(x.clone()),
[00:05:14]     |                                                   ^^^^^^^^^ expected type parameter, found &T
[00:05:14]     = note: expected type `T`
[00:05:14]                found type `&T`
[00:05:14] 
[00:05:19] error: aborting due to 3 previous errors

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Centril
Copy link
Contributor

Centril commented May 30, 2019

r? @sfackler

@Centril Centril added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. B-unstable Blocker: Implemented in the nightly compiler and unstable. labels May 30, 2019
src/libcore/ops/range.rs Outdated Show resolved Hide resolved
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:22de1f80:start=1559271248658007330,finish=1559271251098476393,duration=2440469063
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
[00:05:04]    Compiling rustc_asan v0.0.0 (/checkout/src/librustc_asan)
[00:05:16] error: method is never used: `cloned`
[00:05:16]    --> src/libcore/ops/range.rs:712:5
[00:05:16]     |
[00:05:16] 712 |     fn cloned(&self) -> Bound<T> {
[00:05:16]     |
[00:05:16]     = note: `-D dead-code` implied by `-D warnings`
[00:05:16] 
[00:05:16] error: aborting due to previous error
---
travis_time:end:039f5175:start=1559271579559208580,finish=1559271579564993409,duration=5784829
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:01d7865b
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:06aa4c30
travis_time:start:06aa4c30
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:15597f6e
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@czipperz
Copy link
Contributor Author

Some bozo has to write tests for this lol

@cuviper
Copy link
Member

cuviper commented May 31, 2019

IMO the doc test is sufficient, but it needs to be a pub fn.

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:0f1ad89a:start=1559325577027206038,finish=1559325666892915007,duration=89865708969
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
travis_time:start:test_codegen
Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:05:05] 
[01:05:05] running 143 tests
[01:05:08] i..iii.....iii..iiii.....i......................i...i................i......i.........ii.i..i..i.ii. 100/143
[01:05:09] test result: ok. 113 passed; 0 failed; 30 ignored; 0 measured; 0 filtered out
[01:05:09] 
[01:05:09]  finished in 4.507
[01:05:09] travis_fold:end:test_codegen
---
travis_time:start:test_assembly
Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:05:11] 
[01:05:11] running 9 tests
[01:05:11] iiiiiiiii
[01:05:11] 
[01:05:11]  finished in 0.150
[01:05:11] travis_fold:end:test_assembly

---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:05:27] 
[01:05:27] running 122 tests
[01:05:51] .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....i..........iiii..........i...ii...i.......ii.i 100/122
[01:05:56] .i.i......iii.i.....ii
[01:05:56] 
[01:05:56]  finished in 29.202
[01:05:56] travis_fold:end:test_debuginfo

---
[01:20:24]    Compiling core v0.0.0 (/checkout/src/libcore)
[01:20:26] error[E0433]: failed to resolve: use of undeclared type or module `Bound`
[01:20:26]   --> src/libcore/../libcore/tests/ops.rs:88:16
[01:20:26]    |
[01:20:26] 88 |     assert_eq!(Bound::<&u32>::Unbounded.cloned(), Bound::Unbounded);
[01:20:26]    |                ^^^^^ use of undeclared type or module `Bound`
[01:20:26] error[E0433]: failed to resolve: use of undeclared type or module `Bound`
[01:20:26]   --> src/libcore/../libcore/tests/ops.rs:88:51
[01:20:26]    |
[01:20:26]    |
[01:20:26] 88 |     assert_eq!(Bound::<&u32>::Unbounded.cloned(), Bound::Unbounded);
[01:20:26]    |                                                   ^^^^^ use of undeclared type or module `Bound`
[01:20:26] error[E0433]: failed to resolve: use of undeclared type or module `Bound`
[01:20:26]   --> src/libcore/../libcore/tests/ops.rs:93:16
[01:20:26]    |
[01:20:26]    |
[01:20:26] 93 |     assert_eq!(Bound::Included(&3).cloned(), Bound::Included(3));
[01:20:26]    |                ^^^^^ use of undeclared type or module `Bound`
[01:20:26] error[E0433]: failed to resolve: use of undeclared type or module `Bound`
[01:20:26]   --> src/libcore/../libcore/tests/ops.rs:93:46
[01:20:26]    |
[01:20:26]    |
[01:20:26] 93 |     assert_eq!(Bound::Included(&3).cloned(), Bound::Included(3));
[01:20:26]    |                                              ^^^^^ use of undeclared type or module `Bound`
[01:20:26] error[E0433]: failed to resolve: use of undeclared type or module `Bound`
[01:20:26]   --> src/libcore/../libcore/tests/ops.rs:98:16
[01:20:26]    |
[01:20:26]    |
[01:20:26] 98 |     assert_eq!(Bound::Excluded(&3).cloned(), Bound::Excluded(3));
[01:20:26]    |                ^^^^^ use of undeclared type or module `Bound`
[01:20:26] error[E0433]: failed to resolve: use of undeclared type or module `Bound`
[01:20:26]   --> src/libcore/../libcore/tests/ops.rs:98:46
[01:20:26]    |
[01:20:26]    |
[01:20:26] 98 |     assert_eq!(Bound::Excluded(&3).cloned(), Bound::Excluded(3));
[01:20:26]    |                                              ^^^^^ use of undeclared type or module `Bound`
[01:20:38] error: aborting due to 6 previous errors
[01:20:38] 
[01:20:38] For more information about this error, try `rustc --explain E0433`.
[01:20:38] error: Could not compile `core`.
[01:20:38] error: Could not compile `core`.
[01:20:38] 
[01:20:38] To learn more, run the command again with --verbose.
[01:20:38] 
[01:20:38] 
[01:20:38] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-p" "core" "--" "--quiet"
[01:20:38] 
[01:20:38] 
[01:20:38] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:20:38] Build completed unsuccessfully in 1:16:19
---
travis_time:end:038f7ef4:start=1559330515795711461,finish=1559330515801331841,duration=5620380
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0733ac78
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:13597014
travis_time:start:13597014
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:20d88950:start=1559349316005313853,finish=1559349403340076399,duration=87334762546
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
travis_time:start:test_codegen
Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:08:52] 
[01:08:52] running 143 tests
[01:08:55] i..iii.....iii..iiii.....i......................i..i.................i.....i..........ii.i..i..i.ii. 100/143
[01:08:57] test result: ok. 113 passed; 0 failed; 30 ignored; 0 measured; 0 filtered out
[01:08:57] 
[01:08:57]  finished in 4.895
[01:08:57] travis_fold:end:test_codegen
---
travis_time:start:test_assembly
Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:08:59] 
[01:08:59] running 9 tests
[01:08:59] iiiiiiiii
[01:08:59] 
[01:08:59]  finished in 0.166
[01:08:59] travis_fold:end:test_assembly

---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:09:16] 
[01:09:16] running 122 tests
[01:09:43] .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....i..........iiii..........i...ii...i.......ii.i 100/122
[01:09:48] .i.i......iii.i.....ii
[01:09:48] 
[01:09:48]  finished in 31.913
[01:09:48] travis_fold:end:test_debuginfo

---
[01:25:14]    Compiling core v0.0.0 (/checkout/src/libcore)
[01:25:26] error[E0658]: use of unstable library feature 'bound_cloned'
[01:25:26]   --> src/libcore/../libcore/tests/ops.rs:88:41
[01:25:26]    |
[01:25:26] 88 |     assert_eq!(Bound::<&u32>::Unbounded.cloned(), Bound::Unbounded);
[01:25:26]    |
[01:25:26]    = note: for more information, see https://github.com/rust-lang/rust/issues/61356
[01:25:26]    = note: for more information, see https://github.com/rust-lang/rust/issues/61356
[01:25:26]    = help: add #![feature(bound_cloned)] to the crate attributes to enable
[01:25:26] error[E0658]: use of unstable library feature 'bound_cloned'
[01:25:26]   --> src/libcore/../libcore/tests/ops.rs:93:36
[01:25:26]    |
[01:25:26]    |
[01:25:26] 93 |     assert_eq!(Bound::Included(&3).cloned(), Bound::Included(3));
[01:25:26]    |
[01:25:26]    = note: for more information, see https://github.com/rust-lang/rust/issues/61356
[01:25:26]    = note: for more information, see https://github.com/rust-lang/rust/issues/61356
[01:25:26]    = help: add #![feature(bound_cloned)] to the crate attributes to enable
[01:25:26] error[E0658]: use of unstable library feature 'bound_cloned'
[01:25:26]   --> src/libcore/../libcore/tests/ops.rs:98:36
[01:25:26]    |
[01:25:26]    |
[01:25:26] 98 |     assert_eq!(Bound::Excluded(&3).cloned(), Bound::Excluded(3));
[01:25:26]    |
[01:25:26]    = note: for more information, see https://github.com/rust-lang/rust/issues/61356
[01:25:26]    = note: for more information, see https://github.com/rust-lang/rust/issues/61356
[01:25:26]    = help: add #![feature(bound_cloned)] to the crate attributes to enable
[01:25:28] error: aborting due to 3 previous errors
[01:25:28] 
[01:25:28] For more information about this error, try `rustc --explain E0658`.
[01:25:28] error: Could not compile `core`.
[01:25:28] error: Could not compile `core`.
[01:25:28] 
[01:25:28] To learn more, run the command again with --verbose.
[01:25:28] 
[01:25:28] 
[01:25:28] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-p" "core" "--" "--quiet"
[01:25:28] 
[01:25:28] 
[01:25:28] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:25:28] Build completed unsuccessfully in 1:21:31
---
travis_time:end:12740dcd:start=1559354543525347297,finish=1559354543530554865,duration=5207568
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0043e360
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:29bded98
travis_time:start:29bded98
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0319a1dd
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@sfackler
Copy link
Member

sfackler commented Jun 1, 2019

LGTM but the build is still failing. Looks like you just need to enable the feature in core's lib.rs

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:055b1e6a:start=1559355632724391044,finish=1559355721082317976,duration=88357926932
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
travis_time:start:test_codegen
Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:05:30] 
[01:05:30] running 143 tests
[01:05:32] i..iii.....iii...iiii....i......................i..i.................i.....i..........ii.i..i..i.ii. 100/143
[01:05:34] test result: ok. 113 passed; 0 failed; 30 ignored; 0 measured; 0 filtered out
[01:05:34] 
[01:05:34]  finished in 4.630
[01:05:34] travis_fold:end:test_codegen
---
travis_time:start:test_assembly
Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:05:36] 
[01:05:36] running 9 tests
[01:05:36] iiiiiiiii
[01:05:36] 
[01:05:36]  finished in 0.150
[01:05:36] travis_fold:end:test_assembly

---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:05:52] 
[01:05:52] running 122 tests
[01:06:18] .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....i..........iiii..........i...ii...i.......ii.i 100/122
[01:06:23] .i.i......iii.i.....ii
[01:06:23] 
[01:06:23]  finished in 30.638
[01:06:23] travis_fold:end:test_debuginfo

---
[01:21:01]    Compiling core v0.0.0 (/checkout/src/libcore)
[01:21:12] error[E0658]: use of unstable library feature 'bound_cloned'
[01:21:12]   --> src/libcore/../libcore/tests/ops.rs:88:41
[01:21:12]    |
[01:21:12] 88 |     assert_eq!(Bound::<&u32>::Unbounded.cloned(), Bound::Unbounded);
[01:21:12]    |
[01:21:12]    = note: for more information, see https://github.com/rust-lang/rust/issues/61356
[01:21:12]    = note: for more information, see https://github.com/rust-lang/rust/issues/61356
[01:21:12]    = help: add #![feature(bound_cloned)] to the crate attributes to enable
[01:21:12] error[E0658]: use of unstable library feature 'bound_cloned'
[01:21:12]   --> src/libcore/../libcore/tests/ops.rs:93:36
[01:21:12]    |
[01:21:12]    |
[01:21:12] 93 |     assert_eq!(Bound::Included(&3).cloned(), Bound::Included(3));
[01:21:12]    |
[01:21:12]    = note: for more information, see https://github.com/rust-lang/rust/issues/61356
[01:21:12]    = note: for more information, see https://github.com/rust-lang/rust/issues/61356
[01:21:12]    = help: add #![feature(bound_cloned)] to the crate attributes to enable
[01:21:12] error[E0658]: use of unstable library feature 'bound_cloned'
[01:21:12]   --> src/libcore/../libcore/tests/ops.rs:98:36
[01:21:12]    |
[01:21:12]    |
[01:21:12] 98 |     assert_eq!(Bound::Excluded(&3).cloned(), Bound::Excluded(3));
[01:21:12]    |
[01:21:12]    = note: for more information, see https://github.com/rust-lang/rust/issues/61356
[01:21:12]    = note: for more information, see https://github.com/rust-lang/rust/issues/61356
[01:21:12]    = help: add #![feature(bound_cloned)] to the crate attributes to enable
[01:21:14] error: aborting due to 3 previous errors
[01:21:14] 
[01:21:14] For more information about this error, try `rustc --explain E0658`.
[01:21:14] error: Could not compile `core`.
[01:21:14] error: Could not compile `core`.
[01:21:14] 
[01:21:14] To learn more, run the command again with --verbose.
[01:21:14] 
[01:21:14] 
[01:21:14] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-p" "core" "--" "--quiet"
[01:21:14] 
[01:21:14] 
[01:21:14] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:21:14] Build completed unsuccessfully in 1:17:03
[01:21:14] Build completed unsuccessfully in 1:17:03
j/build/bootstrap/debug/incremental
146428 ./obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib
135320 ./obj/build/bootstrap/debug/incremental/bootstrap-oxgzobynhmm1
135316 ./obj/build/bootstrap/debug/incremental/bootstrap-oxgzobynhmm1/s-fcqu72vki1-tdqsf8-2t7iak7gjee0p
123648 ./src/llvm-project/llvm/test/CodeGen
121960 ./obj/build/x86_64-unknown-linux-gnu/test/mir-opt
108532 ./src/llvm-project/lldb
104940 ./obj/build/x86_64-unknown-linux-gnu/test/rustdoc/intra-link-libstd-re-export
---
70836 ./obj/build/x8658355
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:023d1e00
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:02c793b6
travis_time:start:02c793b6
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:00618d68
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@czipperz
Copy link
Contributor Author

czipperz commented Jun 1, 2019

Is there a precedent for testing unstable features in external test directories?

@sfackler
Copy link
Member

sfackler commented Jun 1, 2019

You just need to add the feature gate here: https://github.com/rust-lang/rust/blob/master/src/libcore/tests/lib.rs#L1

@czipperz
Copy link
Contributor Author

czipperz commented Jun 1, 2019

I probably need to feature gate the doctest as well

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 6, 2019
@bors
Copy link
Contributor

bors commented Jun 6, 2019

⌛ Testing commit c1bc8f1 with merge ca556899aaebe5ce776b65173b0bcb5103a9418b...

@bors
Copy link
Contributor

bors commented Jun 6, 2019

💔 Test failed - checks-travis

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-distcheck of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:05:21]    Compiling aho-corasick v0.7.3
[00:05:21]    Compiling bstr v0.1.4
[00:05:22]    Compiling clap v2.33.0
[00:05:23]    Compiling tar v0.4.26
[00:05:25] error[E0277]: the trait bound `rand_hc::Hc128Rng: rand_core::SeedableRng` is not satisfied
[00:05:25]   --> /cargo/registry/src/github.com-1ecc6299db9ec823/rand-0.6.5/src/rngs/std.rs:55:6
[00:05:25]    |
[00:05:25] 55 | impl SeedableRng for StdRng {
[00:05:25]    |      ^^^^^^^^^^^ the trait `rand_core::SeedableRng` is not implemented for `rand_hc::Hc128Rng`
[00:05:25] 
[00:05:25] error[E0277]: the trait bound `rand_isaac::IsaacRng: rand_core::SeedableRng` is not satisfied
[00:05:25]    |
[00:05:25]    |
[00:05:25] 50 | impl SeedableRng for IsaacRng {
[00:05:25]    |      ^^^^^^^^^^^ the trait `rand_core::SeedableRng` is not implemented for `rand_isaac::IsaacRng`
[00:05:25] 
[00:05:25] error[E0277]: the trait bound `rand_isaac::Isaac64Rng: rand_core::SeedableRng` is not satisfied
[00:05:25]    |
[00:05:25]    |
[00:05:25] 96 | impl SeedableRng for Isaac64Rng {
[00:05:25]    |      ^^^^^^^^^^^ the trait `rand_core::SeedableRng` is not implemented for `rand_isaac::Isaac64Rng`
[00:05:25] 
[00:05:25] error[E0277]: the trait bound `rand_hc::Hc128Rng: rand_core::SeedableRng` is not satisfied
[00:05:25]     |
[00:05:25]     |
[00:05:25] 198 | impl SeedableRng for Hc128Rng {
[00:05:25]     |      ^^^^^^^^^^^ the trait `rand_core::SeedableRng` is not implemented for `rand_hc::Hc128Rng`
[00:05:25] 
[00:05:25] error[E0277]: the trait bound `rand_xorshift::XorShiftRng: rand_core::SeedableRng` is not satisfied
[00:05:25]     |
[00:05:25]     |
[00:05:25] 239 | impl SeedableRng for XorShiftRng {
[00:05:25]     |      ^^^^^^^^^^^ the trait `rand_core::SeedableRng` is not implemented for `rand_xorshift::XorShiftRng`
[00:05:25] 
[00:05:25] error[E0277]: the trait bound `rand_hc::Hc128Rng: rand_core::SeedableRng` is not satisfied
[00:05:25]     |
[00:05:25]     |
[00:05:25] 279 | impl SeedableRng for StdRng {
[00:05:25]     |      ^^^^^^^^^^^ the trait `rand_core::SeedableRng` is not implemented for `rand_hc::Hc128Rng`
[00:05:25] 
[00:05:25] error[E0277]: the trait bound `rand_hc::Hc128Core: rand_core::block::BlockRngCore` is not satisfied
[00:05:25]   --> /cargo/registry/src/github.com-1ecc6299db9ec823/rand-0.6.5/src/rngs/thread.rs:73:5
[00:05:25]    |
[00:05:25] 73 |     rng: *mut ReseedingRng<Hc128Core, EntropyRng>,
[00:05:25]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `rand_core::block::BlockRngCore` is not implemented for `rand_hc::Hc128Core`
[00:05:25]    |
[00:05:25] note: required by `rngs::adapter::reseeding::ReseedingRng`
[00:05:25]   --> /cargo/registry/src/github.com-1ecc6299db9ec823/rand-0.6.5/src/rngs/adapter/reseeding.rs:88:1
[00:05:25]    |
[00:05:25] 88 | / pub struct ReseedingRng<R, Rsdr>(BlockRng<ReseedingCore<R, Rsdr>>)
[00:05:25] 89 | | where R: BlockRngCore + SeedableRng,
[00:05:25] 90 | |       Rsdr: RngCore;
[00:05:25] 
[00:05:25] 
[00:05:25] error[E0277]: the trait bound `rand_hc::Hc128Core: rand_core::SeedableRng` is not satisfied
[00:05:25]   --> /cargo/registry/src/github.com-1ecc6299db9ec823/rand-0.6.5/src/rngs/thread.rs:73:5
[00:05:25]    |
[00:05:25] 73 |     rng: *mut ReseedingRng<Hc128Core, EntropyRng>,
[00:05:25]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `rand_core::SeedableRng` is not implemented for `rand_hc::Hc128Core`
[00:05:25]    |
[00:05:25] note: required by `rngs::adapter::reseeding::ReseedingRng`
[00:05:25]   --> /cargo/registry/src/github.com-1ecc6299db9ec823/rand-0.6.5/src/rngs/adapter/reseeding.rs:88:1
[00:05:25]    |
[00:05:25] 88 | / pub struct ReseedingRng<R, Rsdr>(BlockRng<ReseedingCore<R, Rsdr>>)
[00:05:25] 89 | | where R: BlockRngCore + SeedableRng,
[00:05:25] 90 | |       Rsdr: RngCore;
[00:05:25] 
[00:05:25] 
[00:05:25] error[E0277]: the trait bound `rand_hc::Hc128Core: rand_core::block::BlockRngCore` is not satisfied
[00:05:25]   --> /cargo/registry/src/github.com-1ecc6299db9ec823/rand-0.6.5/src/rngs/thread.rs:76:1
[00:05:25] 76 | / thread_local!(
[00:05:25] 76 | / thread_local!(
[00:05:25] 77 | |     static THREAD_RNG_KEY: UnsafeCell<ReseedingRng<Hc128Core, EntropyRng>> = {
[00:05:25] 78 | |         let mut entropy_source = EntropyRng::new();
[00:05:25] 79 | |         let r = Hc128Core::from_rng(&mut entropy_source).unwrap_or_else(|err|
[00:05:25] 85 | |     }
[00:05:25] 86 | | );
[00:05:25] 86 | | );
[00:05:25]    | |__^ the trait `rand_core::block::BlockRngCore` is not implemented for `rand_hc::Hc128Core`
[00:05:25]    |
[00:05:25] note: required by `rngs::adapter::reseeding::ReseedingRng`
[00:05:25]   --> /cargo/registry/src/github.com-1ecc6299db9ec823/rand-0.6.5/src/rngs/adapter/reseeding.rs:88:1
[00:05:25]    |
[00:05:25] 88 | / pub struct ReseedingRng<R, Rsdr>(BlockRng<ReseedingCore<R, Rsdr>>)
[00:05:25] 89 | | where R: BlockRngCore + SeedableRng,
[00:05:25] 90 | |       Rsdr: RngCore;
[00:05:25]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[00:05:25] 
[00:05:25] 
[00:05:25] error[E0277]: the trait bound `rand_hc::Hc128Core: rand_core::SeedableRng` is not satisfied
[00:05:25]   --> /cargo/registry/src/github.com-1ecc6299db9ec823/rand-0.6.5/src/rngs/thread.rs:76:1
[00:05:25] 76 | / thread_local!(
[00:05:25] 76 | / thread_local!(
[00:05:25] 77 | |     static THREAD_RNG_KEY: UnsafeCell<ReseedingRng<Hc128Core, EntropyRng>> = {
[00:05:25] 78 | |         let mut entropy_source = EntropyRng::new();
[00:05:25] 79 | |         let r = Hc128Core::from_rng(&mut entropy_source).unwrap_or_else(|err|
[00:05:25] 85 | |     }
[00:05:25] 86 | | );
[00:05:25] 86 | | );
[00:05:25]    | |__^ the trait `rand_core::SeedableRng` is not implemented for `rand_hc::Hc128Core`
[00:05:25]    |
[00:05:25] note: required by `rngs::adapter::reseeding::ReseedingRng`
[00:05:25]   --> /cargo/registry/src/github.com-1ecc6299db9ec823/rand-0.6.5/src/rngs/adapter/reseeding.rs:88:1
[00:05:25]    |
[00:05:25] 88 | / pub struct ReseedingRng<R, Rsdr>(BlockRng<ReseedingCore<R, Rsdr>>)
[00:05:25] 89 | | where R: BlockRngCore + SeedableRng,
[00:05:25] 90 | |       Rsdr: RngCore;
[00:05:25]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[00:05:25] 
[00:05:25] 
[00:05:25] error[E0277]: the trait bound `rand_hc::Hc128Core: rand_core::block::BlockRngCore` is not satisfied
[00:05:25]   --> /cargo/registry/src/github.com-1ecc6299db9ec823/rand-0.6.5/src/rngs/thread.rs:76:1
[00:05:25] 76 | / thread_local!(
[00:05:25] 76 | / thread_local!(
[00:05:25] 77 | |     static THREAD_RNG_KEY: UnsafeCell<ReseedingRng<Hc128Core, EntropyRng>> = {
[00:05:25] 78 | |         let mut entropy_source = EntropyRng::new();
[00:05:25] 79 | |         let r = Hc128Core::from_rng(&mut entropy_source).unwrap_or_else(|err|
[00:05:25] 85 | |     }
[00:05:25] 86 | | );
[00:05:25] 86 | | );
[00:05:25]    | |__^ the trait `rand_core::block::BlockRngCore` is not implemented for `rand_hc::Hc128Core`
[00:05:25]    |
[00:05:25] note: required by `rngs::adapter::reseeding::ReseedingRng`
[00:05:25]   --> /cargo/registry/src/github.com-1ecc6299db9ec823/rand-0.6.5/src/rngs/adapter/reseeding.rs:88:1
[00:05:25]    |
[00:05:25] 88 | / pub struct ReseedingRng<R, Rsdr>(BlockRng<ReseedingCore<R, Rsdr>>)
[00:05:25] 89 | | where R: BlockRngCore + SeedableRng,
[00:05:25] 90 | |       Rsdr: RngCore;
[00:05:25]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[00:05:25] 
[00:05:25] 
[00:05:25] error[E0277]: the trait bound `rand_hc::Hc128Core: rand_core::SeedableRng` is not satisfied
[00:05:25]   --> /cargo/registry/src/github.com-1ecc6299db9ec823/rand-0.6.5/src/rngs/thread.rs:76:1
[00:05:25] 76 | / thread_local!(
[00:05:25] 76 | / thread_local!(
[00:05:25] 77 | |     static THREAD_RNG_KEY: UnsafeCell<ReseedingRng<Hc128Core, EntropyRng>> = {
[00:05:25] 78 | |         let mut entropy_source = EntropyRng::new();
[00:05:25] 79 | |         let r = Hc128Core::from_rng(&mut entropy_source).unwrap_or_else(|err|
[00:05:25] 85 | |     }
[00:05:25] 86 | | );
[00:05:25] 86 | | );
[00:05:25]    | |__^ the trait `rand_core::SeedableRng` is not implemented for `rand_hc::Hc128Core`
[00:05:25]    |
[00:05:25] note: required by `rngs::adapter::reseeding::ReseedingRng`
[00:05:25]   --> /cargo/registry/src/github.com-1ecc6299db9ec823/rand-0.6.5/src/rngs/adapter/reseeding.rs:88:1
[00:05:25]    |
[00:05:25] 88 | / pub struct ReseedingRng<R, Rsdr>(BlockRng<ReseedingCore<R, Rsdr>>)
[00:05:25] 89 | | where R: BlockRngCore + SeedableRng,
[00:05:25] 90 | |       Rsdr: RngCore;
[00:05:25]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[00:05:25] 
[00:05:25] 
[00:05:25] error[E0277]: the trait bound `rand_hc::Hc128Core: rand_core::block::BlockRngCore` is not satisfied
[00:05:25]   --> /cargo/registry/src/github.com-1ecc6299db9ec823/rand-0.6.5/src/rngs/thread.rs:76:1
[00:05:25] 76 | / thread_local!(
[00:05:25] 76 | / thread_local!(
[00:05:25] 77 | |     static THREAD_RNG_KEY: UnsafeCell<ReseedingRng<Hc128Core, EntropyRng>> = {
[00:05:25] 78 | |         let mut entropy_source = EntropyRng::new();
[00:05:25] 79 | |         let r = Hc128Core::from_rng(&mut entropy_source).unwrap_or_else(|err|
[00:05:25] 85 | |     }
[00:05:25] 86 | | );
[00:05:25] 86 | | );
[00:05:25]    | |__^ the trait `rand_core::block::BlockRngCore` is not implemented for `rand_hc::Hc128Core`
[00:05:25]    |
[00:05:25] note: required by `rngs::adapter::reseeding::ReseedingRng`
[00:05:25]   --> /cargo/registry/src/github.com-1ecc6299db9ec823/rand-0.6.5/src/rngs/adapter/reseeding.rs:88:1
[00:05:25]    |
[00:05:25] 88 | / pub struct ReseedingRng<R, Rsdr>(BlockRng<ReseedingCore<R, Rsdr>>)
[00:05:25] 89 | | where R: BlockRngCore + SeedableRng,
[00:05:25] 90 | |       Rsdr: RngCore;
[00:05:25]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[00:05:25] 
[00:05:25] 
[00:05:25] error[E0277]: the trait bound `rand_hc::Hc128Core: rand_core::SeedableRng` is not satisfied
[00:05:25]   --> /cargo/registry/src/github.com-1ecc6299db9ec823/rand-0.6.5/src/rngs/thread.rs:76:1
[00:05:25] 76 | / thread_local!(
[00:05:25] 76 | / thread_local!(
[00:05:25] 77 | |     static THREAD_RNG_KEY: UnsafeCell<ReseedingRng<Hc128Core, EntropyRng>> = {
[00:05:25] 78 | |         let mut entropy_source = EntropyRng::new();
[00:05:25] 79 | |         let r = Hc128Core::from_rng(&mut entropy_source).unwrap_or_else(|err|
[00:05:25] 85 | |     }
[00:05:25] 86 | | );
[00:05:25] 86 | | );
[00:05:25]    | |__^ the trait `rand_core::SeedableRng` is not implemented for `rand_hc::Hc128Core`
[00:05:25]    |
[00:05:25] note: required by `rngs::adapter::reseeding::ReseedingRng`
[00:05:25]   --> /cargo/registry/src/github.com-1ecc6299db9ec823/rand-0.6.5/src/rngs/adapter/reseeding.rs:88:1
[00:05:25]    |
[00:05:25] 88 | / pub struct ReseedingRng<R, Rsdr>(BlockRng<ReseedingCore<R, Rsdr>>)
[00:05:25] 89 | | where R: BlockRngCore + SeedableRng,
[00:05:25] 90 | |       Rsdr: RngCore;
[00:05:25]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[00:05:25] 
[00:05:25] 
[00:05:25] error[E0277]: the trait bound `rand_hc::Hc128Core: rand_core::block::BlockRngCore` is not satisfied
[00:05:25]   --> /cargo/registry/src/github.com-1ecc6299db9ec823/rand-0.6.5/src/rngs/thread.rs:76:1
[00:05:25] 76 | / thread_local!(
[00:05:25] 76 | / thread_local!(
[00:05:25] 77 | |     static THREAD_RNG_KEY: UnsafeCell<ReseedingRng<Hc128Core, EntropyRng>> = {
[00:05:25] 78 | |         let mut entropy_source = EntropyRng::new();
[00:05:25] 79 | |         let r = Hc128Core::from_rng(&mut entropy_source).unwrap_or_else(|err|
[00:05:25] 85 | |     }
[00:05:25] 86 | | );
[00:05:25] 86 | | );
[00:05:25]    | |__^ the trait `rand_core::block::BlockRngCore` is not implemented for `rand_hc::Hc128Core`
[00:05:25]    |
[00:05:25] note: required by `rngs::adapter::reseeding::ReseedingRng`
[00:05:25]   --> /cargo/registry/src/github.com-1ecc6299db9ec823/rand-0.6.5/src/rngs/adapter/reseeding.rs:88:1
[00:05:25]    |
[00:05:25] 88 | / pub struct ReseedingRng<R, Rsdr>(BlockRng<ReseedingCore<R, Rsdr>>)
[00:05:25] 89 | | where R: BlockRngCore + SeedableRng,
[00:05:25] 90 | |       Rsdr: RngCore;
[00:05:25]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[00:05:25] 
[00:05:25] 
[00:05:25] error[E0277]: the trait bound `rand_hc::Hc128Core: rand_core::SeedableRng` is not satisfied
[00:05:25]   --> /cargo/registry/src/github.com-1ecc6299db9ec823/rand-0.6.5/src/rngs/thread.rs:76:1
[00:05:25] 76 | / thread_local!(
[00:05:25] 76 | / thread_local!(
[00:05:25] 77 | |     static THREAD_RNG_KEY: UnsafeCell<ReseedingRng<Hc128Core, EntropyRng>> = {
[00:05:25] 78 | |         let mut entropy_source = EntropyRng::new();
[00:05:25] 79 | |         let r = Hc128Core::from_rng(&mut entropy_source).unwrap_or_else(|err|
[00:05:25] 85 | |     }
[00:05:25] 86 | | );
[00:05:25] 86 | | );
[00:05:25]    | |__^ the trait `rand_core::SeedableRng` is not implemented for `rand_hc::Hc128Core`
[00:05:25]    |
[00:05:25] note: required by `rngs::adapter::reseeding::ReseedingRng`
[00:05:25]   --> /cargo/registry/src/github.com-1ecc6299db9ec823/rand-0.6.5/src/rngs/adapter/reseeding.rs:88:1
[00:05:25]    |
[00:05:25] 88 | / pub struct ReseedingRng<R, Rsdr>(BlockRng<ReseedingCore<R, Rsdr>>)
[00:05:25] 89 | | where R: BlockRngCore + SeedableRng,
[00:05:25] 90 | |       Rsdr: RngCore;
[00:05:25]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[00:05:25] 
[00:05:25] 
[00:05:25] error[E0277]: the trait bound `rand_hc::Hc128Rng: rand_core::SeedableRng` is not satisfied
[00:05:25]   --> /cargo/registry/src/github.com-1ecc6299db9ec823/rand-0.6.5/src/rngs/std.rs:56:5
[00:05:25]    |
[00:05:25] 56 |     type Seed = <Hc128Rng as SeedableRng>::Seed;
[00:05:25]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `rand_core::SeedableRng` is not implemented for `rand_hc::Hc128Rng`
[00:05:25] 
[00:05:25] error[E0277]: the trait bound `rand_hc::Hc128Rng: rand_core::SeedableRng` is not satisfied
[00:05:25]   --> /cargo/registry/src/github.com-1ecc6299db9ec823/rand-0.6.5/src/rngs/std.rs:58:5
[00:05:25]    |
[00:05:25] 58 | /     fn from_seed(seed: Self::Seed) -> Self {
[00:05:25] 59 | |         StdRng(Hc128Rng::from_seed(seed))
[00:05:25] 60 | |     }
[00:05:25]    | |_____^ the trait `rand_core::SeedableRng` is not implemented for `rand_hc::Hc128Rng`
[00:05:25] 
[00:05:25] error[E0277]: the trait bound `rand_isaac::IsaacRng: rand_core::SeedableRng` is not satisfied
[00:05:25]    |
[00:05:25]    |
[00:05:25] 51 |     type Seed = <rand_isaac::IsaacRng as SeedableRng>::Seed;
[00:05:25]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `rand_core::SeedableRng` is not implemented for `rand_isaac::IsaacRng`
[00:05:25] 
[00:05:25] error[E0277]: the trait bound `rand_isaac::IsaacRng: rand_core::SeedableRng` is not satisfied
[00:05:25]    |
[00:05:25]    |
[00:05:25] 53 | /     fn from_seed(seed: Self::Seed) -> Self {
[00:05:25] 54 | |         IsaacRng(rand_isaac::IsaacRng::from_seed(seed))
[00:05:25] 55 | |     }
[00:05:25]    | |_____^ the trait `rand_core::SeedableRng` is not implemented for `rand_isaac::IsaacRng`
[00:05:25] 
[00:05:25] error[E0277]: the trait bound `rand_isaac::Isaac64Rng: rand_core::SeedableRng` is not satisfied
[00:05:25]    |
[00:05:25]    |
[00:05:25] 97 |     type Seed = <rand_isaac::Isaac64Rng as SeedableRng>::Seed;
[00:05:25]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `rand_core::SeedableRng` is not implemented for `rand_isaac::Isaac64Rng`
[00:05:25] 
[00:05:25] error[E0277]: the trait bound `rand_isaac::Isaac64Rng: rand_core::SeedableRng` is not satisfied
[00:05:25]     |
[00:05:25]     |
[00:05:25] 99  | /     fn from_seed(seed: Self::Seed) -> Self {
[00:05:25] 100 | |         Isaac64Rng(rand_isaac::Isaac64Rng::from_seed(seed))
[00:05:25] 101 | |     }
[00:05:25]     | |_____^ the trait `rand_core::SeedableRng` is not implemented for `rand_isaac::Isaac64Rng`
[00:05:25] 
[00:05:25] error[E0277]: the trait bound `rand_hc::Hc128Rng: rand_core::SeedableRng` is not satisfied
[00:05:25]     |
[00:05:25]     |
[00:05:25] 199 |     type Seed = <rand_hc::Hc128Rng as SeedableRng>::Seed;
[00:05:25]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `rand_core::SeedableRng` is not implemented for `rand_hc::Hc128Rng`
[00:05:25] 
[00:05:25] error[E0277]: the trait bound `rand_hc::Hc128Rng: rand_core::SeedableRng` is not satisfied
[00:05:25]     |
[00:05:25]     |
[00:05:25] 201 | /     fn from_seed(seed: Self::Seed) -> Self {
[00:05:25] 202 | |         Hc128Rng(rand_hc::Hc128Rng::from_seed(seed))
[00:05:25] 203 | |     }
[00:05:25]     | |_____^ the trait `rand_core::SeedableRng` is not implemented for `rand_hc::Hc128Rng`
[00:05:25] 
[00:05:25] error[E0277]: the trait bound `rand_xorshift::XorShiftRng: rand_core::SeedableRng` is not satisfied
[00:05:25]     |
[00:05:25]     |
[00:05:25] 240 |     type Seed = <::rand_xorshift::XorShiftRng as SeedableRng>::Seed;
[00:05:25]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `rand_core::SeedableRng` is not implemented for `rand_xorshift::XorShiftRng`
[00:05:25] 
[00:05:25] error[E0277]: the trait bound `rand_xorshift::XorShiftRng: rand_core::SeedableRng` is not satisfied
[00:05:25]     |
[00:05:25]     |
[00:05:25] 242 | /     fn from_seed(seed: Self::Seed) -> Self {
[00:05:25] 243 | |         XorShiftRng(::rand_xorshift::XorShiftRng::from_seed(seed))
[00:05:25] 244 | |     }
[00:05:25]     | |_____^ the trait `rand_core::SeedableRng` is not implemented for `rand_xorshift::XorShiftRng`
[00:05:25] 
[00:05:25] error[E0277]: the trait bound `rand_hc::Hc128Rng: rand_core::SeedableRng` is not satisfied
[00:05:25]     |
[00:05:25]     |
[00:05:25] 280 |     type Seed = <rngs::StdRng as SeedableRng>::Seed;
[00:05:25]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `rand_core::SeedableRng` is not implemented for `rand_hc::Hc128Rng`
[00:05:25] 
[00:05:25] error[E0277]: the trait bound `rand_hc::Hc128Rng: rand_core::SeedableRng` is not satisfied
[00:05:25]     |
[00:05:25]     |
[00:05:25] 282 | /     fn from_seed(seed: Self::Seed) -> Self {
[00:05:25] 283 | |         StdRng(rngs::StdRng::from_seed(seed))
[00:05:25] 284 | |     }
[00:05:25]     | |_____^ the trait `rand_core::SeedableRng` is not implemented for `rand_hc::Hc128Rng`
[00:05:25]    Compiling url v1.7.2
[00:05:25] error: aborting due to 28 previous errors
[00:05:25] 
[00:05:25] For more information about this error, try `rustc --explain E0277`.
[00:05:25] For more information about this error, try `rustc --explain E0277`.
[00:05:25] error: Could not compile `rand`.
[00:05:25] warning: build failed, waiting for other jobs to finish...
[00:05:31] error: failed to compile `cargo-vendor v0.1.22`, intermediate artifacts can be found at `/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools`
[00:05:31] Caused by:
[00:05:31]   build failed
[00:05:31] 
[00:05:31] 
[00:05:31] 
[00:05:31] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "install" "-j" "4" "--locked" "--color" "always" "--force" "--debug" "--vers" "0.1.22" "cargo-vendor"
[00:05:31] 
[00:05:31] 
[00:05:31] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test distcheck
[00:05:31] Build completed unsuccessfully in 0:00:43
---
travis_time:end:163eb348:start=1559837144352244760,finish=1559837144359472503,duration=7227743
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:03825656
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:01bd3052
travis_time:start:01bd3052
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:2044f371
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 6, 2019
@pietroalbini
Copy link
Member

The rand crate broke.
@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 6, 2019
@bors
Copy link
Contributor

bors commented Jun 6, 2019

⌛ Testing commit c1bc8f1 with merge 58cd42efe1f628678e4700e852cae54e9d39ab77...

Centril added a commit to Centril/rust that referenced this pull request Jun 6, 2019
@Centril
Copy link
Contributor

Centril commented Jun 6, 2019

@bors retry

@bors
Copy link
Contributor

bors commented Jun 6, 2019

⌛ Testing commit c1bc8f1 with merge d4943ea7d0e3102ae46319a21757036fa8d59eb4...

@bors
Copy link
Contributor

bors commented Jun 6, 2019

💔 Test failed - checks-travis

@rust-highfive
Copy link
Collaborator

The job test-various of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[01:40:01] test time::tests::system_time_elapsed ... ok
[01:40:01] test time::tests::system_time_math ... ok
[01:40:02] test thread::tests::test_park_timeout_unpark_called_other_thread ... ok
[01:40:09] test sync::mpsc::tests::stress_recv_timeout_two_threads ... ok
[01:40:59] test process::tests::uid_works ... test process::tests::uid_works has been running for over 60 seconds
No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 6, 2019
@Centril
Copy link
Contributor

Centril commented Jun 6, 2019

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 6, 2019
Centril added a commit to Centril/rust that referenced this pull request Jun 6, 2019
bors added a commit that referenced this pull request Jun 6, 2019
Rollup of 5 pull requests

Successful merges:

 - #61376 (Add Bound::cloned())
 - #61554 (Change visit api)
 - #61559 (Make visitors iterate)
 - #61585 (Update .mailmap with my name)
 - #61591 (Update .mailmap)

Failed merges:

r? @ghost
@bors bors merged commit c1bc8f1 into rust-lang:master Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants