-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bound::cloned() #61376
Add Bound::cloned() #61376
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
Open question: should |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
r? @sfackler |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Some bozo has to write tests for this lol |
IMO the doc test is sufficient, but it needs to be a |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
LGTM but the build is still failing. Looks like you just need to enable the feature in core's lib.rs |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Is there a precedent for testing unstable features in external test directories? |
You just need to add the feature gate here: https://github.com/rust-lang/rust/blob/master/src/libcore/tests/lib.rs#L1 |
I probably need to feature gate the doctest as well |
⌛ Testing commit c1bc8f1 with merge ca556899aaebe5ce776b65173b0bcb5103a9418b... |
💔 Test failed - checks-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
The rand crate broke. |
⌛ Testing commit c1bc8f1 with merge 58cd42efe1f628678e4700e852cae54e9d39ab77... |
Add Bound::cloned() Suggested by rust-lang#61356
@bors retry |
⌛ Testing commit c1bc8f1 with merge d4943ea7d0e3102ae46319a21757036fa8d59eb4... |
💔 Test failed - checks-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@bors retry |
Add Bound::cloned() Suggested by rust-lang#61356
Suggested by #61356