Make visitors iterate #61559
Merged
Make visitors iterate #61559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Centril
reviewed
Jun 5, 2019
| ); | ||
| } | ||
|
|
||
| context = if context.is_mutating_use() { |
There was a problem hiding this comment.
Doing this suggests to me that you want a .fold method on place such that you can provide an initial state...
There was a problem hiding this comment.
Yeah, may be nice to fix that. Maybe we can leave this for a different PR?. It's pre-existing logic that exists in the default Visitor implementation.
There was a problem hiding this comment.
Sure, file an issue about it?
There was a problem hiding this comment.
We don't need an explicit fold method. place_projections is an iterator, so we can just call fold on it.
There was a problem hiding this comment.
fold does not work ok because there's a return and a continue there and we would be trying to do that inside a closure :/
spastorino
force-pushed
the
make-visitors-iterate
branch
from
3754891 to
0cfaa28
Compare
oli-obk
requested changes
Jun 6, 2019
| ); | ||
| } | ||
|
|
||
| context = if context.is_mutating_use() { |
There was a problem hiding this comment.
We don't need an explicit fold method. place_projections is an iterator, so we can just call fold on it.
| } | ||
| } | ||
| }; | ||
| self.super_place(place, context, location); |
There was a problem hiding this comment.
you can keep the base checking after the projection checking. It's not very important, all that can happen is that the order of evaluation changes. Since the order is not important, put the base checking back here, so the diff is smaller.
|
@bors r+ |
|
📌 Commit 0cfaa28 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jun 6, 2019
…=oli-obk Make visitors iterate r? @oli-obk The second commit is not completely equivalent, unsure if the code is wrong or not. Tests pass though, otherwise we would need to iterate in the opposite direction as it happened in other parts of the code.
|
⌛ Testing commit 0cfaa28 with merge cbed462bc49e95754ea8d1115a93666636c0a670... |
|
💔 Test failed - checks-travis |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jun 6, 2019
…=oli-obk Make visitors iterate r? @oli-obk The second commit is not completely equivalent, unsure if the code is wrong or not. Tests pass though, otherwise we would need to iterate in the opposite direction as it happened in other parts of the code.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jun 6, 2019
…=oli-obk Make visitors iterate r? @oli-obk The second commit is not completely equivalent, unsure if the code is wrong or not. Tests pass though, otherwise we would need to iterate in the opposite direction as it happened in other parts of the code.
RalfJung
reviewed
May 16, 2020
| } | ||
| } | ||
|
|
||
| for proj in place_projections { | ||
| if context.is_borrow() { | ||
| if util::is_disaligned(self.tcx, self.mir, self.param_env, place) { |
There was a problem hiding this comment.
This change looks very suspicious. Previously, place was different on every iteration. Now it is the same, only proj changes. I think this means we are not actually properly checking every place in this deref chain for alignment any more, which would be soundness bug.
There was a problem hiding this comment.
Ah no, we actually only care about the outermost place as that's what the reference is created for.
But then it seems unnecessary to have this in the loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @oli-obk
The second commit is not completely equivalent, unsure if the code is wrong or not. Tests pass though, otherwise we would need to iterate in the opposite direction as it happened in other parts of the code.