Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for ops::Bound::cloned() #61356

Closed
czipperz opened this issue May 30, 2019 · 6 comments · Fixed by #86797
Closed

Tracking issue for ops::Bound::cloned() #61356

czipperz opened this issue May 30, 2019 · 6 comments · Fixed by #86797
Assignees
@inquisitivecrystal
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. Libs-Tracked Libs issues that are tracked on the team's project board. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@czipperz
Copy link
Contributor

This is needed because RangeBounds::start_bound() returns Bound(&T) but I need a Bound(T).
@jonas-schievink jonas-schievink added C-feature-request Category: A feature request, i.e: not implemented / a PR. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels May 30, 2019
@czipperz czipperz mentioned this issue May 30, 2019
Merged
Centril added a commit to Centril/rust that referenced this issue Jun 6, 2019
@Centril
Rollup merge of rust-lang#61376 - czipperz:bound-cloned, r=sfackler
6c5c143 
Add Bound::cloned()

Suggested by rust-lang#61356
Centril added a commit to Centril/rust that referenced this issue Jun 6, 2019
@Centril
Rollup merge of rust-lang#61376 - czipperz:bound-cloned, r=sfackler
654854f 
Add Bound::cloned()

Suggested by rust-lang#61356
@czipperz czipperz changed the title Add .cloned() method to ops::Bound. Tracking issue: Add .cloned() method to ops::Bound. Jul 7, 2019
@czipperz

This comment has been minimized.

Sign in to view
@czipperz czipperz changed the title Tracking issue: Add .cloned() method to ops::Bound. Tracking issue for ops::Bound::cloned() Jul 7, 2019
@Centril Centril added C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC B-unstable Blocker: Implemented in the nightly compiler and unstable. and removed C-feature-request Category: A feature request, i.e: not implemented / a PR. labels Jul 7, 2019
@KodrAus KodrAus added the Libs-Tracked Libs issues that are tracked on the team's project board. label Jul 30, 2020
@vorot93
Copy link

vorot93 commented Feb 25, 2021

Any path to stabilization?

@m-ou-se
Copy link
Member

m-ou-se commented Jun 8, 2021

@rfcbot merge

@rfcbot
Copy link

rfcbot commented Jun 8, 2021 •
edited by yaahc
Loading

Team member @m-ou-se has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Jun 8, 2021
@rfcbot
Copy link

rfcbot commented Jun 14, 2021

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Jun 24, 2021
@rfcbot
Copy link

rfcbot commented Jun 24, 2021

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

@rfcbot rfcbot added the to-announce Announce this issue on triage meeting label Jun 24, 2021
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Jul 1, 2021
@inquisitivecrystal inquisitivecrystal mentioned this issue Jul 2, 2021
Merged
@bors bors closed this as completed in cd3a48f Jul 2, 2021
@inquisitivecrystal inquisitivecrystal self-assigned this Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@inquisitivecrystal inquisitivecrystal

Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. Libs-Tracked Libs issues that are tracked on the team's project board. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stabilize Bound::cloned() inquisitivecrystal/rust
9 participants
@vorot93 @m-ou-se @Centril @jonas-schievink @apiraino @KodrAus @czipperz @rfcbot @inquisitivecrystal