-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 22 pull requests #59364
Rollup of 22 pull requests #59364
Conversation
When failing to parse struct-like enum variants, the ADT gets recorded as having no fields. Record that we have actually recovered during parsing of this variant to avoid complaing about non-existing fields when actually using it.
Co-Authored-By: Gabriel Smith <[email protected]>
…r=Zoxc HirIdification: kill off NodeId stragglers The final stages of HirIdification (rust-lang#57578). This PR, along with rust-lang#59042, should finalize the HirIdification process (at least the more straightforward bits). - replace `NodeId` with `HirId` in `trait_impls` - remove all `NodeId`s from `borrowck` - remove all `NodeId`s from `typeck` - remove all `NodeId`s from `mir` - remove `trait_auto_impl` (unused) I would be cool to also remove `NodeId` from `hir::def::Def`, `middle::privacy::AccessLevel` and `hir::ItemId`, but I don't know if this is feasible. I'll be happy to do more if I've missed anything.
Tweak some diagnostic spans
middle: replace NodeId with HirId in AccessLevels Pushing the limits of HirIdification (rust-lang#57578). Replaces `NodeId` with `HirId` in `middle::privacy::AccessLevels`. Actually this time I was more successful and cracked it; I probably tried to HirIdify too much at once when I attempted it last time ^^. r? @Zoxc
…ietMisdreavus,eddyb Add const generics to rustdoc Split out from rust-lang#53645. This work is a collaborative effort with @yodaldevoid. The `FIXME`s are waiting on a refactor to `LazyConst`. I'll address these in a follow up, but I thought it would be better to implement the rest now to avoid bitrot. r? @QuietMisdreavus
…r=steveklabnik Update and clean up several parts of CONTRIBUTING.md
Remove inline assembly from hint::spin_loop This PR removes the inline assembly which was not required since these instructions are available in core::arch, and extends support of the spin_loop hint to arm targets with the v6 feature which also support the yield instruction.
use the identifier span for missing struct field
…etrochenkov Do not complain about non-existing fields after parse recovery When failing to parse struct-like enum variants, the ADT gets recorded as having no fields. Record that we have actually recovered during parsing of this variant to avoid complaing about non-existing fields when actually using it. Fix rust-lang#57361.
some small HIR doc improvements
…xcrichton Make Option<ThreadId> no larger than ThreadId, with NonZeroU64
…estebank convert field/method confusion help to suggestions
Move some bench tests back from libtest It doesn't make much sense to test these on rust-lang/libtest since they exercise the `#[bench]` macro which is part of rust-lang/rust. This PR moves these tests back here. r? @alexcrichton
…chton Add messages for different verbosity levels. Output copy actions.
Tweak incorrect escaped char diagnostic
…arkor use suggestions for "enum instead of variant" error
Add NAN test to docs Documents and tests NAN behavior for the new (f32, f64)::clamp function.
cleanup: Remove compile-fail-fulldeps directory again It was already removed once in rust-lang#56444, but was partially resurrected by rebase of some other PR.
Move one test from run-make-fulldeps to ui The test was written when `--extern` without path didn't exist.
Add tracking issue number for `seek_convenience` We forgot to do that in rust-lang#58422
…ircuiting, r=Centril Demo `FromIterator` short-circuiting while looking at a FIXME in `FromIterator for Option` and `FromIterator for Result`, I realized that the current documentation does not have example code showing exactly what is meant by "no further elements are taken." The code snippets provided here are meant to correct that.
@bors r+ p=5 |
📌 Commit f90f0b3 has been approved by |
#59362 is failed |
@bors r- |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Successful merges:
$ty::AssocItem
andty!()::AssocItem
#59058 ( syntax: Better recovery for$ty::AssocItem
andty!()::AssocItem
)seek_convenience
#59360 (Add tracking issue number forseek_convenience
)FromIterator
short-circuiting #59362 (DemoFromIterator
short-circuiting)Failed merges:
r? @ghost