Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 22 pull requests #59364

Closed
wants to merge 81 commits into from

Conversation

Mark-Simulacrum
Copy link
Member

Successful merges:

Failed merges:

r? @ghost

ljedrz and others added 30 commits March 10, 2019 13:07
When failing to parse struct-like enum variants, the ADT gets recorded
as having no fields. Record that we have actually recovered during
parsing of this variant to avoid complaing about non-existing fields
when actually using it.
Co-Authored-By: Gabriel Smith <[email protected]>
…r=Zoxc

HirIdification: kill off NodeId stragglers

The final stages of HirIdification (rust-lang#57578).

This PR, along with rust-lang#59042, should finalize the HirIdification process (at least the more straightforward bits).

- replace `NodeId` with `HirId` in `trait_impls`
- remove all `NodeId`s from `borrowck`
- remove all `NodeId`s from `typeck`
- remove all `NodeId`s from `mir`
- remove `trait_auto_impl` (unused)

I would be cool to also remove `NodeId` from `hir::def::Def`, `middle::privacy::AccessLevel`  and `hir::ItemId`, but I don't know if this is feasible.

I'll be happy to do more if I've missed anything.
middle: replace NodeId with HirId in AccessLevels

Pushing the limits of HirIdification (rust-lang#57578).

Replaces `NodeId` with `HirId` in `middle::privacy::AccessLevels`. Actually this time I was more successful and cracked it; I probably tried to HirIdify too much at once when I attempted it last time ^^.

r? @Zoxc
…ietMisdreavus,eddyb

Add const generics to rustdoc

Split out from rust-lang#53645. This work is a collaborative effort with @yodaldevoid.

The `FIXME`s are waiting on a refactor to `LazyConst`. I'll address these in a follow up, but I thought it would be better to implement the rest now to avoid bitrot.

r? @QuietMisdreavus
…r=steveklabnik

Update and clean up several parts of CONTRIBUTING.md
Remove inline assembly from hint::spin_loop

This PR removes the inline assembly which was not required since these
instructions are available in core::arch, and extends support of
the spin_loop hint to arm targets with the v6 feature which also
support the yield instruction.
use the identifier span for missing struct field
…etrochenkov

Do not complain about non-existing fields after parse recovery

When failing to parse struct-like enum variants, the ADT gets recorded
as having no fields. Record that we have actually recovered during
parsing of this variant to avoid complaing about non-existing fields
when actually using it.

Fix rust-lang#57361.
…xcrichton

Make Option<ThreadId> no larger than ThreadId, with NonZeroU64
…estebank

convert field/method confusion help to suggestions
Move some bench tests back from libtest

It doesn't make much sense to test these on rust-lang/libtest since they exercise the `#[bench]` macro which is part of rust-lang/rust.

This PR moves these tests back here.

r? @alexcrichton
…chton

Add messages for different verbosity levels. Output copy actions.
Tweak incorrect escaped char diagnostic
…arkor

use suggestions for "enum instead of variant" error
Add NAN test to docs

Documents and tests NAN behavior for the new (f32, f64)::clamp function.
cleanup: Remove compile-fail-fulldeps directory again

It was already removed once in rust-lang#56444, but was partially resurrected by rebase of some other PR.
Move one test from run-make-fulldeps to ui

The test was written when `--extern` without path didn't exist.
Add tracking issue number for `seek_convenience`

We forgot to do that in rust-lang#58422
…ircuiting, r=Centril

Demo `FromIterator` short-circuiting

while looking at a FIXME in `FromIterator for Option` and `FromIterator for Result`, I realized that the current documentation does not have example code showing exactly what is meant by "no further elements are taken."

The code snippets provided here are meant to correct that.
@Mark-Simulacrum
Copy link
Member Author

@bors r+ p=5

@bors
Copy link
Contributor

bors commented Mar 22, 2019

📌 Commit f90f0b3 has been approved by Mark-Simulacrum

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 22, 2019
@tesuji
Copy link
Contributor

tesuji commented Mar 22, 2019

#59362 is failed

@Mark-Simulacrum
Copy link
Member Author

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 22, 2019
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:0b1acef7:start=1553259270535831503,finish=1553259365188036606,duration=94652205103
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
Setting environment variables from .travis.yml
---
[01:15:51] diff of stderr:
[01:15:51] 
[01:15:51] 65   --> $DIR/bad-assoc-pat.rs:21:24
[01:15:51] 66    |
[01:15:51] 67 LL |     ($ty: ty) => ($ty::AssocItem)
[01:15:51] -    |                   |
[01:15:51] -    |                   associated item not found in `u8`
[01:15:51] +    |                        ^^^^^^^^^ associated item not found in `u8`
[01:15:51] 71 ...
[01:15:51] 71 ...
[01:15:51] 72 LL |         pat!(u8) => {}
[01:15:51] 
[01:15:51] 76   --> $DIR/bad-assoc-pat.rs:32:16
[01:15:51] 77    |
[01:15:51] 77    |
[01:15:51] 78 LL |         ty!()::AssocItem => {}
[01:15:51] -    |         |
[01:15:51] -    |         associated item not found in `u8`
[01:15:51] +    |                ^^^^^^^^^ associated item not found in `u8`
[01:15:51] 82 
[01:15:51] 82 
[01:15:51] 83 error: aborting due to 12 previous errors
[01:15:51] 84 
[01:15:51] 
[01:15:51] 
[01:15:51] The actual stderr differed from the expected stderr.
[01:15:51] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/did_you_mean/bad-assoc-pat/bad-assoc-pat.stderr
[01:15:51] To update references, rerun the tests and pass the `--bless` flag
[01:15:51] To only update this specific test, also pass `--test-args did_you_mean/bad-assoc-pat.rs`
[01:15:51] error: 1 errors occurred comparing output.
[01:15:51] status: exit code: 1
[01:15:51] status: exit code: 1
[01:15:51] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/did_you_mean/bad-assoc-pat.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/did_you_mean/bad-assoc-pat/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/did_you_mean/bad-assoc-pat/auxiliary" "-A" "unused"
[01:15:51] ------------------------------------------
[01:15:51] 
[01:15:51] ------------------------------------------
[01:15:51] stderr:
[01:15:51] stderr:
[01:15:51] ------------------------------------------
[01:15:51] {"message":"missing angle brackets in associated item path","code":null,"level":"error","spans":[{"file_name":"/checkout/src/test/ui/did_you_mean/bad-assoc-pat.rs","byte_start":36,"byte_end":51,"line_start":3,"line_end":3,"column_start":9,"column_end":24,"is_primary":true,"text":[{"text":"        [u8]::AssocItem => {}","highlight_start":9,"highlight_end":24}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"try","code":null,"level":"help","spans":[{"file_name":"/checkout/src/test/ui/did_you_mean/bad-assoc-pat.rs","byte_start":36,"byte_end":51,"line_start":3,"line_end":3,"column_start":9,"column_end":24,"is_primary":true,"text":[{"text":"        [u8]::AssocItem => {}","highlight_start":9,"highlight_end":24}],"label":null,"suggested_replacement":"<[u8]>::AssocItem","suggestion_applicability":"MaybeIncorrect","expansion":null}],"children":[],"rendered":null}],"rendered":"error: missing angle brackets in associated item path\n  --> /checkout/src/test/ui/did_you_mean/bad-assoc-pat.rs:3:9\n   |\nLL |         [u8]::AssocItem => {}\n   |         ^^^^^^^^^^^^^^^ help: try: `<[u8]>::AssocItem`\n\n"}
[01:15:51] {"message":"missing angle brackets in associated item path","code":null,"level":"error","spans":[{"file_name":"/checkout/src/test/ui/did_you_mean/bad-assoc-pat.rs","byte_start":231,"byte_end":250,"line_start":6,"line_end":6,"column_start":9,"column_end":28,"is_primary":true,"text":[{"text":"        (u8, u8)::AssocItem => {}","highlight_start":9,"highlight_end":28}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"try","code":null,"level":"help","spans":[{"file_name":"/checkout/src/test/ui/did_you_mean/bad-assoc-pat.rs","byte_start":231,"byte_end":250,"line_start":6,"line_end":6,"column_start":9,"column_end":28,"is_primary":true,"text":[{"text":"        (u8, u8)::AssocItem => {}","highlight_start":9,"highlight_end":28}],"label":null,"suggested_replacement":"<(u8, u8)>::AssocItem","suggestion_applicability":"MaybeIncorrect","expansion":null}],"children":[],"rendered":null}],"rendered":"error: missing angle brackets in associated item path\n  --> /checkout/src/test/ui/did_you_mean/bad-assoc-pat.rs:6:9\n   |\nLL |         (u8, u8)::AssocItem => {}\n   |         ^^^^^^^^^^^^^^^^^^^ help: try: `<(u8, u8)>::AssocItem`\n\n"}
[01:15:51] {"message":"missing angle brackets in associated item path","code":null,"level":"error","spans":[{"file_name":"/checkout/src/test/ui/did_you_mean/bad-assoc-pat.rs","byte_start":432,"byte_end":444,"line_start":9,"line_end":9,"column_start":9,"column_end":21,"is_primary":true,"text":[{"text":"        _::AssocItem => {}","highlight_start":9,"highlight_end":21}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"try","code":null,"level":"help","spans":[{"file_name":"/checkout/src/test/ui/did_you_mean/bad-assoc-pat.rs","byte_start":432,"byte_end":444,"line_start":9,"line_end":9,"column_start":9,"column_end":21,"is_primary":true,"text":[{"text":"        _::AssocItem => {}","highlight_start":9,"highlight_end":21}],"label":null,"suggested_replacement":"<_>::AssocItem","suggestion_applicability":"MaybeIncorrect","expansion":null}],"children":[],"rendered":null}],"rendered":"error: missing angle brackets in associated item path\n  --> /checkout/src/test/ui/did_you_mean/bad-assoc-pat.rs:9:9\n   |\nLL |         _::AssocItem => {}\n   |         ^^^^^^^^^^^^ help: try: `<_>::AssocItem`\n\n"}
[01:15:51] {"message":"missing angle brackets in associated item path","code":null,"level":"error","spans":[{"file_name":"/checkout/src/test/ui/did_you_mean/bad-assoc-pat.rs","byte_start":645,"byte_end":661,"line_start":14,"line_end":14,"column_start":10,"column_end":26,"is_primary":true,"text":[{"text":"        &(u8,)::AssocItem => {}","highlight_start":10,"highlight_end":26}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"try","code":null,"level":"help","spans":[{"file_name":"/checkout/src/test/ui/did_you_mean/bad-assoc-pat.rs","byte_start":645,"byte_end":661,"line_start":14,"line_end":14,"column_start":10,"column_end":26,"is_primary":true,"text":[{"text":"        &(u8,)::AssocItem => {}","highlight_start":10,"highlight_end":26}],"label":null,"suggested_replacement":"<(u8,)>::AssocItem","suggestion_applicability":"MaybeIncorrect","expansion":null}],"children":[],"rendered":null}],"rendered":"error: missing angle brackets in associated item path\n  --> /checkout/src/test/ui/did_you_mean/bad-assoc-pat.rs:14:10\n   |\nLL |         &(u8,)::AssocItem => {}\n   |          ^^^^^^^^^^^^^^^^ help: try: `<(u8,)>::AssocItem`\n\n"}
[01:15:51] {"message":"missing angle brackets in associated item path","code":null,"level":"error","spans":[{"file_name":"/checkout/src/test/ui/did_you_mean/bad-assoc-pat.rs","byte_start":1156,"byte_end":1172,"line_start":32,"line_end":32,"column_start":9,"column_end":25,"is_primary":true,"text":[{"text":"        ty!()::AssocItem => {}","highlight_start":9,"highlight_end":25}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"try","code":null,"level":"help","spans":[{"file_name":"/checkout/src/test/ui/did_you_mean/bad-assoc-pat.rs","byte_start":1156,"byte_end":1172,"line_start":32,"line_end":32,"column_start":9,"column_end":25,"is_primary":true,"text":[{"text":"        ty!()::AssocItem => {}","highlight_start":9,"highlight_end":25}],"label":null,"suggested_replacement":"<ty!()>::AssocItem","suggestion_applicability":"MaybeIncorrect","expansion":null}],"children":[],"rendered":null}],"rendered":"error: missing angle brackets in associated item path\n  --> /checkout/src/test/ui/did_you_mean/bad-assoc-pat.rs:32:9\n   |\nLL |         ty!()::AssocItem => {}\n   |         ^^^^^^^^^^^^^^^^ help: try: `<ty!()>::AssocItem`\n\n"}
[01:15:51] {"message":"missing angle brackets in associated item path","code":null,"level":"error","spans":[{"file_name":"/checkout/src/test/ui/did_you_mean/bad-assoc-pat.rs","byte_start":880,"byte_end":894,"line_start":21,"line_end":21,"column_start":19,"column_end":33,"is_primary":true,"text":[{"text":"    ($ty: ty) => ($ty::AssocItem)","highlight_start":19,"highlight_end":33}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":{"span":{"file_name":"/checkout/src/test/ui/did_you_mean/bad-assoc-pat.rs","byte_start":1133,"byte_end":1141,"line_start":31,"line_end":31,"column_start":9,"column_end":17,"is_primary":false,"text":[{"text":"        pat!(u8) => {}","highlight_start":9,"highlight_end":17}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null},"macro_decl_name":"pat!","def_site_span":{"file_name":"/checkout/src/test/ui/did_you_mean/bad-assoc-pat.rs","byte_start":843,"byte_end":1052,"line_start":20,"line_end":24,"column_start":1,"column_end":2,"is_primary":false,"text":[{"text":"macro_rules! pat {","highlight_start":1,"highlight_end":19},{"text":"    ($ty: ty) => ($ty::AssocItem)","highlight_start":1,"highlight_end":34},{"text":"    //~^ ERROR missing angle brackets in associated item path","highlight_start":1,"highlight_end":62},{"text":"    //~| ERROR no associated item named `AssocItem` found for type `u8` in the current scope","highlight_start":1,"highlight_end":93},{"text":"}","highlight_start":1,"highlight_end":2}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}}}],"children":[{"message":"try","code":null,"level":"help","spans":[{"file_name":"/checkout/src/test/ui/did_you_mean/bad-assoc-pat.rs","byte_start":880,"byte_end":894,"line_start":21,"line_end":21,"column_start":19,"column_end":33,"is_primary":true,"text":[{"text":"    ($ty: ty) => ($ty::AssocItem)","highlight_start":19,"highlight_end":33}],"label":null,"suggested_replacement":"<$ty>::AssocItem","suggestion_applicability":"MaybeIncorrect","expansion":{"span":{"file_name":"/checkout/src/test/ui/did_you_mean/bad-assoc-pat.rs","byte_start":1133,"byte_end":1141,"line_start":31,"line_end":31,"column_start":9,"column_end":17,"is_primary":false,"text":[{"text":"        pat!(u8) => {}","highlight_start":9,"highlight_end":17}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null},"macro_decl_name":"pat!","def_site_span":{"file_name":"/checkout/src/test/ui/did_you_mean/bad-assoc-pat.rs","byte_start":843,"byte_end":1052,"line_start":20,"line_end":24,"column_start":1,"column_end":2,"is_primary":false,"text":[{"text":"macro_rules! pat {","highlight_start":1,"highlight_end":19},{"text":"    ($ty: ty) => ($ty::AssocItem)","highlight_start":1,"highlight_end":34},{"text":"    //~^ ERROR missing angle brackets in associated item path","highlight_start":1,"highlight_end":62},{"text":"    //~| ERROR no associated item named `AssocItem` found for type `u8` in the current scope","highlight_start":1,"highlight_end":93},{"text":"}","highlight_start":1,"highlight_end":2}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}}}],"children":[],"rendered":null}],"rendered":"error: missing angle brackets in associated item path\n  --> /checkout/src/test/ui/did_you_mean/bad-assoc-pat.rs:21:19\n   |\nLL |     ($ty: ty) => ($ty::AssocItem)\n   |                   ^^^^^^^^^^^^^^ help: try: `<$ty>::AssocItem`\n...\nLL |         pat!(u8) => {}\n   |         -------- in this macro invocation\n\n"}
[01:15:51] {"message":"no associated item named `AssocItem` found for type `[u8]` in the current scope","code":{"code":"E0599","explanation":"\nThis error occurs when a method is used on a type which doesn't implement it:\n\nErroneous code example:\n\n```compile_fail,E0599\nstruct Mouth;\n\nlet x = Mouth;\nx.chocolate(); // error: no method named `chocolate` found for type `Mouth`\n               //        in the current scope\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/did_you_mean/bad-assoc-pat.rs","byte_start":42,"byte_end":51,"line_start":3,"line_end":3,"column_start":15,"column_end":24,"is_primary":true,"text":[{"text":"        [u8]::AssocItem => {}","highlight_start":15,"highlight_end":24}],"label":"associated item not found in `[u8]`","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error[E0599]: no associated item named `AssocItem` found for type `[u8]` in the current scope\n  --> /checkout/src/test/ui/did_you_mean/bad-assoc-pat.rs:3:15\n   |\nLL |         [u8]::AssocItem => {}\n   |               ^^^^^^^^^ associated item not found in `[u8]`\n\n"}
[01:15:51] {"message":"no associated item named `AssocItem` found for type `(u8, u8)` in the current scope","code":{"code":"E0599","explanation":"\nThis error occurs when a method is used on a type which doesn't implement it:\n\nErroneous code example:\n\n```compile_fail,E0599\nstruct Mouth;\n\nlet x = Mouth;\nx.chocolate(); // error: no method named `chocolate` found for type `Mouth`\n               //        in the current scope\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/did_you_mean/bad-assoc-pat.rs","byte_start":241,"byte_end":250,"line_start":6,"line_end":6,"column_start":19,"column_end":28,"is_primary":true,"text":[{"text":"        (u8, u8)::AssocItem => {}","highlight_start":19,"highlight_end":28}],"label":"associated item not found in `(u8, u8)`","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error[E0599]: no associated item named `AssocItem` found for type `(u8, u8)` in the current scope\n  --> /checkout/src/test/ui/did_you_mean/bad-assoc-pat.rs:6:19\n   |\nLL |         (u8, u8)::AssocItem => {}\n   |                   ^^^^^^^^^ associated item not found in `(u8, u8)`\n\n"}
[01:15:51] {"message":"no associated item named `AssocItem` found for type `_` in the current scope","code":{"code":"E0599","explanation":"\nThis error occurs when a method is used on a type which doesn't implement it:\n\nErroneous code example:\n\n```compile_fail,E0599\nstruct Mouth;\n\nlet x = Mouth;\nx.chocolate(); // error: no method named `chocolate` found for type `Mouth`\n               //        in the current scope\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/did_you_mean/bad-assoc-pat.rs","byte_start":435,"byte_end":444,"line_start":9,"line_end":9,"column_start":12,"column_end":21,"is_primary":true,"text":[{"text":"        _::AssocItem => {}","highlight_start":12,"highlight_end":21}],"label":"associated item not found in `_`","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error[E0599]: no associated item named `AssocItem` found for type `_` in the current scope\n  --> /checkout/src/test/ui/did_you_mean/bad-assoc-pat.rs:9:12\n   |\nLL |         _::AssocItem => {}\n   |            ^^^^^^^^^ associated item not found in `_`\n\n"}
[01:15:51] {"message":"no associated item named `AssocItem` found for type `(u8,)` in the current scope","code":{"code":"E0599","explanation":"\nThis error occurs when a method is used on a type which doesn't implement it:\n\nErroneous code example:\n\n```compile_fail,E0599\nstruct Mouth;\n\nlet x = Mouth;\nx.chocolate(); // error: no method named `chocolate` found for type `Mouth`\n               //        in the current scope\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/did_you_mean/bad-assoc-pat.rs","byte_start":652,"byte_end":661,"line_start":14,"line_end":14,"column_start":17,"column_end":26,"is_primary":true,"text":[{"text":"        &(u8,)::AssocItem => {}","highlight_start":17,"highlight_end":26}],"label":"associated item not found in `(u8,)`","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error[E0599]: no associated item named `AssocItem` found for type `(u8,)` in the current scope\n  --> /checkout/src/test/ui/did_you_mean/bad-assoc-pat.rs:14:17\n   |\nLL |         &(u8,)::AssocItem => {}\n   |                 ^^^^^^^^^ associated item not found in `(u8,)`\n\n"}
[01:15:51] {"message":"no associated item named `AssocItem` found for type `u8` in the current scope","code":{"code":"E0599","explanation":"\nThis error occurs when a method is used on a type which doesn't implement it:\n\nErroneous code example:\n\n```compile_fail,E0599\nstruct Mouth;\n\nlet x = Mouth;\nx.chocolate(); // error: no method named `chocolate` found for type `Mouth`\n               //        in the current scope\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/did_you_mean/bad-assoc-pat.rs","byte_start":885,"byte_end":894,"line_start":21,"line_end":21,"column_start":24,"column_end":33,"is_primary":true,"text":[{"text":"    ($ty: ty) => ($ty::AssocItem)","highlight_start":24,"highlight_end":33}],"label":"associated item not found in `u8`","suggested_replacement":null,"suggestion_applicability":null,"expansion":{"span":{"file_name":"/checkout/src/test/ui/did_you_mean/bad-assoc-pat.rs","byte_start":1133,"byte_end":1141,"line_start":31,"line_end":31,"column_start":9,"column_end":17,"is_primary":false,"text":[{"text":"        pat!(u8) => {}","highlight_start":9,"highlight_end":17}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null},"macro_decl_name":"pat!","def_site_span":{"file_name":"/checkout/src/test/ui/did_you_mean/bad-assoc-pat.rs","byte_start":843,"byte_end":1052,"line_start":20,"line_end":24,"column_start":1,"column_end":2,"is_primary":false,"text":[{"text":"macro_rules! pat {","highlight_start":1,"highlight_end":19},{"text":"    ($ty: ty) => ($ty::AssocItem)","highlight_start":1,"highlight_end":34},{"text":"    //~^ ERROR missing angle brackets in associated item path","highlight_start":1,"highlight_end":62},{"text":"    //~| ERROR no associated item named `AssocItem` found for type `u8` in the current scope","highlight_start":1,"highlight_end":93},{"text":"}","highlight_start":1,"highlight_end":2}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}}}],"children":[],"rendered":"error[E0599]: no associated item named `AssocItem` found for type `u8` in the current scope\n  --> /checkout/src/test/ui/did_you_mean/bad-assoc-pat.rs:21:24\n   |\nLL |     ($ty: ty) => ($ty::AssocItem)\n   |                        ^^^^^^^^^ associated item not found in `u8`\n...\nLL |         pat!(u8) => {}\n   |         -------- in this macro invocation\n\n"}
[01:15:51] {"message":"no associated item named `AssocItem` found for type `u8` in the current scope","code":{"code":"E0599","explanation":"\nThis error occurs when a method is used on a type which doesn't implement it:\n\nErroneous code example:\n\n```compile_fail,E0599\nstruct Mouth;\n\nlet x = Mouth;\nx.chocolate(); // error: no method named `chocolate` found for type `Mouth`\n               //        in the current scope\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/did_you_mean/bad-assoc-pat.rs","byte_start":1163,"byte_end":1172,"line_start":32,"line_end":32,"column_start":16,"column_end":25,"is_primary":true,"text":[{"text":"        ty!()::AssocItem => {}","highlight_start":16,"highlight_end":25}],"label":"associated item not found in `u8`","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error[E0599]: no associated item named `AssocItem` found for type `u8` in the current scope\n  --> /checkout/src/test/ui/did_you_mean/bad-assoc-pat.rs:32:16\n   |\nLL |         ty!()::AssocItem => {}\n   |                ^^^^^^^^^ associated item not found in `u8`\n\n"}
[01:15:51] {"message":"For more information about this error, try `rustc --explain E0599`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0599`.\n"}
[01:15:51] 
[01:15:51] ------------------------------------------
[01:15:51] 
---
[01:15:51] 
[01:15:51] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:496:22
[01:15:51] 
[01:15:51] 
[01:15:51] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:15:51] 
[01:15:51] 
[01:15:51] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:15:51] Build completed unsuccessfully in 0:04:49
[01:15:51] Build completed unsuccessfully in 0:04:49
[01:15:51] make: *** [check] Error 1
[01:15:51] Makefile:48: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:014741c4
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Fri Mar 22 14:12:06 UTC 2019
---
travis_time:end:26de7ed3:start=1553263927680427904,finish=1553263927685737989,duration=5310085
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:2c247f87
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0602150c
travis_time:start:0602150c
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0ede1e03
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Centril Centril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.